From 1580d302ed277ef48604cc72de58c7a251427afc Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Thu, 10 Sep 2026 14:35:20 -0500 Subject: [PATCH 1/3] test(python): cover function aliases --- .../sedonadb/tests/functions/test_functions.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/python/sedonadb/tests/functions/test_functions.py b/python/sedonadb/tests/functions/test_functions.py index dc7f6f8ce4..075d137e7e 100644 --- a/python/sedonadb/tests/functions/test_functions.py +++ b/python/sedonadb/tests/functions/test_functions.py @@ -2379,6 +2379,24 @@ def test_st_linestringfromtext_alias(eng): ) +@pytest.mark.parametrize("eng", [SedonaDB]) +@pytest.mark.parametrize( + ("query", "expected"), + [ + ( + "SELECT ST_AsWKB(ST_Point(1, 2)) = ST_AsBinary(ST_Point(1, 2))", + True, + ), + ("SELECT ST_AsWKT(ST_Point(1, 2))", "POINT(1 2)"), + ("SELECT ST_Force3DZ(ST_Point(1, 2), 3)", "POINT Z (1 2 3)"), + ("SELECT ST_GeometryFromText('POINT (1 2)')", "POINT (1 2)"), + ], +) +def test_function_aliases(eng, query, expected): + eng = eng.create_or_skip() + eng.assert_query_result(query, expected) + + @pytest.mark.parametrize("eng", [SedonaDB]) @pytest.mark.parametrize( ("fn_name", "wkt", "wrong_empty"), From 63a07ab3c52c28154a8b64ee3146bc0f1e60418b Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Fri, 11 Sep 2026 10:22:04 -0500 Subject: [PATCH 2/3] test(python): colocate alias tests --- .../tests/functions/test_functions.py | 48 ++++++++++++------- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/python/sedonadb/tests/functions/test_functions.py b/python/sedonadb/tests/functions/test_functions.py index 075d137e7e..c3286121a7 100644 --- a/python/sedonadb/tests/functions/test_functions.py +++ b/python/sedonadb/tests/functions/test_functions.py @@ -86,6 +86,14 @@ def test_st_asbinary(eng, geom, expected): eng.assert_query_result(f"SELECT ST_AsBinary({geom_or_null(geom)})", expected) +@pytest.mark.parametrize("eng", [SedonaDB]) +def test_st_aswkb_alias(eng): + eng = eng.create_or_skip() + eng.assert_query_result( + "SELECT ST_AsWKB(ST_Point(1, 2)) = ST_AsBinary(ST_Point(1, 2))", True + ) + + @pytest.mark.parametrize("eng", [SedonaDB, PostGIS]) @pytest.mark.parametrize( ("geom"), @@ -122,6 +130,12 @@ def test_st_astext(eng, geom): eng.assert_query_result(f"SELECT ST_AsText({geom_or_null(geom)})", expected) +@pytest.mark.parametrize("eng", [SedonaDB]) +def test_st_aswkt_alias(eng): + eng = eng.create_or_skip() + eng.assert_query_result("SELECT ST_AsWKT(ST_Point(1, 2))", "POINT(1 2)") + + @pytest.mark.parametrize("eng", [SedonaDB, PostGIS]) @pytest.mark.parametrize( ("geom", "expected"), @@ -1681,6 +1695,14 @@ def test_st_force_dim(eng, geom, expected_2d, expected_3d): eng.assert_query_result(f"SELECT ST_Force3D({geom_or_null(geom)}, 5)", expected_3d) +@pytest.mark.parametrize("eng", [SedonaDB]) +def test_st_force3dz_alias(eng): + eng = eng.create_or_skip() + eng.assert_query_result( + "SELECT ST_Force3DZ(ST_Point(1, 2), 3)", "POINT Z (1 2 3)" + ) + + @pytest.mark.parametrize("eng", [SedonaDB, PostGIS]) @pytest.mark.parametrize( ("geom", "m", "expected_without_m", "expected_with_m"), @@ -2271,6 +2293,14 @@ def test_st_geomfromtext_with_srid(eng, wkt, srid, expected): ) +@pytest.mark.parametrize("eng", [SedonaDB]) +def test_st_geometryfromtext_alias(eng): + eng = eng.create_or_skip() + eng.assert_query_result( + "SELECT ST_GeometryFromText('POINT (1 2)')", "POINT (1 2)" + ) + + @pytest.mark.parametrize("eng", [SedonaDB, PostGIS]) @pytest.mark.parametrize( ("ewkt", "expected", "expected_srid"), @@ -2379,24 +2409,6 @@ def test_st_linestringfromtext_alias(eng): ) -@pytest.mark.parametrize("eng", [SedonaDB]) -@pytest.mark.parametrize( - ("query", "expected"), - [ - ( - "SELECT ST_AsWKB(ST_Point(1, 2)) = ST_AsBinary(ST_Point(1, 2))", - True, - ), - ("SELECT ST_AsWKT(ST_Point(1, 2))", "POINT(1 2)"), - ("SELECT ST_Force3DZ(ST_Point(1, 2), 3)", "POINT Z (1 2 3)"), - ("SELECT ST_GeometryFromText('POINT (1 2)')", "POINT (1 2)"), - ], -) -def test_function_aliases(eng, query, expected): - eng = eng.create_or_skip() - eng.assert_query_result(query, expected) - - @pytest.mark.parametrize("eng", [SedonaDB]) @pytest.mark.parametrize( ("fn_name", "wkt", "wrong_empty"), From dadad0dc89041215b24ee570a6f355ad89e540e6 Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Fri, 11 Sep 2026 10:25:10 -0500 Subject: [PATCH 3/3] style(python): format alias tests --- python/sedonadb/tests/functions/test_functions.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/python/sedonadb/tests/functions/test_functions.py b/python/sedonadb/tests/functions/test_functions.py index c3286121a7..f4b9f4d061 100644 --- a/python/sedonadb/tests/functions/test_functions.py +++ b/python/sedonadb/tests/functions/test_functions.py @@ -1698,9 +1698,7 @@ def test_st_force_dim(eng, geom, expected_2d, expected_3d): @pytest.mark.parametrize("eng", [SedonaDB]) def test_st_force3dz_alias(eng): eng = eng.create_or_skip() - eng.assert_query_result( - "SELECT ST_Force3DZ(ST_Point(1, 2), 3)", "POINT Z (1 2 3)" - ) + eng.assert_query_result("SELECT ST_Force3DZ(ST_Point(1, 2), 3)", "POINT Z (1 2 3)") @pytest.mark.parametrize("eng", [SedonaDB, PostGIS]) @@ -2296,9 +2294,7 @@ def test_st_geomfromtext_with_srid(eng, wkt, srid, expected): @pytest.mark.parametrize("eng", [SedonaDB]) def test_st_geometryfromtext_alias(eng): eng = eng.create_or_skip() - eng.assert_query_result( - "SELECT ST_GeometryFromText('POINT (1 2)')", "POINT (1 2)" - ) + eng.assert_query_result("SELECT ST_GeometryFromText('POINT (1 2)')", "POINT (1 2)") @pytest.mark.parametrize("eng", [SedonaDB, PostGIS])