From 9a0796d58891f9de3cee8f6a0a1efab24ba74563 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Kl=C3=B6ckner?= Date: Thu, 1 Oct 2020 18:15:14 +0200 Subject: [PATCH] Make necessary changes so node-irsdk works with Electron 9.x #32 #86 Based on findings of @heimdallexus and @martinguder. Make sure to rebuild your project. --- binding.gyp | 2 +- src/cpp/IrSdkBindingHelpers.cpp | 2 +- src/node-irsdk.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/binding.gyp b/binding.gyp index 27fa061..a7f5d58 100644 --- a/binding.gyp +++ b/binding.gyp @@ -1,4 +1,4 @@ -{ +{ "targets": [ { "target_name": "IrSdkNodeBindings", diff --git a/src/cpp/IrSdkBindingHelpers.cpp b/src/cpp/IrSdkBindingHelpers.cpp index 962c2b1..9f51bdc 100644 --- a/src/cpp/IrSdkBindingHelpers.cpp +++ b/src/cpp/IrSdkBindingHelpers.cpp @@ -49,7 +49,7 @@ Local NodeIrSdk::convertTelemetryVarToObject(IRSDKWrapper::TelemetryVar & Local arr = Nan::New(var.header->count); for (int i = 0; i < var.header->count; ++i) { - arr->Set(i, convertTelemetryValueToObject(var, i)); + Nan::Set(arr, i, convertTelemetryValueToObject(var, i)); } return arr; } diff --git a/src/node-irsdk.js b/src/node-irsdk.js index 29002a4..1a69b9d 100644 --- a/src/node-irsdk.js +++ b/src/node-irsdk.js @@ -1,4 +1,4 @@ -var IrSdkNodeWrapper = require('../build/Release/IrSdkNodeBindings') +var IrSdkNodeWrapper = require('../build/Release/IrSdkNodeBindings.node') var JsIrSdk = require('./JsIrSdk') /**