From 5c64f270539f568a29c8e9df05bbb8637e55c6ac Mon Sep 17 00:00:00 2001 From: Bradley Mackey Date: Sun, 13 Sep 2026 17:00:34 +0400 Subject: [PATCH] Move snapshot test device to iPhone 18 Pro Max MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Updates the snapshot device guard, the README testing table, and both xcodebuild destinations in the workflow. The iOS version is unchanged — 27.0 was already the baseline. No reference images changed. Re-recording all 246 snapshots on the new device produced byte-identical output: `framedForTest` pins views to a fixed 390pt width and both devices render at @3x, so the rendered frame is 1170x3000 either way. The suite is effectively device-independent, and the guard constant serves as a consistency lock rather than something that shapes the output. Verified on Xcode 27.0 RC1: full suite green on iPhone 18 Pro Max / iOS 27.0, 2572 test executions across 22 bundle runs (13 bundles x Default and TSAN), 0 failures. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/validate-all.yml | 4 ++-- Vault/README.md | 2 +- .../SnapshotTesting/AssertSnapshotWithDeviceCheck.swift | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/validate-all.yml b/.github/workflows/validate-all.yml index 48bb34bb8..cb29fceca 100644 --- a/.github/workflows/validate-all.yml +++ b/.github/workflows/validate-all.yml @@ -104,7 +104,7 @@ jobs: -workspace Vault.xcworkspace \ -scheme CI_iOS \ -testPlan iOSAllTests \ - -destination 'platform=iOS Simulator,name=iPhone 17 Pro,OS=27.0' \ + -destination 'platform=iOS Simulator,name=iPhone 18 Pro Max,OS=27.0' \ -derivedDataPath "$RUNNER_TEMP/ci-ios-derived-data" \ -skipMacroValidation \ -skipPackagePluginValidation @@ -180,7 +180,7 @@ jobs: xcodebuild test-without-building \ -xctestrun "$XCTESTRUN" \ - -destination 'platform=iOS Simulator,name=iPhone 17 Pro,OS=27.0' \ + -destination 'platform=iOS Simulator,name=iPhone 18 Pro Max,OS=27.0' \ -only-testing:${{ matrix.only_testing }} \ -parallel-testing-enabled NO diff --git a/Vault/README.md b/Vault/README.md index 2c7290b33..3af4d0ed1 100644 --- a/Vault/README.md +++ b/Vault/README.md @@ -107,7 +107,7 @@ Designed to cause an internal error during key generation. - +
Simulator for snapshot testsiPhone 17 Pro on iOS 27.0iPhone 18 Pro Max on iOS 27.0
diff --git a/Vault/Sources/TestHelpers/SnapshotTesting/AssertSnapshotWithDeviceCheck.swift b/Vault/Sources/TestHelpers/SnapshotTesting/AssertSnapshotWithDeviceCheck.swift index 8eb642446..3eba297da 100644 --- a/Vault/Sources/TestHelpers/SnapshotTesting/AssertSnapshotWithDeviceCheck.swift +++ b/Vault/Sources/TestHelpers/SnapshotTesting/AssertSnapshotWithDeviceCheck.swift @@ -5,7 +5,7 @@ import UIKit /// Expected device configuration for snapshot tests. /// This must match the configuration specified in Vault/README.md. -private let expectedDeviceName = "iPhone 17 Pro" +private let expectedDeviceName = "iPhone 18 Pro Max" private let expectedIOSVersion = "27.0" private let expectedLocaleIdentifier = "en_US" private let expectedTimezoneIdentifier = ["UTC", "GMT"]