From 1ddfca9000f7019396fa2d827ca313c8e4fee648 Mon Sep 17 00:00:00 2001 From: Eric Murray Date: Tue, 20 Oct 2026 10:33:44 +0100 Subject: [PATCH 1/4] Fix typo PRIVATE_JWT_KEY to PRIVATE_KEY_JWT in scenarios --- ...createDeviceDataVolumeSubscription.feature | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature b/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature index 1b95f88..c2e0e99 100644 --- a/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature +++ b/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature @@ -191,24 +191,24 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData And the response body property "$.sinkCredential.credentialType", if present, is set to value "ACCESSTOKEN" And the response body property "$.sinkCredential.accessTokenExpiresUtc", if present, is set to the same value of the request property "$.sinkCredential.accessTokenExpiresUtc" - @device_data_volume_subscriptions_11_create_device_data_volume_subscription_sync_with_private_jwt_key_sink_credential_out_of_band_provisioning - Scenario: Create device data volume subscription (sync creation) with PRIVATE_JWT_KEY sinkCredential, out-of-band provisioning + @device_data_volume_subscriptions_11_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_out_of_band_provisioning + Scenario: Create device data volume subscription (sync creation) with PRIVATE_KEY_JWT sinkCredential, out-of-band provisioning # Some implementations may only support asynchronous subscription creation # Some implementations may only support out_of_band provisioning Given that subscriptions are created synchronously - And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_JWT_KEY" + And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_KEY_JWT" When the request "createDeviceDataVolumeSubscription" is sent Then the response code is 201 And the response header "Content-Type" is "application/json" And the response header "x-correlator" has the same value as the request header "x-correlator" And the response body complies with the OAS schema at "#/components/schemas/Subscription" - @device_data_volume_subscriptions_12_create_device_data_volume_subscription_sync_with_private_jwt_key_sink_credential_in_band_provisioning - Scenario: Create device data volume subscription (sync creation) with PRIVATE_JWT_KEY sinkCredential, in-band provisioning + @device_data_volume_subscriptions_12_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_in_band_provisioning + Scenario: Create device data volume subscription (sync creation) with PRIVATE_KEY_JWT sinkCredential, in-band provisioning # Some implementations may only support asynchronous subscription creation # Some implementations may additionally support in_band provisioning Given that subscriptions are created synchronously - And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_JWT_KEY" + And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_KEY_JWT" And the request property "$.sinkCredential.clientId" is set to a valid value And the request property "$.sinkCredential.tokenUri" is set to a valid value When the request "createDeviceDataVolumeSubscription" is sent @@ -216,7 +216,7 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData And the response header "Content-Type" is "application/json" And the response header "x-correlator" has the same value as the request header "x-correlator" And the response body complies with the OAS schema at "#/components/schemas/Subscription" - And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_JWT_KEY" + And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_KEY_JWT" And the response body property "$.sinkCredential.jwksUri" is set to a valid value ########################################################## @@ -464,10 +464,10 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData And the response property "$.code" is "MULTIEVENT_SUBSCRIPTION_NOT_SUPPORTED" And the response property "$.message" contains a user friendly text - @device_data_volume_subscriptions_422.02_creation_with_private_jwt_key_not_configured + @device_data_volume_subscriptions_422.02_creation_with_private_key_jwt_not_configured Scenario: Private JWT Key not configured for subscription creation - Given the API provider requires the use of a Private JWT key mechanism for subscription creation authentication - And the Private JWT key mechanism is not pre-configured in the environment + Given the API provider requires the use of a private key JWT mechanism for subscription creation authentication + And the private key JWT mechanism is not pre-configured in the environment And a valid subscription request body with the property "$.sinkCredential.credentialType" set to "PRIVATE_KEY_JWT" When the request "createDeviceDataVolumeSubscription" is sent Then the response code is 422 From e040aa3d6fbed16dcda600ee198f19163d1fad21 Mon Sep 17 00:00:00 2001 From: Eric Murray Date: Tue, 20 Oct 2026 10:35:11 +0100 Subject: [PATCH 2/4] Fix typo PRIVATE_JWT_KEY to PRIVATE_KEY_JWT in scenarios --- ...criptions-retrieveDeviceDataVolumeSubscription.feature | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscription.feature b/code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscription.feature index c215eaf..e8776a0 100644 --- a/code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscription.feature +++ b/code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscription.feature @@ -62,17 +62,17 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation retrieveDeviceDa And the response body property "$.sinkCredential.credentialType", if present, is set to value "ACCESSTOKEN" And the response body property "$.sinkCredential.accessTokenExpiresUtc", if present, is set to the same value of the request property "$.sinkCredential.accessTokenExpiresUtc" - @device_data_volume_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_jwt_key_sink_credential_returned + @device_data_volume_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_key_jwt_sink_credential_returned # Some implementations may decide to not return the sinkCredential in the response (data minimization principle) - # Mainly applicable for in-band provisioning of PRIVATE_JWT_KEY mode for a given subscription - Scenario: Get a subscription based on existing subscription-id, with PRIVATE_JWT_KEY sinkCredential returned. + # Mainly applicable for in-band provisioning of PRIVATE_KEY_JWT mode for a given subscription + Scenario: Get a subscription based on existing subscription-id, with PRIVATE_KEY_JWT sinkCredential returned. Given the path parameter "subscriptionId" is set to the identifier of an existing roaming status subscription When the request "retrieveDeviceDataVolumeSubscription" is sent Then the response code is 200 And the response header "Content-Type" is "application/json" And the response header "x-correlator" has the same value as the request header "x-correlator" And the response body complies with the OAS schema at "#/components/schemas/Subscription" - And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_JWT_KEY" + And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_KEY_JWT" And the response body property "$.sinkCredential.jwksUri" is set to a valid value ################## From 12caec912c02f49cba334b89a16a288aa8fa31a4 Mon Sep 17 00:00:00 2001 From: Eric Murray Date: Tue, 20 Oct 2026 14:25:03 +0100 Subject: [PATCH 3/4] Update scenario tag for device data volume subscription --- ...ume-subscriptions-createDeviceDataVolumeSubscription.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature b/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature index c2e0e99..407de37 100644 --- a/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature +++ b/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature @@ -203,7 +203,7 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData And the response header "x-correlator" has the same value as the request header "x-correlator" And the response body complies with the OAS schema at "#/components/schemas/Subscription" - @device_data_volume_subscriptions_12_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_in_band_provisioning + @device_data_volume_subscriptions_13_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_in_band_provisioning Scenario: Create device data volume subscription (sync creation) with PRIVATE_KEY_JWT sinkCredential, in-band provisioning # Some implementations may only support asynchronous subscription creation # Some implementations may additionally support in_band provisioning From 47d0f0d526990fe3286f3a78cdcab0471b7bb6ba Mon Sep 17 00:00:00 2001 From: Eric Murray Date: Tue, 20 Oct 2026 14:25:56 +0100 Subject: [PATCH 4/4] Apply suggestion from @eric-murray --- ...ume-subscriptions-createDeviceDataVolumeSubscription.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature b/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature index 407de37..b7a5ca9 100644 --- a/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature +++ b/code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature @@ -191,7 +191,7 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData And the response body property "$.sinkCredential.credentialType", if present, is set to value "ACCESSTOKEN" And the response body property "$.sinkCredential.accessTokenExpiresUtc", if present, is set to the same value of the request property "$.sinkCredential.accessTokenExpiresUtc" - @device_data_volume_subscriptions_11_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_out_of_band_provisioning + @device_data_volume_subscriptions_12_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_out_of_band_provisioning Scenario: Create device data volume subscription (sync creation) with PRIVATE_KEY_JWT sinkCredential, out-of-band provisioning # Some implementations may only support asynchronous subscription creation # Some implementations may only support out_of_band provisioning