Skip to content

CacheStore interface missing context  #41

Description

@xBlaz3kx

Looking at the persist.CacheStore interface, it doesn't have a ctx context.Context as a function argument, which a potential issue when implementing Redis cache.

Currently, context.TODO() is being passed to the Redis client, which might be causing issues, if a request is cancelled during cache querying.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions