Skip to content

log dependency should not set release_max_level_debug feature (affects crate downstream users) #98

Description

@zhaop

cros-codecs declares log = { version = "0", features = ["release_max_level_debug"] } in its Cargo.toml. Because Cargo features are additive and global, this forces the release_max_level_debug setting on all downstream users, and conflicts with any application that sets a different release_max_level_*, causing a compile error:

error: multiple release_max_level_* features set

The log crate docs recommend that only final binaries set these features, not libraries (like cros_codecs).

I suggest fixing this by removing features = ["release_max_level_debug"] from the log dependency and let consuming applications decide their own log level filtering, as per the log crate's recommendations.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions