From 5b4a3f7d9ac7791f714e3455248c1bd81895825a Mon Sep 17 00:00:00 2001
From: Gregor Maier <gregor@cloudflare.com>
Date: Mon, 26 Oct 2026 18:46:22 +0000
Subject: [PATCH] Remove 'testing' feature from "production"/default features

testing is a test-only feature, but it was included in some "production" feature combos.
---
 .github/workflows/ci.yml | 6 +++---
 AGENTS.md                | 6 +++---
 foundations/Cargo.toml   | 3 +--
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d0e5fe0f..2aa2c6ca 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -117,7 +117,7 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Run Clippy
         run: |
-          cargo clippy --all-targets -- \
+          cargo clippy --all-targets --features testing -- \
             -D warnings \
             -D unreachable_pub \
             -D clippy::await_holding_lock \
@@ -318,7 +318,7 @@ jobs:
       - name: Install cargo-nextest
         uses: taiki-e/install-action@cargo-nextest
       - name: Run foundations tests
-        run: _RJEM_MALLOC_CONF=prof:true cargo nextest run --target ${{ matrix.target }}
+        run: _RJEM_MALLOC_CONF=prof:true cargo nextest run --features testing --target ${{ matrix.target }}
         shell: bash
       - name: Run doc tests
-        run: _RJEM_MALLOC_CONF=prof:true cargo test --doc --target ${{ matrix.target }}
+        run: _RJEM_MALLOC_CONF=prof:true cargo test --doc --features testing --target ${{ matrix.target }}
diff --git a/AGENTS.md b/AGENTS.md
index f215266f..332549ab 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -2,9 +2,9 @@
 
 ## Build & Test Commands
 - Build: `cargo build`
-- Test all: `cargo nextest run`
-- Test single: `cargo nextest run <test_name>` or `cargo nextest run --test <file> <test_name>`
-- Clippy: `cargo clippy --all-targets -- -D warnings -D unreachable_pub -D clippy::await_holding_lock -D clippy::clone_on_ref_ptr`
+- Test all: `cargo nextest run --features testing`
+- Test single: `cargo nextest run --features testing <test_name>` or `cargo nextest run --features testing --test <file> <test_name>`
+- Clippy: `cargo clippy --all-targets --features testing -- -D warnings -D unreachable_pub -D clippy::await_holding_lock -D clippy::clone_on_ref_ptr`
 - Format: `cargo fmt --all`
 - Lint fix: `./scripts/lint-fix.sh`
 - Feature check: `cargo hack check --feature-powerset --no-dev-deps --depth 1`
diff --git a/foundations/Cargo.toml b/foundations/Cargo.toml
index 22e44d73..701f7f95 100644
--- a/foundations/Cargo.toml
+++ b/foundations/Cargo.toml
@@ -42,7 +42,6 @@ platform-common-default = [
     "jemalloc",
     "telemetry",
     "cli",
-    "testing",
     "settings_deny_unknown_fields_by_default",
     "panic_on_frozen_logger",
     "panic_on_too_much_logger_nesting",
@@ -55,7 +54,7 @@ sentry = ["dep:sentry-core", "dep:serde", "dep:governor", "ratelimit", "metrics"
 
 # A subset of features that can be used both on server and client sides. Useful for libraries
 # that can be used either way.
-server-client-common-default = ["settings", "client-telemetry", "testing"]
+server-client-common-default = ["settings", "client-telemetry"]
 
 # Enables serializable documented settings functionality.
 settings = [