From bf734db86b5e2bcdeec5385ef10af977780eb9c6 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker Date: Wed, 28 Oct 2026 12:50:22 -0700 Subject: [PATCH] Replace jsg::Number with f64 in jsg-test tests from #8045 #8045 added uses of jsg::Number in the resource_template and fast_api tests, which #8054 removed in favor of f64. --- src/rust/jsg-test/tests/fast_api.rs | 4 ++-- src/rust/jsg-test/tests/resource_template.rs | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/rust/jsg-test/tests/fast_api.rs b/src/rust/jsg-test/tests/fast_api.rs index ae337b4be0d..b9bdced28fe 100644 --- a/src/rust/jsg-test/tests/fast_api.rs +++ b/src/rust/jsg-test/tests/fast_api.rs @@ -117,13 +117,13 @@ fn function_lengths_follow_compat_flag_with_fast_api_enabled() { .unwrap(); assert_eq!(lengths, expected); let (result, fast_calls) = count_fast_calls(|| { - ctx.eval::( + ctx.eval::( lock, &optimized("a, b", "return r.add(a, b);", "1, 2", "3, 4"), ) .unwrap() }); - assert!((result.value() - 7.0).abs() < f64::EPSILON); + assert!((result - 7.0).abs() < f64::EPSILON); assert_ne!(fast_calls, Some(0)); Ok(()) }); diff --git a/src/rust/jsg-test/tests/resource_template.rs b/src/rust/jsg-test/tests/resource_template.rs index 296a909258a..d59d9fdbb86 100644 --- a/src/rust/jsg-test/tests/resource_template.rs +++ b/src/rust/jsg-test/tests/resource_template.rs @@ -19,7 +19,7 @@ use jsg_macros::jsg_static_constant; use crate::Harness; -type OptionalNumber = Option; +type OptionalNumber = Option; struct OptionalValue; @@ -56,18 +56,18 @@ impl Sample { } #[jsg_method] - fn two(&self, a: Number, b: Number, _c: OptionalNumber) -> Number { - Number::new(a.value() + b.value()) + fn two(&self, a: f64, b: f64, _c: OptionalNumber) -> f64 { + a + b } #[jsg_method] - fn with_lock(&self, _lock: &mut jsg::Lock, a: Number) -> Number { + fn with_lock(&self, _lock: &mut jsg::Lock, a: f64) -> f64 { a } #[jsg_method] - fn add(a: Number, b: Number) -> Number { - Number::new(a.value() + b.value()) + fn add(a: f64, b: f64) -> f64 { + a + b } #[jsg_method] @@ -75,7 +75,7 @@ impl Sample { &self, _value: jsg::v8::Local<'s, jsg::v8::Value>, _optional: OptionalValue, - _after: jsg::Lenient, + _after: jsg::Lenient, ) -> bool { true }