From 707193a2a5784666b5270ba9bb09f740ccf40e76 Mon Sep 17 00:00:00 2001 From: Edmund Hung Date: Tue, 30 Sep 2025 14:48:17 +0100 Subject: [PATCH 1/2] fix(wrangler): wrangler pages deployment list --json should skip the banner --- .changeset/bumpy-schools-sniff.md | 5 +++++ .../wrangler/src/__tests__/pages/deployment-list.test.ts | 6 +++++- packages/wrangler/src/pages/deployments.ts | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/bumpy-schools-sniff.md diff --git a/.changeset/bumpy-schools-sniff.md b/.changeset/bumpy-schools-sniff.md new file mode 100644 index 00000000000..4900171c866 --- /dev/null +++ b/.changeset/bumpy-schools-sniff.md @@ -0,0 +1,5 @@ +--- +"wrangler": patch +--- + +fix: skip banner when using `--json` flag in `wrangler pages deployment` commands diff --git a/packages/wrangler/src/__tests__/pages/deployment-list.test.ts b/packages/wrangler/src/__tests__/pages/deployment-list.test.ts index 772a81b2777..5691147c392 100644 --- a/packages/wrangler/src/__tests__/pages/deployment-list.test.ts +++ b/packages/wrangler/src/__tests__/pages/deployment-list.test.ts @@ -8,6 +8,7 @@ import { runWrangler } from "./../helpers/run-wrangler"; import type { Deployment } from "./../../pages/types"; describe("pages deployment list", () => { + vi.unmock("../../wrangler-banner"); runInTempDir(); mockAccountId(); mockApiToken(); @@ -47,7 +48,10 @@ describe("pages deployment list", () => { expect(requests.count).toBe(1); expect(std.out).toMatchInlineSnapshot(` - "┌─┬─┬─┬─┬─┬─┬─┐ + " + ⛅️ wrangler x.x.x + ────────────────── + ┌─┬─┬─┬─┬─┬─┬─┐ │ Id │ Environment │ Branch │ Source │ Deployment │ Status │ Build │ ├─┼─┼─┼─┼─┼─┼─┤ │ 87bbc8fe-16be-45cd-81e0-63d722e82cdf │ Preview │ main │ c764936 │ https://87bbc8fe.images.pages.dev │ 3 years ago │ https://dash.cloudflare.com/some-account-id/pages/view/images/87bbc8fe-16be-45cd-81e0-63d722e82cdf │ diff --git a/packages/wrangler/src/pages/deployments.ts b/packages/wrangler/src/pages/deployments.ts index e5419c56278..e02e8666b28 100644 --- a/packages/wrangler/src/pages/deployments.ts +++ b/packages/wrangler/src/pages/deployments.ts @@ -21,6 +21,7 @@ export const pagesDeploymentListCommand = createCommand({ }, behaviour: { provideConfig: false, + printBanner: (args) => !args.json, }, args: { "project-name": { From f2dd2be479501c9bc00eecbc7c36dc9477ec48ab Mon Sep 17 00:00:00 2001 From: Edmund Hung Date: Tue, 30 Sep 2025 14:50:45 +0100 Subject: [PATCH 2/2] refactor(wrangler): align printBanner setup on wrangler deployment commands --- packages/wrangler/src/versions/deployments/list.ts | 2 +- packages/wrangler/src/versions/deployments/status.ts | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/wrangler/src/versions/deployments/list.ts b/packages/wrangler/src/versions/deployments/list.ts index 7229256a6f2..0c58521276d 100644 --- a/packages/wrangler/src/versions/deployments/list.ts +++ b/packages/wrangler/src/versions/deployments/list.ts @@ -31,7 +31,7 @@ export const deploymentsListCommand = createCommand({ }, }, behaviour: { - printBanner: false, + printBanner: (args) => !args.json, }, handler: async function versionsDeploymentsListHandler(args, { config }) { metrics.sendMetricsEvent( diff --git a/packages/wrangler/src/versions/deployments/status.ts b/packages/wrangler/src/versions/deployments/status.ts index e2f2224a8d6..52150ec5f24 100644 --- a/packages/wrangler/src/versions/deployments/status.ts +++ b/packages/wrangler/src/versions/deployments/status.ts @@ -6,7 +6,6 @@ import { UserError } from "../../errors"; import * as metrics from "../../metrics"; import { requireAuth } from "../../user"; import formatLabelledValues from "../../utils/render-labelled-values"; -import { printWranglerBanner } from "../../wrangler-banner"; import { fetchLatestDeployment, fetchVersions } from "../api"; import { getDeploymentSource } from "./list"; import type { VersionCache } from "../types"; @@ -32,13 +31,9 @@ export const deploymentsStatusCommand = createCommand({ }, }, behaviour: { - printBanner: false, + printBanner: (args) => !args.json, }, handler: async function versionsDeploymentsStatusHandler(args, { config }) { - if (!args.json) { - await printWranglerBanner(); - } - metrics.sendMetricsEvent( "view latest versioned deployment", {},