Request body limit

[bpolaszek]

Hello there! 👋

We've been using Freddie in production on an IoT platform for about 2 weeks now and it performs really great! 👍

We just encountered a few errors so far, where Freddie would unexpectely respond a 400 error when it doesn't see any topic into the request body, even though that one is properly provided.

After further investigation it looks like when the payload is a little bigger than usual (which can happen sometimes), $request->getBody() returns a sort of empty stream, resulting in a payload parsing error. So I went to Framework X's documentation and I noticed this into the Upload section:

Note that HTTP requests are currently limited to 64 KiB. Any uploads above this size will currently show up as an empty request body with no file uploads whatsoever.

I honestly didn't see that coming. Is it a limit I could raise myself, or are we stuck forever to tiny payloads?

Thanks!
Ben

[SimonFrings]

Hey @bpolaszek , thanks for bringing this up 👍

This question has been mentioned a few times by now, you can take a closer look at #69 and reactphp/http#412, you may find a quick answer there.

Does this help for the start?

[bpolaszek]

Hey @SimonFrings,

Thanks for your quick reply.

Unfortunately it doesn't help, as raising the limit looks possible when using raw reactphp/http, but not with Framework X, which doesn't give us access to how React\Http\Server is instantiated 😞

[SimonFrings]

Yeah, I know the 64 KiB get in your way sometimes, we have plans to adapt a certain behavior to Framework X that handles this for you, without any bigger (or any) adjustments on your side. I'm not sure when this feature will find its way into the project as we're currently involved in developing the ReactPHP v3 with some major new features.

If you need some adjustments sooner, you can reach out to me or @clue and we can find a way to give this some more priority, maybe through a consulting session if that's an option for you.

For a short answer you can also take https://github.com/cweagans/composer-patches or similar projects and change the 64 KiB manually for now.

[bpolaszek]

No worries, after discussion with my team, there's actually no emergency into fixing this, as most Freddie's biggest payloads are produced by some deprecated feature on our side.
I'm mostly concerned about maintaining an open source project which relies on Framework X, for which I can't ask users to use a composer patch, but at least, I'll leave a note in the README until some solution comes up.
Thanks!
Ben

[clue]

@bpolaszek Just merged #311 which adds experimental support for raising the request body limit of the built-in web server, see https://framework-x.org/docs/best-practices/deployment/#request-body-limit. This will be part of the upcoming v0.18.0 release 👍