From b9b2482e7499f6525f3566ae7190ab4643ee3921 Mon Sep 17 00:00:00 2001 From: Juraj Martinka Date: Tue, 7 Oct 2025 06:16:19 +0200 Subject: [PATCH 1/4] Activate the workflow. --- .github/workflows/coverage-prs-all-components.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/coverage-prs-all-components.yml b/.github/workflows/coverage-prs-all-components.yml index cbc9ff2..76efe65 100644 --- a/.github/workflows/coverage-prs-all-components.yml +++ b/.github/workflows/coverage-prs-all-components.yml @@ -6,13 +6,13 @@ name: Coverage PRs - ALL components on: # NOTE: don't activate this by default because it could conflict with the other job ('only changed components') - # pull_request: - # branches: - # - master - # paths: - # - 'calculator-1/src/**' - # - 'calculator-2/src/**' - # - 'calculator-3/src/**' + pull_request: + branches: + - master + paths: + - 'calculator-1/src/**' + - 'calculator-2/src/**' + - 'calculator-3/src/**' jobs: From 550c99faa50fbac655c7aef91eae412f8f1dd02d Mon Sep 17 00:00:00 2001 From: Juraj Martinka Date: Tue, 7 Oct 2025 06:16:30 +0200 Subject: [PATCH 2/4] add uncovered square function. --- .../src/main/java/com/codescene/calculator1/Calculator.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java b/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java index 0ff2fbe..40f6e5c 100644 --- a/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java +++ b/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java @@ -37,4 +37,7 @@ private double subtract(double firstOperand, double secondOperand) { private double add(double firstOperand, double secondOperand) { return firstOperand + secondOperand; } + private double square(double x) { + return x * x; + } } From 9bf39967cbf1a504a7a360a8a4d4cc85014b5d7f Mon Sep 17 00:00:00 2001 From: Juraj Martinka Date: Tue, 7 Oct 2025 06:22:55 +0200 Subject: [PATCH 3/4] Disable standard PR workflow for this branch. --- .../coverage-prs-only-changed-components.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/coverage-prs-only-changed-components.yml b/.github/workflows/coverage-prs-only-changed-components.yml index 7d558d4..f5bca30 100644 --- a/.github/workflows/coverage-prs-only-changed-components.yml +++ b/.github/workflows/coverage-prs-only-changed-components.yml @@ -1,13 +1,14 @@ name: Coverage PRs - only changed components on: - pull_request: - branches: - - master - paths: - - 'calculator-1/src/**' - - 'calculator-2/src/**' - - 'calculator-3/src/**' + # NOTE: disabled only in this branch/PR to be able to exercise the "ALL components" workflow. + # pull_request: + # branches: + # - master + # paths: + # - 'calculator-1/src/**' + # - 'calculator-2/src/**' + # - 'calculator-3/src/**' jobs: From f4ae15ced4c9cb643fd67a880f5b6a8655f90d6e Mon Sep 17 00:00:00 2001 From: Juraj Martinka Date: Tue, 7 Oct 2025 06:37:23 +0200 Subject: [PATCH 4/4] Cover the square method. --- .../main/java/com/codescene/calculator1/Calculator.java | 3 +++ .../java/com/codescene/calculator1/CalculatorTest.java | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java b/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java index 40f6e5c..35f2ce3 100644 --- a/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java +++ b/calculator-1/src/main/java/com/codescene/calculator1/Calculator.java @@ -15,6 +15,9 @@ public double calculate(double firstOperand, double secondOperand, char operator case ':':{ return divide(firstOperand,secondOperand); } + case '^':{ + return square(firstOperand); + } default: throw new IllegalArgumentException("Unsupported operation :"+operator); } diff --git a/calculator-1/src/test/java/com/codescene/calculator1/CalculatorTest.java b/calculator-1/src/test/java/com/codescene/calculator1/CalculatorTest.java index 66c413a..258ab32 100644 --- a/calculator-1/src/test/java/com/codescene/calculator1/CalculatorTest.java +++ b/calculator-1/src/test/java/com/codescene/calculator1/CalculatorTest.java @@ -30,4 +30,11 @@ void divideSimple(){ double result = calculator.calculate(1,1,':'); Assertions.assertEquals(1,result); } + + @Test + void squareSimple(){ + // the signature isn't flexible so we repeat the same number twice + double result = calculator.calculate(10, 10, '^'); + Assertions.assertEquals(100.0,result); + } }