From 79d971b4fc0c8569c5269d3873f344344c1290f9 Mon Sep 17 00:00:00 2001 From: Amp Date: Wed, 4 Nov 2026 11:16:25 +0000 Subject: [PATCH 01/12] feat: add transformNode render hook to every renderer Renderers accept a transformNode function or array that can return a new tag and/or props for each element node at render time. It runs after binding resolution and before component lookup, so a new tag resolves through components and componentsManifest. Values a transform adds or changes go through the same prop validation as authored props. Amp-Thread-ID: https://ampcode.com/threads/T-01a1a61f-eed5-73e9-a2e4-f85f11002fdb Co-authored-by: Ahad Birang --- AGENTS.md | 17 ++- docs/content/5.reference/3.reference.md | 59 +++++++++ .../components/markdown-document.component.ts | 6 +- .../src/components/markdown-node.component.ts | 119 ++++++++++-------- .../src/components/markdown.component.ts | 6 +- packages/comark-angular/src/define.ts | 25 +++- .../test/transform-node.test.ts | 62 +++++++++ .../comark-react/src/components/Markdown.tsx | 8 +- .../src/components/MarkdownDocument.tsx | 55 +++++--- packages/comark-react/src/index.ts | 10 +- .../comark-react/test/transform-node.test.tsx | 49 ++++++++ .../src/async/MarkdownAsync.svelte | 5 +- .../src/components/ComarkComponent.svelte | 6 +- .../src/components/Markdown.svelte | 6 +- .../src/components/MarkdownDocument.svelte | 5 +- .../src/components/MarkdownNode.svelte | 35 ++++-- packages/comark-svelte/src/types.ts | 8 +- .../comark-svelte/test/transform-node.test.ts | 29 +++++ .../comark-vue/src/components/Markdown.ts | 17 ++- .../src/components/MarkdownDocument.ts | 55 ++++++-- packages/comark-vue/src/index.ts | 19 ++- .../comark-vue/test/transform-node.test.ts | 67 ++++++++++ .../comark/src/internal/stringify/state.ts | 23 +++- .../src/internal/stringify/transform-node.ts | 87 +++++++++++++ packages/comark/src/render/index.ts | 12 +- packages/comark/src/types.ts | 48 +++++++ packages/comark/src/utils/index.ts | 1 + packages/comark/test/transform-node.test.ts | 119 ++++++++++++++++++ test/bundle.test.ts | 10 +- 29 files changed, 847 insertions(+), 121 deletions(-) create mode 100644 packages/comark-angular/test/transform-node.test.ts create mode 100644 packages/comark-react/test/transform-node.test.tsx create mode 100644 packages/comark-svelte/test/transform-node.test.ts create mode 100644 packages/comark-vue/test/transform-node.test.ts create mode 100644 packages/comark/src/internal/stringify/transform-node.ts create mode 100644 packages/comark/test/transform-node.test.ts diff --git a/AGENTS.md b/AGENTS.md index f188c1871..b62e3c26a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -107,7 +107,7 @@ packages/comark/ │ │ ├── indent.ts # Dedent of outdented component children │ │ ├── unwrap.ts # `unwrap` option │ │ └── auto-unwrap.ts # `autoUnwrap` option -│ └── stringify/ # AST → markdown string rendering (handlers/ per tag) +│ └── stringify/ # AST → markdown string rendering (handlers/ per tag; transform-node.ts runs `transformNode`) ├── SPEC/ # Behavioral spec fixtures (CommonMark, GFM, HTML, COMARK, auto-close.md) ├── test/ # Vitest test files ├── package.json @@ -498,7 +498,10 @@ import { HTML_VOID_ELEMENTS, isMarkdownDocument, sanitizeData, + applyNodeTransforms, // runs a renderer's `transformNode` for one node (used by every renderer) + mergeNodeTransforms, // merges two `transformNode` values into one stable list } from 'comark/utils' +import type { NodeTransform, NodeTransformContext, NodeTransformResult } from 'comark' import { noopTracer, withSpan } from 'comark/utils/trace' // Core plugins — use when calling parseMarkdown() directly (framework-agnostic) @@ -774,6 +777,18 @@ the open tag. `