* to activate the hourly trigger.
*/
function buildSetupSource(triggerFn) {
- if (!/^[a-zA-Z_][a-zA-Z0-9_]*$/.test(triggerFn)) {
+ if (!/^[a-zA-Z_]\w*$/.test(triggerFn)) {
throw new Error(
'Invalid trigger function name: ' + JSON.stringify(triggerFn)
)
@@ -1189,14 +1188,11 @@
3Configure your scripts
'' +
'
diff --git a/gas-installer/src/index.js b/gas-installer/src/index.js
index b3bfa6e7..cb73276c 100644
--- a/gas-installer/src/index.js
+++ b/gas-installer/src/index.js
@@ -21,8 +21,8 @@ const APPS_SCRIPT_API_BASE = 'https://script.googleapis.com/v1'
*/
function getFileType(filename) {
if (!filename || typeof filename !== 'string') return null
- if (/\.gs$/.test(filename)) return 'SERVER_JS'
- if (/\.html$/.test(filename)) return 'HTML'
+ if (filename.endsWith('.gs')) return 'SERVER_JS'
+ if (filename.endsWith('.html')) return 'HTML'
return null
}
@@ -42,8 +42,7 @@ function filterGithubItems(items) {
return items
.filter(
(item) =>
- item &&
- item.type === 'file' &&
+ item?.type === 'file' &&
typeof item.name === 'string' &&
item.download_url
)
diff --git a/scripts/check-coverage.js b/scripts/check-coverage.js
index 87025646..f7e701b5 100644
--- a/scripts/check-coverage.js
+++ b/scripts/check-coverage.js
@@ -7,8 +7,8 @@
* its minimum threshold, or 0 if all pass.
*/
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
const coveragePath = path.join(process.cwd(), 'coverage', 'coverage-final.json')
@@ -44,9 +44,9 @@ for (const filePath in coverage) {
if (fileCoverage.b) {
for (const key in fileCoverage.b) {
const branches = fileCoverage.b[key]
- for (let i = 0; i < branches.length; i++) {
+ for (const hitCount of branches) {
totals.branches.total++
- if (branches[i] > 0) totals.branches.covered++
+ if (hitCount > 0) totals.branches.covered++
}
}
}
diff --git a/src/calendar-to-briefing-doc/src/index.js b/src/calendar-to-briefing-doc/src/index.js
index 216dd1b3..fb9c8a9c 100644
--- a/src/calendar-to-briefing-doc/src/index.js
+++ b/src/calendar-to-briefing-doc/src/index.js
@@ -95,7 +95,7 @@ function detectConflicts(eventTuples) {
* @returns {string}
*/
function formatConflictWarning(conflicts, formatTime) {
- if (!conflicts || !conflicts.length) return ''
+ if (!conflicts?.length) return ''
return conflicts
.map((c) => {
const aLabel = c.a.calendarName
@@ -122,7 +122,7 @@ function formatConflictWarning(conflicts, formatTime) {
function groupEventsByDay(events, getDateKey) {
const map = new Map()
for (const item of events) {
- const evt = item && item.event ? item.event : item
+ const evt = item?.event ? item.event : item
const key = getDateKey(evt.getStartTime())
if (!map.has(key)) map.set(key, [])
map.get(key).push(item)
@@ -213,7 +213,7 @@ function formatBriefing(title, groupedEvents, formatTime) {
sections.push(dayLabel)
// Detect if items are tuples or plain events
- const isTuple = items.length > 0 && items[0] && items[0].event
+ const isTuple = items.length > 0 && items[0]?.event
const tuples = isTuple
? items
: items.map((e) => ({ event: e, calendarName: null }))
@@ -249,7 +249,7 @@ function formatBriefing(title, groupedEvents, formatTime) {
* @param {string} body - The full briefing text
*/
function emailBriefing(gmailApp, recipients, subject, body) {
- if (!recipients || !recipients.length) return
+ if (!recipients?.length) return
for (const recipient of recipients) {
gmailApp.sendEmail(recipient, subject, body)
}
@@ -312,7 +312,7 @@ function generateBriefingForConfig(
getDateKey,
formatTime
) {
- if (!config.emailRecipients || !config.emailRecipients.length) {
+ if (!config.emailRecipients?.length) {
throw new Error('emailRecipients is required')
}
diff --git a/src/calendar-to-briefing-doc/tests/index.test.js b/src/calendar-to-briefing-doc/tests/index.test.js
index 50dcc0cc..81e8f48e 100644
--- a/src/calendar-to-briefing-doc/tests/index.test.js
+++ b/src/calendar-to-briefing-doc/tests/index.test.js
@@ -408,37 +408,22 @@ describe('emailBriefing', () => {
// ── shouldRunNow ─────────────────────────────────────────────────────────────
describe('shouldRunNow', () => {
- it('returns true on the configured weekly day and hour', () => {
+ it.each([
+ [
+ 'configured weekly day and hour (Monday 7 AM)',
+ '2025-01-13T07:00:00',
+ true,
+ ],
+ ['wrong day (Tuesday 7 AM)', '2025-01-14T07:00:00', false],
+ ['wrong hour (Monday 8 AM)', '2025-01-13T08:00:00', false],
+ ])('returns %s -> %s', (_desc, nowIso, expected) => {
const config = {
scheduleFrequency: 'weekly',
scheduleDay: 'MONDAY',
scheduleHour: 7,
}
- // Monday at 7 AM
- const now = new Date('2025-01-13T07:00:00')
- expect(shouldRunNow(config, now, null)).toBe(true)
- })
-
- it('returns false on wrong day', () => {
- const config = {
- scheduleFrequency: 'weekly',
- scheduleDay: 'MONDAY',
- scheduleHour: 7,
- }
- // Tuesday at 7 AM
- const now = new Date('2025-01-14T07:00:00')
- expect(shouldRunNow(config, now, null)).toBe(false)
- })
-
- it('returns false on wrong hour', () => {
- const config = {
- scheduleFrequency: 'weekly',
- scheduleDay: 'MONDAY',
- scheduleHour: 7,
- }
- // Monday at 8 AM
- const now = new Date('2025-01-13T08:00:00')
- expect(shouldRunNow(config, now, null)).toBe(false)
+ const now = new Date(nowIso)
+ expect(shouldRunNow(config, now, null)).toBe(expected)
})
it('defaults to weekly Monday 7 AM when schedule fields are missing', () => {
diff --git a/src/calendar-to-sheets/src/index.js b/src/calendar-to-sheets/src/index.js
index 1eb60e56..b5f5933b 100644
--- a/src/calendar-to-sheets/src/index.js
+++ b/src/calendar-to-sheets/src/index.js
@@ -32,7 +32,7 @@ function rowsToMap(rows) {
const m = new Map()
for (let i = 0; i < rows.length; i++) {
const r = rows[i]
- if (!r || !r[0]) continue
+ if (!r?.[0]) continue
m.set(r[0], { rowIndex: i + 2, values: r }) // assume header at row 1
}
return m
@@ -51,7 +51,8 @@ function rowsEqual(a, b) {
// Handle Date comparison (a is ISO string, b is Date object from sheet)
if (typeof valA === 'string' && valB instanceof Date) {
const dateA = new Date(valA)
- if (!isNaN(dateA) && dateA.getTime() === valB.getTime()) continue
+ if (!Number.isNaN(dateA.getTime()) && dateA.getTime() === valB.getTime())
+ continue
}
// Handle sanitized formula comparison (a has leading ', b does not)
@@ -190,7 +191,7 @@ async function syncCalendarToSheet(
const rowStartTime = new Date(rowStart)
// Only delete if row's event time falls within our sync window
if (
- !isNaN(rowStartTime) &&
+ !Number.isNaN(rowStartTime.getTime()) &&
rowStartTime >= start &&
rowStartTime <= end
) {
@@ -213,7 +214,7 @@ async function syncCalendarToSheet(
}
// delete from bottom to top
console.log('[syncCalendarToSheet] Deleting rows:', toDelete.length)
- toDelete.sort((a, b) => b - a).forEach((r) => sheet.deleteRow(r))
+ toDelete.toSorted((a, b) => b - a).forEach((r) => sheet.deleteRow(r))
console.log('[syncCalendarToSheet] Sync complete')
}
diff --git a/src/deploy/index.js b/src/deploy/index.js
index 579276b9..32caccfc 100644
--- a/src/deploy/index.js
+++ b/src/deploy/index.js
@@ -100,7 +100,7 @@ function buildProjectContent(files) {
throw new Error('Each file must have a non-empty string name')
}
if (typeof f.source !== 'string') {
- throw new Error('Each file must have a string source')
+ throw new TypeError('Each file must have a string source')
}
}
return {
diff --git a/src/gas-utils.js b/src/gas-utils.js
index 7ed21247..82798428 100644
--- a/src/gas-utils.js
+++ b/src/gas-utils.js
@@ -1,4 +1,4 @@
-const crypto = require('crypto')
+const crypto = require('node:crypto')
/**
* getCleanBody - logic ported from GAS for local testing
@@ -7,10 +7,10 @@ function getCleanBody(text) {
if (!text) return ''
const headerPatterns = [
- /^\s*On\s+.+\s+wrote:/m,
- /^\s*From:\s+.+\s+Sent:\s+/m,
+ /^\s*On\s.+\swrote:/m,
+ /^\s*From:\s.+\sSent:\s+/m,
/^\s*_{10,}/m,
- /^\s*From:\s+.+<.+@.+>/m,
+ /^\s*From:\s[^<]+<[^@]+@[^>]+>/m,
/confidentiality notice/im,
]
@@ -19,10 +19,8 @@ function getCleanBody(text) {
const match = text.match(pattern)
if (match) {
// Prefer splitting at the start of the line containing the match
- const lineStart =
- text.lastIndexOf('\n', match.index) === -1
- ? 0
- : text.lastIndexOf('\n', match.index) + 1
+ const nlIndex = text.lastIndexOf('\n', match.index)
+ const lineStart = nlIndex === -1 ? 0 : nlIndex + 1
if (splitIndex === -1 || lineStart < splitIndex) {
splitIndex = lineStart
}
@@ -53,7 +51,7 @@ function getFileHash(blob) {
bytes = blob
} else if (blob && typeof blob.getBytes === 'function') {
bytes = Buffer.from(blob.getBytes())
- } else if (blob && blob.bytes) {
+ } else if (blob?.bytes) {
bytes = Buffer.from(blob.bytes)
} else {
throw new Error('Unsupported blob type')
diff --git a/src/gmail-to-drive-by-labels/src/index.js b/src/gmail-to-drive-by-labels/src/index.js
index 37524d15..e06bf7c4 100644
--- a/src/gmail-to-drive-by-labels/src/index.js
+++ b/src/gmail-to-drive-by-labels/src/index.js
@@ -97,7 +97,7 @@ function processMessageToDoc(message, body, folder, options = {}) {
let currentIndex = 0
// Insert subject
- const subjectText = 'Subject: ' + (subject ? subject : '(No Subject)')
+ const subjectText = 'Subject: ' + (subject || '(No Subject)')
const headingPara = body.insertParagraph(currentIndex++, subjectText)
// Try to set heading style (GAS only)
@@ -201,12 +201,12 @@ function processMessageToDoc(message, body, folder, options = {}) {
Session.getScriptTimeZone(),
'_HHmmss'
)
- const newName = fileName.replace(/(\.[\w\d_-]+)$/i, timeTag + '$1')
+ const newName = fileName.replace(/(\.[\w-]+)$/i, timeTag + '$1')
fileName = newName === fileName ? fileName + timeTag : newName
} else {
// Test environment - simple timestamp
const timeTag = '_' + Date.now()
- const newName = fileName.replace(/(\.[\w\d_-]+)$/i, timeTag + '$1')
+ const newName = fileName.replace(/(\.[\w-]+)$/i, timeTag + '$1')
fileName = newName === fileName ? fileName + timeTag : newName
}
@@ -491,7 +491,7 @@ function processLabelGroup(config, services, helperFns) {
// This ensures the most recent emails appear first.
let currentIndex = 0
- const subjectText = 'Subject: ' + (subject ? subject : '(No Subject)')
+ const subjectText = 'Subject: ' + (subject || '(No Subject)')
const headingPara = body.insertParagraph(currentIndex++, subjectText)
// Try to set heading, fallback to bold if Doc is busy
@@ -590,7 +590,7 @@ function processLabelGroup(config, services, helperFns) {
'_HHmmss'
)
// Insert timestamp before the file extension
- let newName = fileName.replace(/(\.[\w\d_-]+)$/i, timeTag + '$1')
+ let newName = fileName.replace(/(\.[\w-]+)$/i, timeTag + '$1')
// Fallback if regex fails (files without extension)
if (newName === fileName) newName += timeTag
@@ -691,7 +691,7 @@ function rebuildDoc(config, services) {
const { GmailApp, DocumentApp, PropertiesService } = services
const MAX_EXECUTION_TIME = 4 * 60 * 1000 // 4 minutes (leaving 2 min buffer for 6 min limit)
const BATCH_SIZE = config.batchSize || 250 // Process threads in batches (default: 250)
- const startTime = new Date().getTime()
+ const startTime = Date.now()
console.log('[rebuildDoc] Starting rebuild for:', config.triggerLabel)
@@ -761,7 +761,7 @@ function rebuildDoc(config, services) {
let batchCount = 0
while (batchCount < BATCH_SIZE && threads.length > 0) {
// Check if we're running out of time
- const elapsed = new Date().getTime() - startTime
+ const elapsed = Date.now() - startTime
if (elapsed > MAX_EXECUTION_TIME) {
console.log('[rebuildDoc] Approaching time limit, saving progress')
state.processedCount += batchCount
diff --git a/src/gmail-to-drive-by-labels/tests/code.test.js b/src/gmail-to-drive-by-labels/tests/code.test.js
index 3282d3d4..f47039c4 100644
--- a/src/gmail-to-drive-by-labels/tests/code.test.js
+++ b/src/gmail-to-drive-by-labels/tests/code.test.js
@@ -168,13 +168,19 @@ describe('storeEmailsAndAttachments', () => {
// Mock Date to simulate timeout
const originalDate = Date
let callCount = 0
+ const simulatedTime = () => {
+ callCount++
+ if (callCount > 50) {
+ return 5 * 60 * 1000 // 5 minutes - exceeds threshold
+ }
+ return 0
+ }
global.Date = class extends originalDate {
getTime() {
- callCount++
- if (callCount > 50) {
- return 5 * 60 * 1000 // 5 minutes - exceeds threshold
- }
- return 0
+ return simulatedTime()
+ }
+ static now() {
+ return simulatedTime()
}
}
diff --git a/src/gmail-to-drive-by-labels/tests/gas-utils.test.js b/src/gmail-to-drive-by-labels/tests/gas-utils.test.js
index 23245f57..8d893566 100644
--- a/src/gmail-to-drive-by-labels/tests/gas-utils.test.js
+++ b/src/gmail-to-drive-by-labels/tests/gas-utils.test.js
@@ -17,6 +17,17 @@ describe('getCleanBody', () => {
expect(getCleanBody(input)).toBe('Line1')
})
+ test('cuts off at Outlook-style From:/Sent: reply header', () => {
+ const input =
+ 'My reply\nFrom: Jane Doe\nSent: Monday, Jan 1, 2020 9:00 AM\nQuoted'
+ expect(getCleanBody(input)).toBe('My reply')
+ })
+
+ test('cuts off at From: line with angle-bracket email address', () => {
+ const input = 'My reply\nFrom: Jane Doe