Skip to content

Support pr N and other deno upgrade-supported specs in deno-version #135

Description

@steve02081504

Summary

denoland/setup-deno's deno-version input only accepts release channels (latest, lts, rc, canary), semver ranges, or commit hashes. It does not accept the same specs the deno upgrade CLI supports, most notably pr N (install a specific GitHub PR build).

Motivation

deno upgrade gained a pr positional (and --pr flag) that installs the CI build of a specific denoland/deno pull request, e.g.:

deno upgrade pr 36606

This is very useful for validating an unmerged deno fix in your own CI (here: fount, which runs fount test / server / shell verification). Without setup-deno support, workflows must work around it by installing canary and then running deno upgrade pr N as a separate step — the pin then can't be applied at install time.

Request

Make deno-version accept the full set of specs that deno upgrade understands, or add a dedicated input (e.g. deno-upgrade / deno-pr) for these. Concretely, support values like:

  • pr 36606 (PR build)
  • any other spec deno upgrade accepts

so that:

- uses: denoland/setup-deno@v2
  with:
    deno-version: pr 36606

works and installs the PR build directly.

Additional context

  • deno upgrade usage: deno upgrade [OPTIONS] <VERSION-OR-HASH-OR-CHANNEL> [PR-NUMBER-POSITIONAL], plus --pr <VALUE>

Thanks for considering it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions