Skip to content

Adjust the NoScalingScaler to fit the it_opt algorithm. #364

Description

@smallfishabc

_GradEnablingScaler differs from NoScalingScaler by one line: requires_gradients = True

From review on #313: _GradEnablingScaler [latent_optimization.py:81] duplicates NoScalingScaler except for one line, requires_gradients = True. Marcus asked to drop it and use NoScalingScaler instead (comment).

That doesn't work as-is. The sampler reads requires_gradients off the step scaler to decide whether to run the denoiser under autograd [edm.py:400]. NoScalingScaler doesn't set it, so denoised comes back detached and IT-opt has no gradient path to the s/z latents.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions