Skip to content

Commit 3f916ff

Browse files
committed
FEATURE-ci-darwin-test-contracts: Mark task complete
1 parent bcd8f61 commit 3f916ff

2 files changed

Lines changed: 20 additions & 2 deletions

File tree

‎specs/tasks/FEATURE-ci-darwin-test-contracts.md‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# FEATURE-ci-darwin-test-contracts
22

3-
Status: In Progress (implementation ready; caller validation/finalization pending)
3+
Status: Complete (local implementation/validation/finalization; native CI pending)
44
Base: local v3 `a5a72356741300e5da16b94090f0f26a67a2d1f7`
55

66
Repair four native-reproduced test/setup assumptions without changing production
@@ -11,7 +11,7 @@ runtime, quota accounting, APIs, peer addresses or unrelated workflows.
1111
- [x] Size the shared response fixture budget from actual reserved string capacity.
1212
- [x] Prepare and clean up only the Darwin selected-archive proof's owned loopback alias; execute lifecycle regressions.
1313
- [x] Run focused local checks and record native verification limits.
14-
- [ ] Caller validation and finalization.
14+
- [x] Caller validation and finalization.
1515

1616
Evidence: primary `.debug/ci-darwin-test-contracts-8m2spsq4/journal.md`.
1717
Native RED batch 40055653509 is closed. Diagnostic refs f6475daf/88cd82fd
@@ -34,3 +34,10 @@ in the journal; neither is reported as a passing run. Two Automake wrappers were
3434
interrupted during unrelated prerequisite compilation before tests; verification
3535
then executed only the three requested binaries. No production owner expansion,
3636
full baseline suite, native rerun, CI control or publication occurred.
37+
38+
Groundwork validation `b98a1e2fed06734a1161df488d03ed79` sealed PASS for
39+
implementation `bcd8f6143e84902bc612c0790392b03190908b0c`: one iteration,
40+
nine independent approvals, zero fixes and one unworked finding persisted by
41+
the helper. The report is preserved without caller reading it. Native post-fix
42+
platform execution remains incomplete and CI/v3 PR owned; overall CI remains
43+
unsuccessful. Header/outbox causes remain uncertain and CLOSED.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Unworked Review Issues
2+
3+
**Run:** 2026-10-23 20:34:22
4+
**Task:** manual-validation
5+
**Total:** 1 (0 critical, 0 major, 1 minor)
6+
7+
## Minor
8+
9+
1. [ ] **security-reviewer** | `.github/workflows/v3-release-acceptance.yml:142` | resource-cleanup
10+
A trapped signal after successful alias creation but before peer_alias_owned=true leaves the newly created privileged alias behind (CWE-459). Bash processes the pending trap before the ownership assignment, so EXIT cleanup sees false. One bounded controlled-boundary check using the actual workflow and existing fixture, with os.kill(os.getppid(), 15) immediately after the fake ifconfig state.touch(), returned 143 with only query/create calls and alias_remains=True. This misses the accepted interrupted-command cleanup contract; impact is limited to loopback state on the ephemeral runner.
11+
*Recommendation:* Defer exiting on HUP/INT/TERM during creation until the creation result and ownership have been recorded, then honor the pending signal through cleanup. Add a lifecycle case that signals immediately after creation and verifies removal while retaining preexisting-alias preservation.

0 commit comments

Comments
 (0)