From ecacecdc3cf74d649e0bb032eb124c114c2c5308 Mon Sep 17 00:00:00 2001
From: shiva <shiva@gosysinfo.tech>
Date: Mon, 10 Aug 2026 14:26:31 +0530
Subject: [PATCH] fix(dashboard): jobs list badge distinguishes success from
 failure

state="exited" alone doesn't mean success -- a job whose command ran
but exited nonzero looked identical to a real success, both a plain
gray "exited" badge. The API already returns output.exit_code in the
list payload; the badge/label just never read it.

exited+exit_code:0 now renders "done" (neutral styling); exited with
a nonzero code renders "failed" (urgent styling), matching real
failed/killed jobs. Detail view gets the same treatment. output can
be null (seen on failed jobs) so both helpers use optional chaining.

Agentflare-Agent: claude-code
Agentflare-Branch: task/54
Agentflare-Item: 54
---
 dashboard/web/jobs.html | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/dashboard/web/jobs.html b/dashboard/web/jobs.html
index f878b47e3..83c67c53f 100644
--- a/dashboard/web/jobs.html
+++ b/dashboard/web/jobs.html
@@ -93,7 +93,7 @@ <h1 x-show="selectedId">Job <span class="af-mono" x-text="selectedId.substring(0
                   <td class="af-mono" x-text="job.id.substring(0, 12) + '…'"></td>
                   <td class="af-mono af-truncate" x-text="jobCommand(job)"></td>
                   <td>
-                    <span class="af-badge" :class="stateClass(job.state)" x-text="job.state"></span>
+                    <span class="af-badge" :class="stateClass(job.state, job.output?.exit_code)" x-text="stateLabel(job.state, job.output?.exit_code)"></span>
                   </td>
                   <td x-text="afFormatTime(job.created_at)"></td>
                   <td x-text="afFormatTime(job.started_at)"></td>
@@ -109,7 +109,7 @@ <h1 x-show="selectedId">Job <span class="af-mono" x-text="selectedId.substring(0
           <div>
             <div class="af-item-header">
               <div class="af-item-meta">
-                <span>State: <strong :class="stateClass(detailState)" x-text="detailState"></strong></span>
+                <span>State: <strong :class="stateClass(detailState, detailExitCode)" x-text="stateLabel(detailState, detailExitCode)"></strong></span>
                 <span>ID: <strong class="af-mono" x-text="selectedId"></strong></span>
                 <span>Created: <strong x-text="afFormatTime(detailCreated)"></strong></span>
                 <span x-show="detailStarted">Started: <strong x-text="afFormatTime(detailStarted)"></strong></span>
@@ -275,13 +275,18 @@ <h1 x-show="selectedId">Job <span class="af-mono" x-text="selectedId.substring(0
           return 'command' in job ? job.command : (job.id || '');
         },
 
-        stateClass(state) {
+        stateClass(state, exitCode) {
           if (state === 'running') return 'af-prio af-prio-urgent';
           if (state === 'queued') return 'af-prio af-prio-medium';
-          if (state === 'exited') return 'af-prio af-prio-low';
+          if (state === 'exited') return exitCode === 0 ? 'af-prio af-prio-low' : 'af-prio af-prio-urgent';
           if (state === 'failed' || state === 'killed') return 'af-prio af-prio-urgent';
           return '';
         },
+
+        stateLabel(state, exitCode) {
+          if (state === 'exited') return exitCode === 0 ? 'done' : 'failed';
+          return state;
+        },
       };
     }
   </script>