add review changes

Author: s1gr1d

.agents/skills/track-framework-updates/SKILL.md

@@ -36,6 +36,17 @@ If the command fails due to sandbox network restrictions, re-run with broader pe
 
 Override `--since-days` only when the user explicitly requests a different window.
 
+### Step 1b: Check source coverage
+
+Run from the repo root:
+
+```bash
+python3 .agents/skills/track-framework-updates/scripts/check_sources.py
+```
+
+This compares the `@sentry/*` packages in `packages/` against the `sentryPackages` listed in `sources.json`.
+If any public SDK packages are **not** tracked by any framework entry, they will appear in the `untracked` array which should be added to the resulting digest.
+
 ### Step 2: Check current SDK support
 
 Run from the repo root:
@@ -108,6 +119,7 @@ Scripts live in `scripts/` and use only Python stdlib + the `gh` CLI.
 | `fetch_discussions.py` | GitHub Discussions (GraphQL) + RFC-repo PRs (REST). Links only.         |
 | `fetch_rss.py`         | RSS/Atom feeds via `urllib` + `xml.etree`.                              |
 | `check_support.py`     | Reads local `peerDependencies` and lists E2E test apps.                 |
+| `check_sources.py`     | Compares `packages/` against `sources.json` to find untracked packages. |
 | `_common.py`           | Shared: date-window math, `sources.json` loader, `gh` API helpers.      |
 
 ## Data files

.agents/skills/track-framework-updates/assets/digest-schema.json

@@ -35,5 +35,6 @@
       ]
     }
   ],
+  "untrackedPackages": ["@sentry/foo — SDK packages not covered by sources.json. Empty array if all covered."],
   "runNotes": ["Any fetcher errors. Empty array if none."]
 }

.agents/skills/track-framework-updates/assets/digest-template.md

@@ -35,6 +35,14 @@ _Window: last <SINCE_DAYS> days · generated <GENERATED_AT>_
 
 <!-- Same per-framework structure as Client-Side. -->
 
+## Source coverage
+
+⚠ The following SDK packages are **not tracked** in `sources.json`. Add an upstream framework entry or exclude them in `scripts/check_sources.py`:
+
+- `@sentry/<package>`
+
+<!-- Omit this section entirely if all packages are tracked or excluded. -->
+
 ## Run notes
 
 - <Framework>: <error message>

.agents/skills/track-framework-updates/scripts/check_sources.py

@@ -0,0 +1,115 @@
+#!/usr/bin/env python3
+"""Check that sources.json covers all public @sentry/* packages.
+
+Compares the package names found in packages/*/package.json with the
+sentryPackages referenced in sources.json. Prints any public packages
+not tracked by any framework entry.
+
+Usage:
+  check_sources.py   # prints JSON array to stdout
+
+Output shape:
+  ["@sentry/foo", ...]    (empty array when everything is covered)
+"""
+
+from __future__ import annotations
+
+import json
+import os
+import sys
+from typing import Any
+
+from _common import load_frameworks
+
+REPO_ROOT = os.path.dirname(
+    os.path.dirname(
+        os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+    )
+)
+PACKAGES_DIR = os.path.join(REPO_ROOT, "packages")
+
+EXCLUDED_PACKAGES: set[str] = {
+    # Internal build/dev tooling — not user-facing SDK packages.
+    "@sentry-internal/eslint-config-sdk",
+    "@sentry-internal/eslint-plugin-sdk",
+    "@sentry-internal/typescript",
+    "@sentry-internal/integration-shims",
+    "@sentry-internal/server-utils",
+    # Internal sub-packages that are part of a larger feature, not standalone SDKs.
+    "@sentry-internal/browser-utils",
+    "@sentry-internal/feedback",
+    "@sentry-internal/replay",
+    "@sentry-internal/replay-canvas",
+    "@sentry-internal/replay-worker",
+    # Core packages — not tied to any upstream framework.
+    "@sentry/core",
+    "@sentry/types",
+    "@sentry/browser",
+    "@sentry/node",
+    "@sentry/node-core",
+    "@sentry/node-native",
+    "@sentry/opentelemetry",
+    "@sentry/profiling-node",
+    "@sentry/wasm",
+    "@sentry/vercel-edge",
+    # Platform SDKs without a single upstream framework repo to track.
+    "@sentry/bun",
+    "@sentry/deno",
+    "@sentry/cloudflare",
+    "@sentry/aws-serverless",
+    "@sentry/google-cloud-serverless",
+}
+
+
+def _all_package_names() -> set[str]:
+    """Read the 'name' field from every packages/*/package.json."""
+    names: set[str] = set()
+    if not os.path.isdir(PACKAGES_DIR):
+        return names
+    for entry in os.listdir(PACKAGES_DIR):
+        pkg_json = os.path.join(PACKAGES_DIR, entry, "package.json")
+        if not os.path.isfile(pkg_json):
+            continue
+        with open(pkg_json, "r", encoding="utf-8") as fh:
+            data = json.load(fh)
+        name = data.get("name")
+        if name:
+            names.add(name)
+    return names
+
+
+def _tracked_packages(frameworks: list[dict[str, Any]]) -> set[str]:
+    """Collect every sentryPackage referenced in sources.json."""
+    tracked: set[str] = set()
+    for fw in frameworks:
+        for pkg in fw.get("sentryPackages", []):
+            tracked.add(pkg)
+    return tracked
+
+
+def check() -> list[str]:
+    """Return sorted list of packages not tracked in sources.json and not excluded."""
+    all_pkgs = _all_package_names()
+    tracked = _tracked_packages(load_frameworks())
+    return sorted(all_pkgs - tracked - EXCLUDED_PACKAGES)
+
+
+def main() -> None:
+    untracked = check()
+    json.dump(untracked, sys.stdout, indent=2)
+    sys.stdout.write("\n")
+    if untracked:
+        print(
+            f"\n⚠  {len(untracked)} package(s) not tracked in sources.json:",
+            file=sys.stderr,
+        )
+        for pkg in untracked:
+            print(f"   - {pkg}", file=sys.stderr)
+        print(
+            "   Add them to sources.json or to EXCLUDED_PACKAGES in this script.",
+            file=sys.stderr,
+        )
+
+
+if __name__ == "__main__":
+    main()

.agents/skills/track-framework-updates/scripts/check_support.py

@@ -61,7 +61,7 @@ def _find_e2e_apps(framework_name: str) -> list[str]:
     # Order matters: check specific names before generic ones.
     prefix_map: list[tuple[str, list[str]]] = [
         ("next", ["nextjs-"]),
-        ("sveltekit", ["sveltekit-", "sveltekit-"]),
+        ("sveltekit", ["sveltekit-"]),
         ("react router", ["react-router-", "create-remix-"]),
         ("remix", ["react-router-", "create-remix-"]),
         ("tanstack", ["tanstackstart-", "tanstack-"]),