From fec7c4b42a23ee051f689bb3f68f7d5f8250a5a1 Mon Sep 17 00:00:00 2001 From: Jacob Page Date: Mon, 24 Aug 2026 16:03:13 -0700 Subject: [PATCH 1/2] fix(ci): build full workspace for CodeQL Rust scan cargo build in a mixed package+workspace root only builds the root package, silently skipping tools/generate-api-catalog and all test targets/dev-dependencies. CodeQL's Rust database quality metrics flag low call-target/type resolution partly due to that incomplete build. --- .github/workflows/codeql-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index d2cf4b92..10b3fccf 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -28,7 +28,7 @@ jobs: languages: rust - name: Build - run: cargo build + run: cargo build --workspace --all-targets working-directory: rust - name: Perform CodeQL Analysis From 148878bda4b3a701324ed1ee9ca7c7c8ea815404 Mon Sep 17 00:00:00 2001 From: Jacob Page Date: Mon, 24 Aug 2026 16:12:50 -0700 Subject: [PATCH 2/2] fix(ci): install rust-src for CodeQL Rust extraction MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Analyze job's own CodeQL log showed sysroot_src/proc_macro_server unset and ~2800 macro-expansion failures across 135/152 files for completely ordinary macros (format!, vec!, assert!, json!) — the minimal rustup profile installed by dtolnay/rust-toolchain has no rust-src, so CodeQL's semantic analyzer has no std-library source to resolve against. The prior --workspace --all-targets build fix left the quality metrics byte-for-byte unchanged, confirming the Rust extractor performs its own indexing pass independent of the workflow's Build step. --- .github/workflows/codeql-analysis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 10b3fccf..84b6c5f2 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -21,6 +21,8 @@ jobs: - name: Install Rust toolchain uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable + with: + components: rust-src - name: Initialize CodeQL uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2