From 26a29b4f5e943e8db16bc54406bc4be58bfd85fb Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Tue, 3 Nov 2026 17:59:42 +0000 Subject: [PATCH] ci(google-crc32c): fix windows build --- packages/google-crc32c/scripts/windows/build.bat | 4 +++- packages/google-crc32c/scripts/windows/test.bat | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/google-crc32c/scripts/windows/build.bat b/packages/google-crc32c/scripts/windows/build.bat index f4f6645e2fe6..d2abf7c2ff9b 100644 --- a/packages/google-crc32c/scripts/windows/build.bat +++ b/packages/google-crc32c/scripts/windows/build.bat @@ -51,7 +51,9 @@ FOR %%P IN (%SUPPORTED_PYTHON_VERSIONS%) DO ( echo "Listing available Python versions" py -0 - + @rem pyreadline is removed here because pip>=26.3 and pytest will opportunistically + @rem use it if available, but the pre-installed version is too old to work. + py -!python_version_trimmed!-64 -m pip uninstall -y pyreadline || goto :error py -!python_version_trimmed!-64 -m pip install --upgrade pip || goto :error echo "Installing cmake for Python %%P" diff --git a/packages/google-crc32c/scripts/windows/test.bat b/packages/google-crc32c/scripts/windows/test.bat index 96069e645d24..126165411c25 100644 --- a/packages/google-crc32c/scripts/windows/test.bat +++ b/packages/google-crc32c/scripts/windows/test.bat @@ -25,8 +25,5 @@ py -%PYTHON_VERSION%-64 -m pip install --no-index --find-links=wheels google-crc py -%PYTHON_VERSION%-64 ./scripts/check_crc32c_extension.py -@rem pyreadline is removed here because pytest will opportunistically use it if -@rem available, but the installed version is too old to work. -py -%PYTHON_VERSION%-64 -m pip uninstall -y pyreadline py -%PYTHON_VERSION%-64 -m pip install pytest py -%PYTHON_VERSION%-64 -m pytest tests --junitxml=%PYTHON_VERSION%_sponge_log.xml