From f2b67ea97d724e867aa12ddea32df101a6f73c07 Mon Sep 17 00:00:00 2001 From: Tim Diekmann Date: Tue, 11 Aug 2026 11:34:25 +0200 Subject: [PATCH 1/2] SRE-927: Gate shellcheck at error level and ignore concurrency.queue --- .github/workflows/preflight-actionlint.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/preflight-actionlint.yml b/.github/workflows/preflight-actionlint.yml index 5147cad..e4f0cf8 100644 --- a/.github/workflows/preflight-actionlint.yml +++ b/.github/workflows/preflight-actionlint.yml @@ -23,9 +23,15 @@ jobs: - name: Checkout uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - # TODO(SRE-941): drop the -ignore flags once actionlint knows `$/` (rhysd/actionlint#711) + # TODO(SRE-941): drop the -ignore flags once actionlint knows `$/` + # (rhysd/actionlint#711) and `concurrency.queue` (rhysd/actionlint#654) - name: Actionlint + env: + # Only error-level shellcheck findings gate; style/info findings in + # workflow scripts stay non-blocking. + SHELLCHECK_OPTS: --severity=error run: >- go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -ignore 'specifying action "\$/.+" in invalid format because ref is missing' -ignore 'reusable workflow call "\$/.+" at "uses" is not following the format' + -ignore 'unexpected key "queue" for "concurrency" section' From d7a1c9b5dba757d9327f1f4a572280d308cdcb86 Mon Sep 17 00:00:00 2001 From: Tim Diekmann Date: Tue, 11 Aug 2026 12:02:49 +0200 Subject: [PATCH 2/2] SRE-927: Drop the shellcheck severity gate --- .github/workflows/preflight-actionlint.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/preflight-actionlint.yml b/.github/workflows/preflight-actionlint.yml index e4f0cf8..0aaafc8 100644 --- a/.github/workflows/preflight-actionlint.yml +++ b/.github/workflows/preflight-actionlint.yml @@ -26,10 +26,6 @@ jobs: # TODO(SRE-941): drop the -ignore flags once actionlint knows `$/` # (rhysd/actionlint#711) and `concurrency.queue` (rhysd/actionlint#654) - name: Actionlint - env: - # Only error-level shellcheck findings gate; style/info findings in - # workflow scripts stay non-blocking. - SHELLCHECK_OPTS: --severity=error run: >- go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -ignore 'specifying action "\$/.+" in invalid format because ref is missing'