Skip to content

Better error messages for openid.authenticate provider filtering #145

Description

@jmlane

Hello and thanks for implementing OpenID in Node.js!

I'm relatively inexperienced with the specifications, but I did look over the 2.0 spec while trying to get things working with a poorly documented provider, so keep that in mind if my critique is unfounded.

In the openid.authenticate method, the provider validation/filtering code does not seem to give sufficient feedback to the consumer in terms of why a provider is unsuitable. As a result, I had to step through the source in my implementation to figure out what was causing my provider to be discarded.

PS. In turns out I needed to be using stateless mode but I had no way of knowing that was required of me prior to my debugging session.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions