Shouldn't detectCycles check ignore packages that are ignored with --exclude option?

[vvscode]

wsrun discovered cycle dependencies in my project (many thanks), but I do not see any way to run command before I complete refactoring (not a peace of cake).

I would expect detectCycles check ignores packages from exclude list, but it doesn't. Is it on purpose? or just didn't think about his case?

Packages that have cycle deps are not affected with a command run, but the fact just completely stops using wsrun for me

Thanks in advance

[spion]

We made the decision early on not to support cycles at all as ensuring that the current implementation doesn't end up in an endless loop was otherwise too difficult.

In the current implementation, exclude does not also imply "exclude dependencies", so the dependencies of the package are still considered. A refactoring that separates the planning stage from the execution stage would make what you ask for possible.

[vvscode]

@spion if I understand correctly it's about getting wsrun stack. Did you discuss the case when you disable cycle detection, but put maximum time for processing (if it did not complete in X seconds you just exist process with an error about cycles)?

[spion]

There would be no timeout as the entire process would very likely be stuck CPU processing.

Even if we found a way to avoid that, using a timeout is error prone. Some processes take a long time, others don't, yet others take variable amount of time (for example, a fist non-incremental compile taking a minute VS second incremental compile taking a second).

[vvscode]

ok

Why can't we just check if in cycle-chain (that is currently printed) there is no excluded package? (and if yes - we just skip this check)

Or it's more complex process?