Inconsistent ParseException: foo bar.baz

[julianladisch]

All these four cql expressions result in the same parse tree when sent to new CQLParser().parse(cql).toXCQL():

foo bar
"foo bar"
cql.serverChoice=foo bar
cql.serverChoice="foo bar"

When sending these other four cql expressions only the two quoted work, the two unquoted result in CQLParseException: expected index or term, got EOF:

foo bar.baz
"foo bar.baz"
cql.serverChoice=foo bar.baz
cql.serverChoice="foo bar.baz"

This is inconsistent. Either accept all unquoted or no unquoted expressions.

[adamdickmeiss]

The period in the name makes the CQL parser treat it as a relation. Inconsistent? Maybe.

Having two terms unquoted is not allowed in CQL as specified in the standard. In that mode, the 1st and 3rd in both lists are invalid and shoud throw a syntax error. That is actually more consistent.

[jakub-id]

@julianladisch what do you mean by "when sending". Sending where?

@adamdickmeiss support for free-form multi-term expressions was added here b76b718

to align it with the C implementation. We've been long debating over this and @MikeTaylor has been always pushing for it. While it's nice to be able to just specify a list "words" as the query, it means the parser is not compliant with the CQL specification and we need to additional tricks (see allowKeywordTerms in CQLParser.java`) do distinguish between keywords (like booleans) rather than simply depend on term positions.

[julianladisch]

"Sending" means passing the CQL query as the cql parameter when invoking new CQLParser().parse(cql).