From fc6fd959bc04af50c4de895fa2991bdc8621fee6 Mon Sep 17 00:00:00 2001 From: Yijia Wang Date: Thu, 27 Aug 2026 22:04:15 +0800 Subject: [PATCH 1/2] BM/pstate: Fix balance_performance EPP check on EMR intel_pstate_tests08 sets energy_performance_preference to balance_performance and then verifies the EPP request value reported by x86_energy_perf_policy. The test currently treats only Sapphire Rapids model 143 as using EPP 32, so Emerald Rapids model 207 falls back to the legacy expected value 128. The upstream Linux change 64a66f4a3c89 ("cpufreq: intel_pstate: Update Balance performance EPP for Emerald Rapids") changed Emerald Rapids to use the same balance_performance EPP value as Sapphire Rapids, 32. Update the LKVS expectation for model 207 to match the kernel behavior. Signed-off-by: Yijia Wang --- BM/pstate/intel_pstate_tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BM/pstate/intel_pstate_tests.sh b/BM/pstate/intel_pstate_tests.sh index d933e9a2..ba88ab5a 100755 --- a/BM/pstate/intel_pstate_tests.sh +++ b/BM/pstate/intel_pstate_tests.sh @@ -832,9 +832,9 @@ check_epp_req() { performance) epp_req=0 ;; - # SPR will use 32 for balance_performance EPP value + # SPR and EMR will use 32 for balance_performance EPP value balance_performance) - if [ "$cpu_model" == 143 ]; then + if [ "$cpu_model" == 143 ] || [ "$cpu_model" == 207 ]; then epp_req=32 else epp_req=128 From 4fa282f38aec64f1023e48509405e2ddbb148081 Mon Sep 17 00:00:00 2001 From: "wangyijia.yeah" Date: Tue, 8 Sep 2026 10:43:39 +0800 Subject: [PATCH 2/2] BM/pstate: Resolve pre-existing shellcheck issues in intel_pstate_tests.sh These SC2155/SC2004/SC2034 warnings are not introduced by this PR but block CI since the file is now lint-checked. Clean them up. Co-authored-by: TRAE CLI --- BM/pstate/intel_pstate_tests.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/BM/pstate/intel_pstate_tests.sh b/BM/pstate/intel_pstate_tests.sh index ba88ab5a..0570564b 100755 --- a/BM/pstate/intel_pstate_tests.sh +++ b/BM/pstate/intel_pstate_tests.sh @@ -22,8 +22,10 @@ CPU_CPUFREQ_ATTR="affected_cpus cpuinfo_max_freq cpuinfo_min_freq scaling_min_freq scaling_setspeed" DEFAULT_SCALING_GOV=$(cat $CPU_SYSFS_PATH/cpu0/cpufreq/scaling_governor) -readonly no_turbo_value=$(cat "$CPU_NO_TURBO_NODE") -readonly pstate_status_value=$(cat "$CPU_PSTATE_SYSFS_PATH/status") +no_turbo_value=$(cat "$CPU_NO_TURBO_NODE") +readonly no_turbo_value +pstate_status_value=$(cat "$CPU_PSTATE_SYSFS_PATH/status") +readonly pstate_status_value # rdmsr tool is required to run pstate cases if which rdmsr 1>/dev/null 2>&1; then @@ -65,7 +67,7 @@ pstate_teardown() { local online_cpu="" online_cpu=$(ls /sys/devices/system/cpu/cpu*/online | wc -l) - online_cpu=$(($online_cpu+1)) + online_cpu=$((online_cpu+1)) test_print_trc "Total CPUs from /sys/devices/: $online_cpu" # Hot plug all logic CPUs except cpu0 @@ -1129,5 +1131,6 @@ intel_pstate_test() { } intel_pstate_test +# shellcheck disable=SC2034 # consumed by exec_teardown from test framework teardown_handler="pstate_teardown" exec_teardown