diff --git a/.github/workflows/update-framework.yml b/.github/workflows/update-framework.yml index a9e27dc..9bde9fc 100644 --- a/.github/workflows/update-framework.yml +++ b/.github/workflows/update-framework.yml @@ -47,6 +47,14 @@ jobs: if: steps.changes.outputs.has_changes == 'true' uses: peter-evans/create-pull-request@v6 with: + # Without an explicit token this falls back to GITHUB_TOKEN, and + # GitHub suppresses workflow triggers for events raised by that + # token to avoid recursion. The result is a PR with zero check runs, + # which nobody can review with any confidence. Set + # FRAMEWORK_UPDATE_TOKEN to a PAT (or app token) with `repo` scope to + # get CI on these PRs. If it is unset, this degrades to the previous + # behaviour rather than failing the run. + token: ${{ secrets.FRAMEWORK_UPDATE_TOKEN || github.token }} commit-message: 'chore: routine joplin plugin framework update' title: 'chore: routine joplin plugin framework update' body: | @@ -58,8 +66,11 @@ jobs: ```json ${{ steps.new-tsconfig-json.outputs.content }} ``` + # No branch-suffix: a fixed branch name makes the action update the + # existing open PR in place each month. With a timestamp suffix every + # run got its own branch and opened a fresh PR, so #168, #170 and #172 + # ended up as three byte-identical PRs for a diff that had not moved. branch: chore/update-plugin-framework - branch-suffix: timestamp committer: Albus author: Albus delete-branch: true