diff --git a/src/kiro_crew/docs/ui-index.generated.json b/src/kiro_crew/docs/ui-index.generated.json index a377743176d0..af0192722173 100644 --- a/src/kiro_crew/docs/ui-index.generated.json +++ b/src/kiro_crew/docs/ui-index.generated.json @@ -1,8 +1,8 @@ { "$comment": "AUTO-GENERATED by website/scripts/gen-ui-index.mjs from the dashboard source — DO NOT EDIT. Regenerate with `npm run gen:ui`; read by the find_ui tool (kiro_crew/mcp_guide.py).", "schema_version": 1, -"input_digest": "sha256:f0e235936b62e35b90d4f6f40ca9414290dda18d6fd6b2d304aaec1869f231f5", -"build_digest": "sha256:515ce57654d554c6a834d0265b68ac48329e0a09c23bf5ab3246cb9ad54d5daa", +"input_digest": "sha256:ae1a6707c7fd7840fb406945a3ae0304bf279e0d21c4dfbd8963cbbcd43ffeb4", +"build_digest": "sha256:8ab228754d23ceb58f5c723082e776d7f9a6fc9563ecb0373980a5d4d1096b2d", "coverage": {"scope":"pages, page tabs, Settings tabs and sub-pages, every Settings control, registered controls; not every dashboard control","counts":{"button":85,"list":6,"field":3,"tab":83,"menu-item":27,"toggle":11,"disclosure":1,"page":13,"setting":242,"link":1},"tiers":{"generated":333,"curated":139},"registered_controls":139}, "locales": ["en","zh-CN","hi","es","fr","bn","pt","ru","de","ja","ko","it"], "surfaces": ["apps","apps-library","artifacts","capabilities","chat","developer","logs","members","notifications","projects","schedule","settings","shell","webhooks"], @@ -80,10 +80,10 @@ {"id":"mcp.add-custom","kind":"button","label_key":"pages.overview.mcpTab.add_custom","placements":[{"surface_id":"capabilities","route":"/capabilities?tab=mcp","parent_ids":["page.capabilities","tab.capabilities.mcp","connections.mcp-servers-tab"],"entry_kind":"toolbar","requires":[]}],"guide_ref":{"action_id":"mcp.open_add"},"guide_policy":"point","terms":{"en":["add mcp","add an mcp server","add mcp server","new mcp server","connect an mcp server","custom mcp server","add mcp manually","mcp json","paste mcp config","my own mcp server","mcp server with an environment variable","mcp server with environment variables","mcp environment variables","mcp env vars"],"zh-CN":["添加 MCP","添加 MCP 服务器","新增 MCP","接入 MCP","新建 MCP 服务器","自定义 MCP 服务器","手动添加 MCP","MCP 配置","MCP 环境变量","带环境变量的 MCP 服务器"]},"tier":"curated"}, {"id":"mcp.add-server","kind":"button","label_key":"pages.overview.mcpTab.add_server","placements":[{"surface_id":"capabilities","route":"/capabilities?tab=mcp","parent_ids":["page.capabilities","tab.capabilities.mcp","connections.mcp-servers-tab"],"entry_kind":"toolbar","requires":[]}],"guide_plan":{"version":2,"label_key":"pages.overview.mcpTab.add_server","placements":[{"id":"any","route":"/capabilities?tab=mcp","steps":[{"id":"any:connections.mcp-servers-tab","location":"connections.mcp-servers-tab","label_key":"pages.connectionsPage.mcp_servers","scope":"open:connections.mcp-servers-tab"},{"id":"any:mcp.add-server","location":"mcp.add-server","label_key":"pages.overview.mcpTab.add_server"}]}]},"guide_policy":"point","terms":{"en":["add mcp","add an mcp server","add mcp server","new mcp server","connect an mcp server","install an mcp server","browse mcp servers","mcp store","mcp catalog","find mcp servers"],"zh-CN":["添加 MCP","添加 MCP 服务器","新增 MCP","接入 MCP","新建 MCP 服务器","安装 MCP","安装 MCP 服务器","MCP 市场","浏览 MCP 服务器"]},"tier":"curated"}, {"id":"mcp.probe","kind":"button","label_key":"pages.overview.mcpTab.probe_mcp_servers","placements":[{"surface_id":"capabilities","route":"/capabilities?tab=mcp","parent_ids":["page.capabilities","tab.capabilities.mcp","connections.mcp-servers-tab"],"entry_kind":"toolbar","requires":[]}],"guide_plan":{"version":2,"label_key":"pages.overview.mcpTab.probe_mcp_servers","placements":[{"id":"any","route":"/capabilities?tab=mcp","steps":[{"id":"any:connections.mcp-servers-tab","location":"connections.mcp-servers-tab","label_key":"pages.connectionsPage.mcp_servers","scope":"open:connections.mcp-servers-tab"},{"id":"any:mcp.probe","location":"mcp.probe","label_key":"pages.overview.mcpTab.probe_mcp_servers"}]}]},"guide_policy":"point","terms":{"en":["test my mcp servers","check mcp servers","refresh mcp servers","reconnect mcp servers","are my mcp servers working"],"zh-CN":["检测 MCP 服务器","测试 MCP 服务器","刷新 MCP 服务器","检查 MCP 连接"]},"tier":"curated"}, -{"id":"members.add-menu","kind":"button","label_key":"pages.membersPage.add_menu","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"toolbar","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"has_crewmates"},{"kind":"shown_by","location":"members.switcher.show-roster","when":"crewmate_roster_folded"},{"kind":"shown_by","location":"members.back","when":"crewmate_chat_open_phone"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.add_menu","placements":[{"id":"desktop","route":"/members","viewport":"desktop","steps":[{"id":"desktop:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"desktop:members.switcher","location":"members.switcher","label_key":"pages.membersPage.switch_crewmate","scope":"menu:members.switcher"},{"id":"desktop:members.switcher.show-roster","location":"members.switcher.show-roster","label_key":"pages.membersPage.roster_show","when":"crewmate_roster_folded","scope":"members.roster"},{"id":"desktop:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","requires":["has_crewmates"]}]},{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.back_to_roster","when":"crewmate_chat_open_phone","scope":"members.roster-phone"},{"id":"mobile:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","requires":["has_crewmates"]}]}]},"guide_policy":"point","tier":"curated"}, -{"id":"members.add-menu.advanced","kind":"menu-item","label_key":"pages.membersPage.create_advanced","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members","members.add-menu"],"entry_kind":"menu","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"has_crewmates"},{"kind":"shown_by","location":"members.switcher.show-roster","when":"crewmate_roster_folded"},{"kind":"shown_by","location":"members.back","when":"crewmate_chat_open_phone"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.create_advanced","placements":[{"id":"desktop","route":"/members","viewport":"desktop","steps":[{"id":"desktop:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"desktop:members.switcher","location":"members.switcher","label_key":"pages.membersPage.switch_crewmate","scope":"menu:members.switcher"},{"id":"desktop:members.switcher.show-roster","location":"members.switcher.show-roster","label_key":"pages.membersPage.roster_show","when":"crewmate_roster_folded","scope":"members.roster"},{"id":"desktop:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"desktop:members.add-menu.advanced","location":"members.add-menu.advanced","label_key":"pages.membersPage.create_advanced"}]},{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.back_to_roster","when":"crewmate_chat_open_phone","scope":"members.roster-phone"},{"id":"mobile:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"mobile:members.add-menu.advanced","location":"members.add-menu.advanced","label_key":"pages.membersPage.create_advanced"}]}]},"guide_policy":"point","terms":{"en":["advanced crewmate setup","full crewmate form","all crewmate options"],"zh-CN":["高级队友设置","高级创建队友","完整的队友表单"]},"tier":"curated"}, -{"id":"members.add-menu.new","kind":"menu-item","label_key":"pages.membersPage.add_member","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members","members.add-menu"],"entry_kind":"menu","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"has_crewmates"},{"kind":"shown_by","location":"members.switcher.show-roster","when":"crewmate_roster_folded"},{"kind":"shown_by","location":"members.back","when":"crewmate_chat_open_phone"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.add_member","placements":[{"id":"desktop","route":"/members","viewport":"desktop","steps":[{"id":"desktop:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"desktop:members.switcher","location":"members.switcher","label_key":"pages.membersPage.switch_crewmate","scope":"menu:members.switcher"},{"id":"desktop:members.switcher.show-roster","location":"members.switcher.show-roster","label_key":"pages.membersPage.roster_show","when":"crewmate_roster_folded","scope":"members.roster"},{"id":"desktop:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"desktop:members.add-menu.new","location":"members.add-menu.new","label_key":"pages.membersPage.add_member"}]},{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.back_to_roster","when":"crewmate_chat_open_phone","scope":"members.roster-phone"},{"id":"mobile:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"mobile:members.add-menu.new","location":"members.add-menu.new","label_key":"pages.membersPage.add_member"}]}]},"guide_policy":"point","terms":{"en":["create a crewmate","make a crewmate","add a crewmate","new agent","add a new agent","create an agent","make an agent","add an agent","new teammate","add a teammate"],"zh-CN":["创建队友","新建代理","创建代理","添加代理","新建智能体","创建智能体"],"es":["crear un agente","añadir un agente"],"fr":["créer un agent","ajouter un agent"],"pt":["criar um agente","adicionar um agente"],"ru":["создать агента","добавить агента"],"de":["Agent erstellen","Agent hinzufügen"],"ja":["クルーメイトを作成","エージェントを作成"],"ko":["크루메이트 만들기","에이전트 만들기"],"it":["creare un agente","aggiungere un agente"]},"tier":"curated"}, -{"id":"members.back","kind":"button","label_key":"pages.membersPage.back_to_roster","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"header","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"viewport","value":"mobile"},{"kind":"condition","id":"crewmate_selected"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.back_to_roster","placements":[{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:select:crewmate_selected","kind":"select","location":"members.roster-list","label_key":"pages.membersPage.title","selection":"crewmate_selected","entity":"crewmate"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.back_to_roster"}]}]},"guide_policy":"point","terms":{"en":["back to the crewmate list","all my crewmates","crewmate roster"],"zh-CN":["所有队友","队友名单"]},"tier":"curated"}, +{"id":"members.add-menu","kind":"button","label_key":"pages.membersPage.add_menu","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"toolbar","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"has_crewmates"},{"kind":"shown_by","location":"members.switcher.show-roster","when":"crewmate_roster_folded"},{"kind":"shown_by","location":"members.back","when":"crewmate_chat_open_phone"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.add_menu","placements":[{"id":"desktop","route":"/members","viewport":"desktop","steps":[{"id":"desktop:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"desktop:members.switcher","location":"members.switcher","label_key":"pages.membersPage.switch_crewmate","scope":"menu:members.switcher"},{"id":"desktop:members.switcher.show-roster","location":"members.switcher.show-roster","label_key":"pages.membersPage.roster_show","when":"crewmate_roster_folded","scope":"members.roster"},{"id":"desktop:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","requires":["has_crewmates"]}]},{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.toggle_roster","when":"crewmate_chat_open_phone","scope":"members.roster-phone"},{"id":"mobile:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","requires":["has_crewmates"]}]}]},"guide_policy":"point","tier":"curated"}, +{"id":"members.add-menu.advanced","kind":"menu-item","label_key":"pages.membersPage.create_advanced","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members","members.add-menu"],"entry_kind":"menu","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"has_crewmates"},{"kind":"shown_by","location":"members.switcher.show-roster","when":"crewmate_roster_folded"},{"kind":"shown_by","location":"members.back","when":"crewmate_chat_open_phone"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.create_advanced","placements":[{"id":"desktop","route":"/members","viewport":"desktop","steps":[{"id":"desktop:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"desktop:members.switcher","location":"members.switcher","label_key":"pages.membersPage.switch_crewmate","scope":"menu:members.switcher"},{"id":"desktop:members.switcher.show-roster","location":"members.switcher.show-roster","label_key":"pages.membersPage.roster_show","when":"crewmate_roster_folded","scope":"members.roster"},{"id":"desktop:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"desktop:members.add-menu.advanced","location":"members.add-menu.advanced","label_key":"pages.membersPage.create_advanced"}]},{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.toggle_roster","when":"crewmate_chat_open_phone","scope":"members.roster-phone"},{"id":"mobile:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"mobile:members.add-menu.advanced","location":"members.add-menu.advanced","label_key":"pages.membersPage.create_advanced"}]}]},"guide_policy":"point","terms":{"en":["advanced crewmate setup","full crewmate form","all crewmate options"],"zh-CN":["高级队友设置","高级创建队友","完整的队友表单"]},"tier":"curated"}, +{"id":"members.add-menu.new","kind":"menu-item","label_key":"pages.membersPage.add_member","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members","members.add-menu"],"entry_kind":"menu","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"has_crewmates"},{"kind":"shown_by","location":"members.switcher.show-roster","when":"crewmate_roster_folded"},{"kind":"shown_by","location":"members.back","when":"crewmate_chat_open_phone"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.add_member","placements":[{"id":"desktop","route":"/members","viewport":"desktop","steps":[{"id":"desktop:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"desktop:members.switcher","location":"members.switcher","label_key":"pages.membersPage.switch_crewmate","scope":"menu:members.switcher"},{"id":"desktop:members.switcher.show-roster","location":"members.switcher.show-roster","label_key":"pages.membersPage.roster_show","when":"crewmate_roster_folded","scope":"members.roster"},{"id":"desktop:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"desktop:members.add-menu.new","location":"members.add-menu.new","label_key":"pages.membersPage.add_member"}]},{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.toggle_roster","when":"crewmate_chat_open_phone","scope":"members.roster-phone"},{"id":"mobile:members.add-menu","location":"members.add-menu","label_key":"pages.membersPage.add_menu","scope":"menu:members.add-menu","requires":["has_crewmates"]},{"id":"mobile:members.add-menu.new","location":"members.add-menu.new","label_key":"pages.membersPage.add_member"}]}]},"guide_policy":"point","terms":{"en":["create a crewmate","make a crewmate","add a crewmate","new agent","add a new agent","create an agent","make an agent","add an agent","new teammate","add a teammate"],"zh-CN":["创建队友","新建代理","创建代理","添加代理","新建智能体","创建智能体"],"es":["crear un agente","añadir un agente"],"fr":["créer un agent","ajouter un agent"],"pt":["criar um agente","adicionar um agente"],"ru":["создать агента","добавить агента"],"de":["Agent erstellen","Agent hinzufügen"],"ja":["クルーメイトを作成","エージェントを作成"],"ko":["크루메이트 만들기","에이전트 만들기"],"it":["creare un agente","aggiungere un agente"]},"tier":"curated"}, +{"id":"members.back","kind":"button","label_key":"pages.membersPage.toggle_roster","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"header","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"viewport","value":"mobile"},{"kind":"condition","id":"crewmate_selected"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.toggle_roster","placements":[{"id":"mobile","route":"/members","viewport":"mobile","steps":[{"id":"mobile:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"mobile:select:crewmate_selected","kind":"select","location":"members.roster-list","label_key":"pages.membersPage.title","selection":"crewmate_selected","entity":"crewmate"},{"id":"mobile:members.back","location":"members.back","label_key":"pages.membersPage.toggle_roster"}]}]},"guide_policy":"point","terms":{"en":["back to the crewmate list","all my crewmates","crewmate roster"],"zh-CN":["所有队友","队友名单"]},"tier":"curated"}, {"id":"members.details","kind":"toggle","label_key":"pages.membersPage.panel_toggle","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"header","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"crewmate_selected"},{"kind":"condition","id":"crewmate_panel_not_docked"}]}],"guide_policy":"point","terms":{"en":["crewmate details","crewmate info","side panel","show crewmate details"],"zh-CN":["队友详情","队友信息","侧边面板"]},"tier":"curated"}, {"id":"members.edit","kind":"button","label_key":"pages.membersPage.profile_card","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"content","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"crewmate_selected"}]}],"guide_plan":{"version":2,"label_key":"pages.membersPage.profile_card","placements":[{"id":"any","route":"/members","steps":[{"id":"any:gate:preview_flag:mc-preview-crew","kind":"gate","gate":"preview_flag:mc-preview-crew","setting_id":"developer.crewmates"},{"id":"any:select:crewmate_selected","kind":"select","location":"members.roster-list","label_key":"pages.membersPage.title","selection":"crewmate_selected","entity":"crewmate"},{"id":"any:members.edit","location":"members.edit","label_key":"pages.membersPage.profile_card"}]}]},"guide_policy":"point","terms":{"en":["edit my crewmate","change my crewmate","crewmate settings","edit an agent","change agent settings"],"zh-CN":["修改队友","编辑队友","队友设置","编辑代理","修改代理设置"]},"tier":"curated"}, {"id":"members.new","kind":"button","label_key":"pages.membersPage.add_member","placements":[{"surface_id":"members","route":"/members","parent_ids":["page.members"],"entry_kind":"content","requires":[{"kind":"preview_flag","flag":"mc-preview-crew","location":"setting:developer.crewmates"},{"kind":"condition","id":"no_crewmates"}]}],"guide_policy":"point","terms":{"en":["create a crewmate","make a crewmate","add a crewmate","new agent","add a new agent","create an agent","make an agent","add an agent","new teammate","add a teammate"],"zh-CN":["创建队友","新建代理","创建代理","添加代理","新建智能体","创建智能体"],"es":["crear un agente","añadir un agente"],"fr":["créer un agent","ajouter un agent"],"pt":["criar um agente","adicionar um agente"],"ru":["создать агента","добавить агента"],"de":["Agent erstellen","Agent hinzufügen"],"ja":["クルーメイトを作成","エージェントを作成"],"ko":["크루메이트 만들기","에이전트 만들기"],"it":["creare un agente","aggiungere un agente"]},"tier":"curated"}, @@ -670,7 +670,6 @@ "pages.libraryPage.tile_details": "Details", "pages.membersPage.add_member": "New crewmate", "pages.membersPage.add_menu": "Add…", -"pages.membersPage.back_to_roster": "Back to crewmates", "pages.membersPage.create_advanced": "Advanced", "pages.membersPage.panel_toggle": "Dashboard & files", "pages.membersPage.profile_card": "Profile", @@ -679,6 +678,7 @@ "pages.membersPage.roster_show": "Show the full roster", "pages.membersPage.switch_crewmate": "Switch crewmate", "pages.membersPage.title": "Crewmates", +"pages.membersPage.toggle_roster": "Toggle crewmates", "pages.membersPage.unread_message": "Unread message", "pages.overview.mcpTab.add_custom": "Add Custom", "pages.overview.mcpTab.add_server": "Add Server", @@ -1128,7 +1128,6 @@ "pages.libraryPage.tile_details": "详情", "pages.membersPage.add_member": "新建队友", "pages.membersPage.add_menu": "添加…", -"pages.membersPage.back_to_roster": "返回队友列表", "pages.membersPage.create_advanced": "高级", "pages.membersPage.panel_toggle": "仪表板和文件", "pages.membersPage.profile_card": "资料卡", @@ -1137,6 +1136,7 @@ "pages.membersPage.roster_show": "显示完整队友列表", "pages.membersPage.switch_crewmate": "切换队友", "pages.membersPage.title": "队友", +"pages.membersPage.toggle_roster": "切换队友列表", "pages.membersPage.unread_message": "未读消息", "pages.overview.mcpTab.add_custom": "添加自定义", "pages.overview.mcpTab.add_server": "添加服务器", @@ -1586,7 +1586,6 @@ "pages.libraryPage.tile_details": "विवरण", "pages.membersPage.add_member": "नया साथी", "pages.membersPage.add_menu": "जोड़ें…", -"pages.membersPage.back_to_roster": "साथियों की सूची पर वापस", "pages.membersPage.create_advanced": "उन्नत", "pages.membersPage.panel_toggle": "डैशबोर्ड और फ़ाइलें", "pages.membersPage.profile_card": "प्रोफ़ाइल", @@ -1595,6 +1594,7 @@ "pages.membersPage.roster_show": "पूरी साथी सूची दिखाओ", "pages.membersPage.switch_crewmate": "क्रूमेट बदलें", "pages.membersPage.title": "साथी", +"pages.membersPage.toggle_roster": "साथियों की सूची दिखाएँ/छिपाएँ", "pages.membersPage.unread_message": "अपठित संदेश", "pages.overview.mcpTab.add_custom": "कस्टम जोड़ें", "pages.overview.mcpTab.add_server": "सर्वर जोड़ें", @@ -2044,7 +2044,6 @@ "pages.libraryPage.tile_details": "Detalles", "pages.membersPage.add_member": "Nuevo compañero", "pages.membersPage.add_menu": "Añadir…", -"pages.membersPage.back_to_roster": "Volver a los compañeros", "pages.membersPage.create_advanced": "Avanzado", "pages.membersPage.panel_toggle": "Panel y archivos", "pages.membersPage.profile_card": "Perfil", @@ -2053,6 +2052,7 @@ "pages.membersPage.roster_show": "Mostrar la lista completa de compañeros", "pages.membersPage.switch_crewmate": "Cambiar de compañero", "pages.membersPage.title": "Compañeros", +"pages.membersPage.toggle_roster": "Mostrar u ocultar compañeros", "pages.membersPage.unread_message": "Mensaje sin leer", "pages.overview.mcpTab.add_custom": "Añadir personalizado", "pages.overview.mcpTab.add_server": "Añadir servidor", @@ -2502,7 +2502,6 @@ "pages.libraryPage.tile_details": "Détails", "pages.membersPage.add_member": "Nouveau coéquipier", "pages.membersPage.add_menu": "Ajouter…", -"pages.membersPage.back_to_roster": "Retour aux coéquipiers", "pages.membersPage.create_advanced": "Avancé", "pages.membersPage.panel_toggle": "Tableau de bord et fichiers", "pages.membersPage.profile_card": "Profil", @@ -2511,6 +2510,7 @@ "pages.membersPage.roster_show": "Afficher la liste complète des coéquipiers", "pages.membersPage.switch_crewmate": "Changer de coéquipier", "pages.membersPage.title": "Coéquipiers", +"pages.membersPage.toggle_roster": "Afficher/masquer les coéquipiers", "pages.membersPage.unread_message": "Message non lu", "pages.overview.mcpTab.add_custom": "Ajouter personnalisé", "pages.overview.mcpTab.add_server": "Ajouter un serveur", @@ -2960,7 +2960,6 @@ "pages.libraryPage.tile_details": "বিস্তারিত", "pages.membersPage.add_member": "নতুন সঙ্গী", "pages.membersPage.add_menu": "যোগ করো…", -"pages.membersPage.back_to_roster": "সঙ্গীদের তালিকায় ফিরুন", "pages.membersPage.create_advanced": "উন্নত", "pages.membersPage.panel_toggle": "ড্যাশবোর্ড ও ফাইল", "pages.membersPage.profile_card": "প্রোফাইল", @@ -2969,6 +2968,7 @@ "pages.membersPage.roster_show": "পূর্ণ সঙ্গী তালিকা দেখাও", "pages.membersPage.switch_crewmate": "ক্রুমেট পরিবর্তন করো", "pages.membersPage.title": "সঙ্গীরা", +"pages.membersPage.toggle_roster": "সঙ্গীদের তালিকা দেখাও/লুকাও", "pages.membersPage.unread_message": "অপঠিত বার্তা", "pages.overview.mcpTab.add_custom": "কাস্টম যোগ করুন", "pages.overview.mcpTab.add_server": "সার্ভার যোগ করুন", @@ -3418,7 +3418,6 @@ "pages.libraryPage.tile_details": "Detalhes", "pages.membersPage.add_member": "Novo colega", "pages.membersPage.add_menu": "Adicionar…", -"pages.membersPage.back_to_roster": "Voltar aos colegas", "pages.membersPage.create_advanced": "Avançado", "pages.membersPage.panel_toggle": "Painel e arquivos", "pages.membersPage.profile_card": "Perfil", @@ -3427,6 +3426,7 @@ "pages.membersPage.roster_show": "Mostrar a lista completa de colegas", "pages.membersPage.switch_crewmate": "Trocar de colega", "pages.membersPage.title": "Colegas", +"pages.membersPage.toggle_roster": "Alternar colegas", "pages.membersPage.unread_message": "Mensagem não lida", "pages.overview.mcpTab.add_custom": "Adicionar personalizado", "pages.overview.mcpTab.add_server": "Adicionar servidor", @@ -3876,7 +3876,6 @@ "pages.libraryPage.tile_details": "Подробности", "pages.membersPage.add_member": "Новый напарник", "pages.membersPage.add_menu": "Добавить…", -"pages.membersPage.back_to_roster": "Назад к напарникам", "pages.membersPage.create_advanced": "Дополнительно", "pages.membersPage.panel_toggle": "Панель и файлы", "pages.membersPage.profile_card": "Профиль", @@ -3885,6 +3884,7 @@ "pages.membersPage.roster_show": "Показать полный список напарников", "pages.membersPage.switch_crewmate": "Сменить напарника", "pages.membersPage.title": "Напарники", +"pages.membersPage.toggle_roster": "Показать или скрыть напарников", "pages.membersPage.unread_message": "Непрочитанное сообщение", "pages.overview.mcpTab.add_custom": "Добавить свой", "pages.overview.mcpTab.add_server": "Добавить сервер", @@ -4334,7 +4334,6 @@ "pages.libraryPage.tile_details": "Details", "pages.membersPage.add_member": "Neuer Crewmate", "pages.membersPage.add_menu": "Hinzufügen…", -"pages.membersPage.back_to_roster": "Zurück zu den Crewmates", "pages.membersPage.create_advanced": "Erweitert", "pages.membersPage.panel_toggle": "Dashboard und Dateien", "pages.membersPage.profile_card": "Profil", @@ -4343,6 +4342,7 @@ "pages.membersPage.roster_show": "Vollständige Crewmate-Liste anzeigen", "pages.membersPage.switch_crewmate": "Crewmate wechseln", "pages.membersPage.title": "Crewmates", +"pages.membersPage.toggle_roster": "Crewmates umschalten", "pages.membersPage.unread_message": "Ungelesene Nachricht", "pages.overview.mcpTab.add_custom": "Benutzerdefiniert hinzufügen", "pages.overview.mcpTab.add_server": "Server hinzufügen", @@ -4792,7 +4792,6 @@ "pages.libraryPage.tile_details": "詳細", "pages.membersPage.add_member": "新しいクルーメイト", "pages.membersPage.add_menu": "追加…", -"pages.membersPage.back_to_roster": "クルーメイト一覧に戻る", "pages.membersPage.create_advanced": "詳細設定", "pages.membersPage.panel_toggle": "ダッシュボードとファイル", "pages.membersPage.profile_card": "プロフィール", @@ -4801,6 +4800,7 @@ "pages.membersPage.roster_show": "クルーメイト一覧をすべて表示", "pages.membersPage.switch_crewmate": "クルーメイトを切り替え", "pages.membersPage.title": "クルーメイト", +"pages.membersPage.toggle_roster": "クルーメイト一覧の表示を切り替え", "pages.membersPage.unread_message": "未読メッセージ", "pages.overview.mcpTab.add_custom": "カスタムを追加", "pages.overview.mcpTab.add_server": "サーバーを追加", @@ -5250,7 +5250,6 @@ "pages.libraryPage.tile_details": "세부 정보", "pages.membersPage.add_member": "새 크루메이트", "pages.membersPage.add_menu": "추가…", -"pages.membersPage.back_to_roster": "크루메이트 목록으로", "pages.membersPage.create_advanced": "고급", "pages.membersPage.panel_toggle": "대시보드 및 파일", "pages.membersPage.profile_card": "프로필", @@ -5259,6 +5258,7 @@ "pages.membersPage.roster_show": "전체 크루메이트 목록 표시", "pages.membersPage.switch_crewmate": "크루메이트 전환", "pages.membersPage.title": "크루메이트", +"pages.membersPage.toggle_roster": "크루메이트 목록 표시 전환", "pages.membersPage.unread_message": "읽지 않은 메시지", "pages.overview.mcpTab.add_custom": "사용자 지정 추가", "pages.overview.mcpTab.add_server": "서버 추가", @@ -5708,7 +5708,6 @@ "pages.libraryPage.tile_details": "Dettagli", "pages.membersPage.add_member": "Nuovo compagno", "pages.membersPage.add_menu": "Aggiungi…", -"pages.membersPage.back_to_roster": "Torna ai compagni", "pages.membersPage.create_advanced": "Avanzate", "pages.membersPage.panel_toggle": "Dashboard e file", "pages.membersPage.profile_card": "Profilo", @@ -5717,6 +5716,7 @@ "pages.membersPage.roster_show": "Mostra l’elenco completo dei compagni", "pages.membersPage.switch_crewmate": "Cambia compagno", "pages.membersPage.title": "Compagni", +"pages.membersPage.toggle_roster": "Attiva/disattiva i compagni", "pages.membersPage.unread_message": "Messaggio non letto", "pages.overview.mcpTab.add_custom": "Aggiungi personalizzato", "pages.overview.mcpTab.add_server": "Aggiungi server", diff --git a/website/docs/narrow-viewport.md b/website/docs/narrow-viewport.md index d241901ce365..0c663c75c2eb 100644 --- a/website/docs/narrow-viewport.md +++ b/website/docs/narrow-viewport.md @@ -367,6 +367,21 @@ the apps, behind a separator. The decision reads `stableRailHeight` — the tall height seen at the current window width — so the on-screen keyboard or a browser toolbar shrinking the rail at the same width never moves the tiles. +**The Crewmates page hosts the same drawer.** On a phone `/members` lands on a +crewmate exactly as a wide window does, and its roster is a left drawer over the +open chat: the same rail (App provides `MobileNavRailContext` on this route too) +beside the roster aside, which is portaled into the drawer while a chat or team +is open. A rightward drag or the header's back control reveals it, a leftward +drag reveals the side panel (a full-width overlay that slides on `sidePanelX`), +and each gesture is off while the other's panel is open. The drawer mints the +same duplicate history entry, and a roster pick spends it FIRST, then opens the +crewmate on the entry below (`consumeRosterDrawerEntry`), so Back never reopens +the crewmate just left. With nothing open the roster is the page, the page +binds nothing and claims no side, and the shell's nav-drawer swipe works there. +The rail's Home control navigates with `replace` without closing the drawer +when its host is not the chat page, since that close would pop the entry after +the replace. + **Haptics.** `lib/haptic.ts` makes one best-effort tap: `navigator.vibrate` on Android, the hidden switch-checkbox click on iOS where the `switch` attribute exists (iOS 17.4+), and a silent no-op everywhere else; it never throws. Call it for a diff --git a/website/src/App.tsx b/website/src/App.tsx index bd202cfec66a..384109f9dc81 100644 --- a/website/src/App.tsx +++ b/website/src/App.tsx @@ -1511,9 +1511,12 @@ export default function App() { * pinned at the bottom and opens the same command palette the header's * search square used to. * - * `null` off the phone chat page, so every other consumer renders no rail. + * `null` off the phone chat and Crewmates pages, so every other consumer + * renders no rail. The Crewmates page hosts it the same way, beside its + * roster in the drawer over the open chat. */ - const mobileNavRail = mobileSingle + const railHost = mobileSingle || (isMobile && (activePath === '/members' || activePath.startsWith('/members/'))) + const mobileNavRail = railHost ? ({ onActivate }: MobileNavRailOptions) => { const railRow = ( n: { path: string; id: string; label: string; labelKey?: string; icon: React.ReactNode; appName?: string }, @@ -1552,7 +1555,18 @@ export default function App() { ) @@ -5904,32 +5980,68 @@ describe('MembersPage default member, memory and URL', () => { { route: '/elsewhere' }, ) fireEvent.click(screen.getByTestId('go-members')) - await rosterRow('oncall') - fireEvent.click((await screen.findAllByTestId('team-group-header'))[0]) - const view = await screen.findByTestId('team-view') - expect(currentUrl()).toBe('/members?team=abc123abc123') - fireEvent.click(within(view).getByTestId('team-edit')) - await screen.findByTestId('team-dialog-body') - fireEvent.change(screen.getByTestId('team-dialog-name'), { target: { value: 'Release' } }) - fireEvent.click(screen.getByTestId('team-dialog-save')) - await waitFor(() => expect(api.teams.update).toHaveBeenCalledTimes(1)) - await waitFor(() => expect(screen.queryByTestId('team-dialog-body')).toBeNull()) - expect(currentUrl()).toBe('/members?team=abc123abc123') - // The view's Back pops the pushed entry: the bare roster, still on the page. - fireEvent.click(screen.getByTestId('team-back')) - await waitFor(() => expect(currentUrl()).toBe('/members')) - expect(screen.queryByTestId('team-view')).toBeNull() - // One more Back: off the page -- the save did not stack a second roster entry. + expect(await screen.findByTestId('chat-pane-stub', undefined, PANE_READY)).toHaveTextContent('member-alpha') + await openRosterDrawer() + fireEvent.click(screen.getByTestId('history-back')) + await waitFor(() => expect(screen.queryByTestId('roster-drawer')).toBeNull(), { timeout: 3000 }) + expect(currentUrl()).toBe('/members?member=alpha') + expect(screen.getByTestId('chat-pane-stub')).toHaveTextContent('member-alpha') + // The drawer's entry is spent: the next Back is off the page. fireEvent.click(screen.getByTestId('history-back')) await waitFor(() => expect(currentUrl()).toBe('/elsewhere')) }) + it('a scrim tap closes the drawer and spends its entry without switching', async () => { + await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=alpha' }) + await screen.findByTestId('chat-pane-stub', undefined, PANE_READY) + await openRosterDrawer() + navigateSpy.mockClear() + fireEvent.click(screen.getByTestId('roster-drawer-backdrop')) + expect(navigateSpy).toHaveBeenCalledWith(-1) + await waitFor(() => expect(screen.queryByTestId('roster-drawer')).toBeNull(), { timeout: 3000 }) + expect(currentUrl()).toBe('/members?member=alpha') + }) + + it('a team header in the drawer opens the team view, and the view\'s Back slides the roster in again', async () => { + vi.mocked(api.teams.list).mockResolvedValue({ teams: [{ id: 'abc123abc123', name: 'Triage', members: ['alpha'] }] }) + await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=alpha' }) + await screen.findByTestId('chat-pane-stub', undefined, PANE_READY) + const drawer = await openRosterDrawer() + fireEvent.click((await within(drawer).findAllByTestId('team-group-header'))[0]) + await screen.findByTestId('team-view') + await waitFor(() => expect(currentUrl()).toBe('/members?team=abc123abc123')) + await waitFor(() => expect(screen.queryByTestId('roster-drawer')).toBeNull(), { timeout: 3000 }) + fireEvent.click(screen.getByTestId('team-back')) + expect(await screen.findByTestId('roster-drawer')).toBeTruthy() + expect(currentUrl()).toBe('/members?team=abc123abc123') + }) + + it('with a team open the guide sees the phone roster only while its drawer is open', async () => { + // The team view keeps the roster in the drawer, so a closed drawer is no + // roster on screen even though no crewmate is open. + vi.mocked(api.teams.list).mockResolvedValue({ teams: [{ id: 'abc123abc123', name: 'Triage', members: ['alpha'] }] }) + await renderPage(alphaBeta(), 'kirocrew', { route: '/members?team=abc123abc123' }) + await screen.findByTestId('team-view') + expect(screen.queryByTestId('roster-drawer')).toBeNull() + await waitFor(() => expect(scopeOpen('members.roster-phone')).toBe(false)) + fireEvent.click(screen.getByTestId('team-back')) + expect(await screen.findByTestId('roster-drawer')).toBeTruthy() + await waitFor(() => expect(scopeOpen('members.roster-phone')).toBe(true)) + }) + it('the guided flow takes the whole screen below md and Not now returns to the originating chat', async () => { await renderPage([row({ name: 'alpha', slug: 'alpha' }), defaultRow()], 'kirocrew', { route: '/members?member=alpha' }) expect(await screen.findByTestId('chat-pane-stub', undefined, PANE_READY)).toHaveTextContent('member-alpha') + // The roster's "+" lives in the drawer below md. + await openRosterDrawer() + navigateSpy.mockClear() await clickAddCrewmate() + // Opened on the drawer's own duplicate entry, so the close spends it. + await waitFor(() => expect(navigateSpy).toHaveBeenCalledWith(-1)) const pane = screen.getByTestId('member-create-pane') await waitFor(() => expect(pane.className).not.toMatch(/(^|\s)hidden(\s|$)/)) + // The creation surface retires the drawer and the roster yields with it. + await waitFor(() => expect(screen.queryByTestId('roster-drawer')).toBeNull(), { timeout: 3000 }) expect(screen.getByTestId('member-roster').className).toMatch(/(^|\s)hidden(\s|$)/) fireEvent.click(await within(pane).findByTestId('meet-crewmates-not-now')) await waitFor(() => expect(pane.className).toMatch(/(^|\s)hidden(\s|$)/)) @@ -5937,62 +6049,114 @@ describe('MembersPage default member, memory and URL', () => { expect(screen.getByTestId('chat-pane-stub')).toHaveTextContent('member-alpha') }) - it('a stale ?member= returns to the roster and says where the member went', async () => { - await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=ghost' }) - await rosterRow('alpha') - await waitFor(() => expect(currentUrl()).toBe('/members')) - expect(screen.queryByTestId('chat-pane-stub')).toBeNull() - expect(api.memberThread).not.toHaveBeenCalled() - // The roster is the answer surface here, so the notice sits above it. - const notice = screen.getByTestId('member-gone-roster-notice') - expect(notice).toHaveTextContent('“ghost” is no longer on the roster') - expect(notice).toHaveAttribute('role', 'status') - // Tapping a member retires it. - fireEvent.click(await rosterRow('beta')) - await waitFor(() => expect(screen.getByTestId('chat-pane-stub')).toHaveTextContent('member-beta'), PANE_READY) - expect(screen.queryByTestId('member-gone-roster-notice')).toBeNull() + it('a guide pushing the create link over the open drawer closes it without popping the guide\'s entry', async () => { + await renderPage([row({ name: 'alpha', slug: 'alpha' }), defaultRow()], 'kirocrew', { route: '/members?member=alpha' }) + await screen.findByTestId('chat-pane-stub', undefined, PANE_READY) + await openRosterDrawer() + navigateSpy.mockClear() + fireEvent.click(screen.getByTestId('guide-nav-granted')) + const pane = screen.getByTestId('member-create-pane') + await waitFor(() => expect(pane.className).not.toMatch(/(^|\s)hidden(\s|$)/)) + await waitFor(() => expect(screen.queryByTestId('roster-drawer')).toBeNull(), { timeout: 3000 }) + // The pop would have taken the guide's entry, not the drawer's duplicate. + expect(navigateSpy).not.toHaveBeenCalledWith(-1) }) - it('tapping a member opens it; the header back POPS the entry the roster pushed', async () => { - await renderPage(alphaBeta()) - fireEvent.click(await rosterRow('beta')) - expect(await screen.findByTestId('chat-pane-stub', undefined, PANE_READY)).toHaveTextContent('member-beta') - expect(currentUrl()).toBe('/members?member=beta') + /** A page before /members, so one Back can be seen leaving the page. */ + function renderFromElsewhere(go: { to: string; state?: unknown }) { + function Elsewhere() { + const nav = useNavigate() + return ( + + ) + } + function BackProbe() { + const nav = useNavigate() + return ( + + ) + } + renderWithProviders( + + + } /> + } /> + + + + , + { route: '/elsewhere' }, + ) + fireEvent.click(screen.getByTestId('go-members')) + } + + it('on the leave guard\'s own duplicate entry the drawer pushes and pops nothing, so the guard stays armed', async () => { + // NavigationBackGuard parks a duplicate entry marked as its trap while a + // draft is unsaved. A drawer entry above it would be popped back onto the + // trap on close, which the guard reads as a press to carry past. + ;(api.members as ReturnType).mockResolvedValue({ members: alphaBeta(), default_agent: 'kirocrew' }) + ;(api.memberThread as ReturnType).mockImplementation(echoThread) + renderFromElsewhere({ to: '/members?member=alpha', state: { __navigationLeaveTrap: true } }) + expect(await screen.findByTestId('chat-pane-stub', undefined, PANE_READY)).toHaveTextContent('member-alpha') navigateSpy.mockClear() - fireEvent.click(screen.getByTestId('member-back')) - // The entry was pushed from this page's roster, so back is a history - // pop — the browser's own Back afterwards does not land on a second, - // identical roster entry. - expect(navigateSpy).toHaveBeenCalledWith(-1) - // The memory survives the back gesture: the next desktop visit resumes here. - expect(localStorage.getItem(LAST_MEMBER_KEY)).toBe('beta') + await openRosterDrawer() + expect(navigateSpy).not.toHaveBeenCalled() + fireEvent.click(screen.getByTestId('roster-drawer-backdrop')) + await waitFor(() => expect(screen.queryByTestId('roster-drawer')).toBeNull(), { timeout: 3000 }) + expect(navigateSpy).not.toHaveBeenCalled() + expect(currentUrl()).toBe('/members?member=alpha') }) - it('from a deep link the header back drops the param in place — there is no roster entry behind it', async () => { - await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=beta' }) - expect(await screen.findByTestId('chat-pane-stub', undefined, PANE_READY)).toHaveTextContent('member-beta') - navigateSpy.mockClear() - fireEvent.click(screen.getByTestId('member-back')) - await waitFor(() => expect(screen.queryByTestId('chat-pane-stub')).toBeNull()) - expect(currentUrl()).toBe('/members') - expect(navigateSpy).not.toHaveBeenCalledWith(-1) + it('the first crewmate created from an empty roster opens on a replace, so one Back still leaves the page', async () => { + // A pushed open would leave a bare /members under the chat, and the phone + // lands a bare /members on a crewmate by itself: Back would bounce back in. + const membersMock = api.members as ReturnType + membersMock.mockResolvedValue({ members: [defaultRow()], default_agent: 'kirocrew' }) + ;(api.memberThread as ReturnType).mockImplementation(echoThread) + renderFromElsewhere({ to: '/members' }) + fireEvent.click((await screen.findAllByTestId('crewmate-empty-advanced'))[0]) + await screen.findByTestId('crewmate-create-form') + fireEvent.change(screen.getByLabelText('Name'), { target: { value: 'radar' } }) + membersMock.mockResolvedValue({ members: [defaultRow(), row({ name: 'radar', slug: 'radar' })], default_agent: 'kirocrew' }) + fireEvent.click(screen.getByTestId('crewmate-create-submit')) + await waitFor(() => expect(screen.getByTestId('chat-pane-stub')).toHaveTextContent('member-radar'), PANE_READY) + expect(currentUrl()).toBe('/members?member=radar') + fireEvent.click(screen.getByTestId('history-back')) + await waitFor(() => expect(currentUrl()).toBe('/elsewhere')) }) - it('leaving the thread with Profile open does not carry the card to the next crewmate', async () => { - // The phone's Back clears the member param; `profile` stayed non-null - // across it, so the next crewmate opened with the card already up. + it('a stale ?member= opens a stand-in with the notice above the chat, as on a wide window', async () => { + await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=ghost' }) + await screen.findByTestId('chat-pane-stub', undefined, PANE_READY) + expect(currentUrl()).not.toBe('/members?member=ghost') + expect(screen.getByTestId('member-gone-notice')).toHaveTextContent(/^Showing /) + expect(screen.queryByTestId('member-gone-roster-notice')).toBeNull() + }) + + it('switching from the drawer with Profile open does not carry the card to the next crewmate', async () => { await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=alpha' }) await screen.findByTestId('chat-pane-stub', undefined, PANE_READY) fireEvent.click(await screen.findByTestId('member-identity-pill')) await screen.findByTestId('crew-profile-modal') - fireEvent.click(screen.getByTestId('member-back')) - await waitFor(() => expect(currentUrl()).toBe('/members')) + await openRosterDrawer() fireEvent.click(await rosterRow('beta')) await waitFor(() => expect(screen.getByTestId('chat-pane-stub')).toHaveTextContent('member-beta'), PANE_READY) - expect(screen.queryByTestId('crew-profile-modal')).toBeNull() + // The card leaves through its exit animation. + await waitFor(() => expect(screen.queryByTestId('crew-profile-modal')).toBeNull(), { timeout: 3000 }) expect(screen.getByTestId('member-identity-pill')).toHaveAttribute('aria-expanded', 'false') }) + it('with nothing to open the roster is the page, and the page claims no drag', async () => { + await renderPage([defaultRow()], 'kirocrew') + await screen.findAllByTestId('crewmate-empty-hero') + expect(screen.queryByTestId('roster-drawer')).toBeNull() + expect(screen.getByTestId('members-page')).not.toHaveAttribute('data-owns-swipe') + }) + it('floats Profile instead of adding its fixed-width column on a 320px phone', async () => { setWindowWidth(320) await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=beta' }) @@ -6004,6 +6168,41 @@ describe('MembersPage default member, memory and URL', () => { expect(screen.queryByTestId('crew-profile-docked')).toBeNull() }) + it('the side panel first mounts offscreen, so a non-gesture open never paints it at rest before it slides in', async () => { + setWindowWidth(390) + await renderPage(alphaBeta(), 'kirocrew', { route: '/members?member=beta' }) + expect(await screen.findByTestId('chat-pane-stub', undefined, PANE_READY)).toHaveTextContent('member-beta') + // The transform the slide carries at the moment React inserts it, read + // synchronously inside the commit: before the open effect re-seats the + // offset, which for a non-discrete open runs only after a paint. + let mountedTransform: string | null = null + const capture = (n: Node) => { + if (mountedTransform !== null || !(n instanceof HTMLElement)) return + const slide = n.matches('[data-testid="member-side-panel-slide"]') + ? n + : n.querySelector('[data-testid="member-side-panel-slide"]') + if (slide) mountedTransform = slide.style.transform + } + const realAppend = Node.prototype.appendChild + const realInsert = Node.prototype.insertBefore + const append = vi.spyOn(Node.prototype, 'appendChild').mockImplementation(function (this: Node, n: T): T { + capture(n) + return realAppend.call(this, n) as T + }) + const insert = vi.spyOn(Node.prototype, 'insertBefore').mockImplementation(function (this: Node, n: T, ref: Node | null): T { + capture(n) + return realInsert.call(this, n, ref) as T + }) + try { + fireEvent.click(screen.getByTestId('member-panel-toggle')) + await screen.findByTestId('member-side-panel') + } finally { + append.mockRestore() + insert.mockRestore() + } + expect(mountedTransform).toMatch(/translate(X|3d)\(390px/) + }) + it('the overlay fills the phone: the panel is handed the window width, not left to a 100% it cannot resolve (#9979)', async () => { // 390 is the audit's phone frame. Below SIDE_PANEL_MIN_W the panel would // clamp up to its minimum instead; 390 is above it, so the width the @@ -6026,44 +6225,6 @@ describe('MembersPage default member, memory and URL', () => { // against when the panel already spans the window (the chat page's rule). expect(overlay.querySelector('[role="separator"][aria-orientation="vertical"]')).toBeNull() }) - - it('a greeting notice does not hide the roster below md once its chat is closed — only a roster failure has no chat to show', async () => { - const membersMock = api.members as ReturnType - const sendMock = api.sendChat as ReturnType - await renderPage([row()]) - // Below md nothing auto-opens: the roster is the screen until a tap. - await rosterRow('oncall') - await clickAddAdvanced() - await screen.findByTestId('crewmate-create-form') - fireEvent.change(screen.getByLabelText('Name'), { target: { value: 'radar' } }) - membersMock.mockResolvedValue({ - members: [row(), row({ name: 'radar', slug: 'radar' })], - default_agent: 'kirocrew', - }) - sendMock.mockResolvedValueOnce( - new Response(JSON.stringify({ error: 'slot busy' }), { status: 409, headers: { 'Content-Type': 'application/json' } }), - ) - fireEvent.click(screen.getByTestId('crewmate-create-submit')) - await waitFor(() => expect(screen.getByTestId('chat-pane-stub')).toHaveTextContent('member-radar'), PANE_READY) - await screen.findByTestId('member-post-create-error', undefined, PANE_READY) - // Chat open: the roster yields below md, as for any open chat. - expect(screen.getByTestId('member-roster').className).toMatch(/\bhidden\b/) - // The header back closes the chat. The greeting notice is still pending, - // but it sits over a chat that is now closed: the roster must be the - // screen again, not a notice bar over a blank column. - fireEvent.click(screen.getByTestId('member-back')) - await waitFor(() => expect(screen.queryByTestId('chat-pane-stub')).toBeNull()) - const aside = screen.getByTestId('member-roster') - expect(aside.className).not.toMatch(/\bhidden\b/) - // The retry is not lost, and not hidden with the chat column either: with - // no chat open the notice moves INTO the roster, where the "+" it holds - // sits, so its dismiss and "Send it again" are on the screen the user - // sees (Opus, round 43). One notice in the document, not one per column. - const notice = screen.getByTestId('member-post-create-error') - expect(aside).toContainElement(notice) - expect(screen.getAllByTestId('member-post-create-error')).toHaveLength(1) - expect(screen.getByTestId('member-post-create-retry')).toHaveTextContent('Send it again') - }) }) }) diff --git a/website/src/pages/members/MembersPage.tsx b/website/src/pages/members/MembersPage.tsx index ad0e72e97a1c..66a2811c3003 100644 --- a/website/src/pages/members/MembersPage.tsx +++ b/website/src/pages/members/MembersPage.tsx @@ -41,20 +41,23 @@ * whichever row the SORT floated to the top, and that still holds — the * default follows use, never the sort. Only a roster with no crewmate beyond * `default` opens nothing; - * it shows the New crewmate hero instead. Below md nothing auto-opens (the - * phone's two-level list rule) -- except Mate's one landing (see - * `resolveMateLanding`), which applies at every width. + * it shows the New crewmate hero instead. The phone lands the same way: there + * the roster is a drawer over the open chat (with the shell's navigation rail + * beside it, the chat page's sessions drawer), revealed by a rightward drag or + * the header's drawer toggle, while a leftward drag reveals the side panel. + * Mate's first-visit landing (see `resolveMateLanding`) runs ahead of all of + * this, at every width. * * Creating a crewmate happens in place of the chat: the guided flow (the * embedded Meet CrewMates flow) or the full form (Advanced), one at a time, * with the chat and side panel hidden but still MOUNTED. See `openGuided`. */ import { Fragment, lazy, Suspense, useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react' -import { useLocation, useNavigate, useSearchParams } from 'react-router-dom' +import { useLocation, useNavigate, useNavigationType, useSearchParams } from 'react-router-dom' import { ArrowLeft, Check, ChevronRight, Circle, Goal, LayoutDashboard, Loader2, MessageCircleQuestionMark, Plus, RotateCw, Square, Star, X, Zap } from 'lucide-react' import { usePreviewFlag } from '../../hooks/usePreviewFlag' import { PREVIEW_CREW, PREVIEW_DASHBOARD } from '../../utils/previewFlags' -import { PanelRightSolid } from '../../components/icons/panels' +import { PanelLeftLight, PanelLeftSolid, PanelRightSolid } from '../../components/icons/panels' import { Btn } from '../../components/ui' import { CrewMemberMark } from '../../components/CrewMemberMark' import NewCrewmateDialog, { type CreatedCrewmate } from './NewCrewmateDialog' @@ -160,7 +163,12 @@ import { type MemberSignals, type MemberSort, type MemberSourceFilter, type MemberStatusFilter, type RosterQuery, } from './rosterFilter' import { defaultAgentQuery } from '../../api/defaultAgentQuery' -import { AnimatePresence, animate, motion, useReducedMotion } from 'framer-motion' +import { AnimatePresence, animate, motion, useMotionValue, useReducedMotion, useTransform } from 'framer-motion' +import { useDrawerSwipe, animateDrawer, registerDrawerTargets, takeOverDrawer, safeAreaLeft } from '../../hooks/useDrawerSwipe' +import OverlayDrawer from '../../components/OverlayDrawer' +import { useMobileNavRail } from '../../components/MobileNavRailContext' +import { useVisualViewport } from '../../hooks/useVisualViewport' +import { isTrapEntry } from '../../lib/routeHistoryPosition' import { isSidePanelHidden, shouldMountSidePanel, sidePanelDockMotion } from '../chat/sidePanelMount' import SidePanel, { SIDE_PANEL_MIN_W, SIDE_PANEL_RESERVED_W, type SidePanelLeadingTab, type SidePanelWithholdable } from '../chat/SidePanel' import { useRailWidth } from '../../hooks/useRailWidth' @@ -384,6 +392,13 @@ export const MEMBERS_UNCONFIRMED_WITHHELD_VIEWS: readonly SidePanelWithholdable[ * The thread's own minimum is already inside the panel's shell reserve * (`SIDE_PANEL_RESERVED_W` budgets the nav rail plus a chat-pane minimum). */ const PANEL_GAPS_W = 24 +/** Strip of chat the phone roster drawer leaves uncovered beside it — the same + * 40px the chat page's sessions drawer leaves, so the two drawers match. */ +const ROSTER_DRAWER_UNCOVERED_PX = 40 +/** How long a drawer pick waits for the router to report the pop of the + * drawer's duplicate entry. Past it the pick is dropped, never run on the + * wrong entry. A pop normally lands within a frame or two. */ +const ROSTER_DRAWER_POP_TIMEOUT_MS = 1000 /** Whether the side panel can sit BESIDE the thread as a permanent column, * or must become an overlay the user opens. Beside needs the shell reserve * (nav rail + a usable thread) plus the live roster width plus the panel's @@ -1312,9 +1327,9 @@ export default function MembersPage() { // open, so its fields start from the team it was opened for. const [teamDialog, setTeamDialog] = useState<{ team?: CrewTeam } | null>(null) // Set when a URL NAMED a member that is gone: the user asked for someone - // specific, so the outcome is said out loud — above the fallback thread on - // md+ (`shown` = who opened instead), above the roster below md (`shown` is - // '' — no thread opened). The remembered-member fallback never sets it — + // specific, so the outcome is said out loud — above the fallback thread + // (`shown` = who opened instead), or above the roster when nothing could + // open in their place (`shown` is ''). The remembered-member fallback never sets it — // there the user named nobody. Cleared once a different member opens. const [gone, setGone] = useState<{ name: string; shown: string } | null>(null) // The full New crewmate form (Advanced: the "+" menu row and the hero's @@ -1587,10 +1602,12 @@ export default function MembersPage() { // roster is cached. Read as "nothing open", that frame drew the full roster // column and the next one folded it: the flash on every switch to this tab. // Treated as already folded until the open lands. Not pending once the - // effect can open no one: a failed read, an empty roster (the hero), a - // phone (no auto-open), or a team view. + // effect can open no one: a failed read, an empty roster (the hero), or a + // team view. A phone lands the same way, so it waits the same way: its + // roster would otherwise draw as the page for that frame, then slide into + // the drawer. const landingPending = - !isMobile && !activeName && !urlTeam && !loadError && !(loaded && hasNoCrewmates(members)) + !activeName && !urlTeam && !loadError && !(loaded && hasNoCrewmates(members)) const rosterFolded = (!!activeName || landingPending) && !rosterPinned const rosterShown = !rosterFolded // The switcher chip fades out while the pin holds (the column IS its list), @@ -1756,6 +1773,253 @@ export default function MembersPage() { window.addEventListener('toggle-activity-panel', onToggle) return () => window.removeEventListener('toggle-activity-panel', onToggle) }, [togglePanel]) + + /** + * Phone: the roster as a LEFT drawer over the open chat, the chat page's + * sessions drawer with the crewmate list in place of the session list. The + * drawer holds the shell's navigation rail (MobileNavRailContext) beside the + * roster, finger-tracks a rightward drag (`useDrawerSwipe`), and settles on + * the compositor (`registerDrawerTargets`). One phase value rather than an + * open flag plus a mounted flag: `closing` keeps the panel in the DOM for the + * slide out. Only while a chat or a team is open — with nothing open the + * roster IS the page and there is nothing to slide over. + */ + const [rosterDrawerPhase, setRosterDrawerPhase] = useState<'closed' | 'open' | 'closing'>('closed') + const rosterDrawerPhaseRef = useRef(rosterDrawerPhase) + rosterDrawerPhaseRef.current = rosterDrawerPhase + const rosterDrawerOpen = rosterDrawerPhase === 'open' + const rosterDrawerMounted = rosterDrawerPhase !== 'closed' + const rosterDrawerX = useMotionValue(0) + const rosterDrawerPanelRef = useRef(null) + const rosterDrawerScrimRef = useRef(null) + /** The element inside the drawer the roster aside is portaled into. State, + * not a ref, so the portal renders once the drawer has mounted it. */ + const [rosterDrawerHost, setRosterDrawerHost] = useState(null) + /** The shell's main navigation as a 72px rail, provided on a phone. */ + const mobileNavRail = useMobileNavRail() + // The drawer autofocuses nothing, but its roster search raises the software + // keyboard, and iOS Safari shrinks only the VISUAL viewport for it. Inset the + // drawer and its scrim to the visible band, as the chat page's drawer does, + // so the lower roster rows are not left behind the keyboard. Both terms are + // 0 at rest. + const vv = useVisualViewport() + const keyboardInset = + typeof window === 'undefined' ? 0 : Math.max(0, window.innerHeight - vv.offsetTop - vv.height) + /** The drawer's own width as its travel, plus the safe-area inset it is + * pinned behind — see ChatPage's `drawerTravel` for why the viewport width + * would leave the settle's tail playing offscreen. */ + const rosterDrawerTravel = useCallback( + () => Math.max(0, (window.innerWidth || 0) - ROSTER_DRAWER_UNCOVERED_PX + safeAreaLeft()), + [], + ) + const rosterDrawerScrim = useTransform(rosterDrawerX, (x) => + Math.max(0, Math.min(1, 1 + x / Math.max(1, rosterDrawerTravel())))) + // Safe only because the roster rows drop their `layout` projection while + // hosted in the drawer (`reduceMotion` is forced on there) — see + // registerDrawerTargets' precondition. + useEffect(() => registerDrawerTargets(rosterDrawerX, { + panel: () => rosterDrawerPanelRef.current, + scrim: () => rosterDrawerScrimRef.current, + travel: rosterDrawerTravel, + }), [rosterDrawerX, rosterDrawerTravel]) + /** + * The drawer's history entry, so the platform Back dismisses the drawer + * instead of leaving the crewmate. A bare duplicate of the entry below, held + * exactly while the drawer is open — the chat page's `pushDrawerEntry` rule. + */ + const rosterDrawerEntryRef = useRef(false) + /** The duplicate's own `location.key`, learnt on the render after the push, + * so a close can tell whether that entry is still the current one. */ + const rosterDrawerEntryKeyRef = useRef(null) + const locationRef = useRef(location) + locationRef.current = location + const pushRosterDrawerEntry = useCallback(() => { + if (!isMobile || rosterDrawerEntryRef.current) return + const loc = locationRef.current + // Standing on the leave guard's own duplicate (`NavigationBackGuard` arms + // one while a Profile schedule draft is unsaved): a drawer entry above it + // would be popped back ONTO that duplicate on close, which the guard reads + // as a press to carry on past, disarming it and letting the next Back drop + // the draft unasked. So no entry here: Back with the drawer open is then + // the guard's own question, and closing the drawer touches no history. + if (isTrapEntry(loc.state)) return + rosterDrawerEntryRef.current = true + rosterDrawerEntryKeyRef.current = null + navigate({ pathname: loc.pathname, search: loc.search, hash: loc.hash }) + }, [isMobile, navigate]) + useEffect(() => { + if (rosterDrawerEntryRef.current && rosterDrawerEntryKeyRef.current === null) { + rosterDrawerEntryKeyRef.current = location.key + } + }, [location.key]) + /** + * Spend the duplicate entry, then run `after` on the entry below it. + * + * A pick in the drawer changes `?member=`, and the pop has to land FIRST: a + * replace written onto the duplicate would be popped straight off again, + * reopening the crewmate the user just left. So `after` runs ONLY from the + * router's report of that pop (the POP effect below), never ahead of it. A + * pop that never reports within the window drops the pick instead of + * running it on the wrong entry: the drawer is closed and the user taps + * again, which then needs no pop at all. + */ + const afterRosterDrawerPopRef = useRef<(() => void) | null>(null) + const afterRosterDrawerPopTimerRef = useRef(undefined) + const runAfterRosterDrawerPop = useCallback(() => { + const after = afterRosterDrawerPopRef.current + afterRosterDrawerPopRef.current = null + window.clearTimeout(afterRosterDrawerPopTimerRef.current) + after?.() + }, []) + useEffect(() => () => window.clearTimeout(afterRosterDrawerPopTimerRef.current), []) + const consumeRosterDrawerEntry = useCallback((after?: () => void) => { + if (!rosterDrawerEntryRef.current) { after?.(); return } + rosterDrawerEntryRef.current = false + if (after) { + afterRosterDrawerPopRef.current = after + window.clearTimeout(afterRosterDrawerPopTimerRef.current) + afterRosterDrawerPopTimerRef.current = window.setTimeout(() => { + afterRosterDrawerPopRef.current = null + }, ROSTER_DRAWER_POP_TIMEOUT_MS) + } + navigate(-1) + }, [navigate]) + const openRosterDrawer = useCallback(() => { + if (rosterDrawerPhaseRef.current === 'open') return + if (rosterDrawerPhaseRef.current === 'closed') rosterDrawerX.set(-rosterDrawerTravel()) + rosterDrawerPhaseRef.current = 'open' + setRosterDrawerPhase('open') + takeOverDrawer(rosterDrawerX) + animateDrawer(rosterDrawerX, 0) + pushRosterDrawerEntry() + }, [rosterDrawerX, rosterDrawerTravel, pushRosterDrawerEntry]) + /** The close animation alone: the Back that closes the drawer already spent + * the entry, so it must not spend another. */ + const runRosterDrawerClose = useCallback(() => { + if (rosterDrawerPhaseRef.current !== 'open') return false + rosterDrawerPhaseRef.current = 'closing' + setRosterDrawerPhase('closing') + takeOverDrawer(rosterDrawerX) + animateDrawer(rosterDrawerX, -rosterDrawerTravel(), () => { + rosterDrawerPhaseRef.current = 'closed' + setRosterDrawerPhase('closed') + }) + return true + }, [rosterDrawerX, rosterDrawerTravel]) + const closeRosterDrawer = useCallback((after?: () => void) => { + runRosterDrawerClose() + consumeRosterDrawerEntry(after) + }, [runRosterDrawerClose, consumeRosterDrawerEntry]) + // A Back that lands on the entry below the drawer's closes the drawer and + // stays on the crewmate; a pop this page issued for a drawer pick carries the + // pick out now that it has landed. `location.key`, so it runs once per entry. + const navigationType = useNavigationType() + useEffect(() => { + if (navigationType !== 'POP') return + if (afterRosterDrawerPopRef.current) { runAfterRosterDrawerPop(); return } + if (!rosterDrawerEntryRef.current || rosterDrawerPhaseRef.current !== 'open') return + rosterDrawerEntryRef.current = false + runRosterDrawerClose() + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [location.key, navigationType]) + /** Mount the drawer for a drag in progress, without the settle that would + * race the finger; the entry is minted where the gesture commits. */ + const beginRosterDrawerDrag = useCallback(() => { + rosterDrawerPhaseRef.current = 'open' + setRosterDrawerPhase('open') + }, []) + + /** + * Phone: the side panel's overlay slides in from the RIGHT on the same + * finger-tracked, compositor-settled path, so a leftward drag over the chat + * opens it — the chat page's right-hand overlay. On a phone the overlay is + * the full window wide, so it carries no scrim of its own. The offset starts + * offscreen: an open that is not a discrete event (a document read, a + * resolved guard) runs the seating effect below only after a paint, and the + * panel must not show at rest for that frame. + */ + const sidePanelX = useMotionValue(typeof window !== 'undefined' ? window.innerWidth : 0) + const sidePanelSlideRef = useRef(null) + const [sidePanelPhase, setSidePanelPhase] = useState<'closed' | 'open' | 'closing'>('closed') + const sidePanelPhaseRef = useRef(sidePanelPhase) + sidePanelPhaseRef.current = sidePanelPhase + const sidePanelTravel = useCallback(() => window.innerWidth || 0, []) + useEffect(() => registerDrawerTargets(sidePanelX, { + panel: () => sidePanelSlideRef.current, + scrim: () => null, + travel: sidePanelTravel, + }), [sidePanelX, sidePanelTravel]) + const overlayOpenRef = useRef(overlayOpen) + overlayOpenRef.current = overlayOpen + // Slide in when the overlay is wanted, out (mounted for the travel) when it + // stops being wanted. A gesture that already carried the panel to rest has + // set the phase first, so this does not run a second settle over it. + useEffect(() => { + if (!isMobile) { + sidePanelPhaseRef.current = 'closed' + setSidePanelPhase('closed') + takeOverDrawer(sidePanelX) + return + } + if (overlayOpen) { + if (sidePanelPhaseRef.current === 'open') return + if (sidePanelPhaseRef.current === 'closed') sidePanelX.set(sidePanelTravel()) + sidePanelPhaseRef.current = 'open' + setSidePanelPhase('open') + takeOverDrawer(sidePanelX) + animateDrawer(sidePanelX, 0) + } else { + if (sidePanelPhaseRef.current !== 'open') return + sidePanelPhaseRef.current = 'closing' + setSidePanelPhase('closing') + takeOverDrawer(sidePanelX) + animateDrawer(sidePanelX, sidePanelTravel(), () => { + sidePanelPhaseRef.current = 'closed' + setSidePanelPhase('closed') + }) + } + }, [isMobile, overlayOpen, sidePanelX, sidePanelTravel]) + const beginSidePanelDrag = useCallback(() => { + sidePanelPhaseRef.current = 'open' + setSidePanelPhase('open') + }, []) + /** + * Phone: replay a drag that began over a frame in the open side panel onto the + * frame element, so the panel's closing gesture can follow it. + * + * The Dashboard tab is a sandboxed iframe, and a touch on one goes to the + * frame's own document, never to this page. Its document relays its touches + * (`relayTouches`, see FRAME_TOUCH_RELAY_BODY in lib/widgetSrcdoc), and they + * are dispatched here as touch events on the frame element, whose ancestors + * carry the swipe listeners. Accepted only from a frame inside the open panel + * and only while it is open, which is when the one gesture they can drive is + * the panel's own close: the frame's script can post the same shape, and this + * keeps that from reaching anything else. + */ + useEffect(() => { + if (!isMobile) return + const types = { start: 'touchstart', move: 'touchmove', end: 'touchend', cancel: 'touchcancel' } as const + const onMessage = (event: MessageEvent) => { + const d = event.data as { type?: unknown; phase?: unknown; x?: unknown; y?: unknown } | null + if (!d || d.type !== 'mc-frame-touch') return + if (sidePanelPhaseRef.current !== 'open') return + const type = typeof d.phase === 'string' ? types[d.phase as keyof typeof types] : undefined + if (!type || typeof d.x !== 'number' || typeof d.y !== 'number' || !Number.isFinite(d.x) || !Number.isFinite(d.y)) return + const panel = sidePanelSlideRef.current + if (!panel) return + const frame = Array.from(panel.querySelectorAll('iframe')).find((f) => f.contentWindow === event.source) + if (!frame) return + const box = frame.getBoundingClientRect() + const touch = { clientX: box.left + d.x, clientY: box.top + d.y } + const ev = new Event(type, { bubbles: true }) + const lifted = type === 'touchend' || type === 'touchcancel' + Object.defineProperty(ev, 'touches', { value: lifted ? [] : [touch] }) + Object.defineProperty(ev, 'changedTouches', { value: [touch] }) + frame.dispatchEvent(ev) + } + window.addEventListener('message', onMessage) + return () => window.removeEventListener('message', onMessage) + }, [isMobile]) // Live presence rides the already-subscribed WS `slots` frames — the roster // endpoint only fills the cold-start gap (its `running` is a snapshot). const liveSlots = useAppSelector((s) => s.dashboard.slots) @@ -1801,12 +2065,108 @@ export default function MembersPage() { // Guide facts: the roster picker's selection (whether a crewmate is open and // whether any exists, never which), and whether the roster is shown, per // layout: folded into the switcher on a wide screen (`members.roster`), - // behind the open chat on a phone (`members.roster-phone`). + // behind the open chat on a phone, in the roster drawer (`members.roster-phone`). useGuideSelection('crewmate_selected', { selected: !!active, available: loaded && !hasNoCrewmates(members), name: active?.name }) // The header "Add…" menu is drawn once the roster has a crewmate. useGuidePredicate('has_crewmates', loaded ? !hasNoCrewmates(members) : null) useGuideRevealScope(isMobile ? undefined : 'members.roster', rosterShown) - useGuideRevealScope(isMobile ? 'members.roster-phone' : undefined, !activeName) + + // The phone drawers bind on the page root: a rightward drag reveals the + // roster drawer, a leftward one the side panel. Told apart by DIRECTION, and + // each is off while the other's panel is OPEN, because one's closing drag is + // the other's opening drag. The roster drawer exists only while something is + // open over the roster; the side panel only while a crewmate is. + const membersRootRef = useRef(null) + const rosterDrawerAvailable = isMobile && !!(activeName || activeTeam) && !guided.open && !createOpen + const sidePanelSwipeAvailable = isMobile && !!active && !guided.open && !createOpen + // Shown exactly where `placeRoster` draws it: on the page while no drawer + // exists, in the drawer only while it is open. A team keeps the drawer too, + // so `!activeName` alone would claim a roster that is not on screen. + useGuideRevealScope(isMobile ? 'members.roster-phone' : undefined, !rosterDrawerAvailable || rosterDrawerOpen) + /** The roster aside's home: the drawer while it is the roster's place, the + * page otherwise. Nothing renders while the drawer is closed — the chat is + * the screen then. */ + const placeRoster = (aside: React.ReactElement) => { + if (!rosterDrawerAvailable) return aside + return rosterDrawerMounted && rosterDrawerHost ? createPortal(aside, rosterDrawerHost) : null + } + const rosterDrawerDragging = useDrawerSwipe(membersRootRef, { + enabled: rosterDrawerAvailable && sidePanelPhase !== 'open', + travel: rosterDrawerTravel, + open: rosterDrawerOpen, + x: rosterDrawerX, + onGestureOpen: beginRosterDrawerDrag, + // The entry stands for intent, so it is minted and spent where the gesture + // commits, not when the slide arrives (ChatPage's sessions drawer). + onCommit: (open) => { + if (open) { pushRosterDrawerEntry(); return } + rosterDrawerPhaseRef.current = 'closing' + setRosterDrawerPhase('closing') + consumeRosterDrawerEntry() + }, + onSettle: (open) => { + if (open) return + rosterDrawerPhaseRef.current = 'closed' + setRosterDrawerPhase('closed') + }, + }) + useDrawerSwipe(membersRootRef, { + enabled: sidePanelSwipeAvailable && rosterDrawerPhase !== 'open', + side: 'right', + open: sidePanelPhase === 'open', + x: sidePanelX, + onGestureOpen: beginSidePanelDrag, + onCommit: (open) => { + if (open) return + sidePanelPhaseRef.current = 'closing' + setSidePanelPhase('closing') + }, + onSettle: (open) => { + // Committed open: publish it, so the panel stays across a re-render. The + // slide effect sees a phase already at 'open' and does not re-animate. + if (open) { setOverlayOpen(true); return } + // Parked: 'closed' first, so the effect does not run a second slide-out, + // and the flag is only flipped when the overlay really was open — an + // opening drag that was reconsidered never set it. + sidePanelPhaseRef.current = 'closed' + setSidePanelPhase('closed') + if (overlayOpenRef.current) setOverlayOpen(false) + }, + }) + // A crewmate or team opened (from the drawer or anywhere else), or a creation + // surface taking the column, retires the drawer. An open that came through a + // drawer pick has already closed it and spent its entry; any other leaves the + // entry behind as a plain step back to where the user was. + useEffect(() => { + if (rosterDrawerPhaseRef.current !== 'open') return + rosterDrawerEntryRef.current = false + runRosterDrawerClose() + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [activeName, urlTeam]) + useEffect(() => { + // A "+" in the drawer opens the flow on the drawer's own duplicate entry, so + // it is spent like any close. A guide opens it by PUSHING its create link + // over that duplicate: popping then would take the guide's entry instead, + // so the duplicate stays as a plain step back, the way an open from outside + // the drawer leaves it (the effect above). + if (!(guided.open || createOpen) || rosterDrawerPhaseRef.current !== 'open') return + if (rosterDrawerEntryRef.current && locationRef.current.key === rosterDrawerEntryKeyRef.current) { + closeRosterDrawer() + return + } + rosterDrawerEntryRef.current = false + runRosterDrawerClose() + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [guided.open, createOpen]) + // Leaving the phone viewport drops the drawer with no slide; the desktop + // roster is a column, so an entry standing for an open drawer goes with it. + useEffect(() => { + if (isMobile) return + rosterDrawerPhaseRef.current = 'closed' + setRosterDrawerPhase('closed') + consumeRosterDrawerEntry() + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [isMobile]) // The profile card (opened from the header pill) holds the Permissions row a // "crewmate tools" guide points at (`members.permissions`). useGuideRevealScope('members.profile', !!profile) @@ -2571,6 +2931,11 @@ export default function MembersPage() { const mountInput = { activityOpen: panelVisible, hasLiveAppTab, hasBrowserTab, hasTaskDashboard, searchOpen: false } const panelMounted = shouldMountSidePanel(mountInput) const panelHidden = isSidePanelHidden(mountInput) + // Phone: the slide owns the overlay's presence. It stays mounted and shown + // while a drag is revealing it or a close is still carrying it out, which + // the open flag alone cannot say. + const sidePanelOnScreen = isMobile ? panelMounted || sidePanelPhase !== 'closed' : panelMounted + const sidePanelHiddenNow = isMobile ? panelHidden && sidePanelPhase === 'closed' : panelHidden // File / artifact / save for the panel's Files, Artifacts and document tabs — // the chat page's own implementation, not a copy. A failed read is reported // above the thread; an open reveals whichever placement is live, since the @@ -3210,25 +3575,13 @@ export default function MembersPage() { return true } const go = () => { - if (urlMember || !isMobile) { - // Switching between members while one is open REPLACES the entry, and - // so does opening one above md, where the roster and the thread sit - // side by side and an open is not a navigation step. Either way the - // page holds one history entry however many members are visited and - // Back leaves it in one press — the Sessions sidebar's rule. The - // breakpoint is named directly because the desktop half used to ride - // on `urlMember` always being set by the arrival auto-open: an EMPTY - // roster leaves the URL bare (nothing to open), and the open that - // follows the first create must still replace. - setSearchParams({ [MEMBER_PARAM]: m.name }, { replace: true }) - return - } - // Entering a thread from the roster below md — the one place where the - // roster IS the page and no member is open — is a step in a two-level - // navigation, so it is PUSHED. The state marks the entry as pushed from - // this page's roster, which is what lets the below-md back button pop - // instead of replace. - setSearchParams({ [MEMBER_PARAM]: m.name }, { state: { fromRoster: true } }) + // Opening a crewmate REPLACES the entry at every width: the page holds + // one history entry however many crewmates are visited, and Back leaves + // it in one press — the Sessions sidebar's rule. A phone included: its + // bare `/members` lands on a crewmate by itself, so a pushed step back + // to it would bounce straight back into that crewmate and Back could + // never leave the page. + setSearchParams({ [MEMBER_PARAM]: m.name }, { replace: true }) } // A switch to ANOTHER crewmate remounts the Schedules section (it is keyed on the // crewmate), so it destroys an open create form just as leaving the tab does. It @@ -3239,8 +3592,13 @@ export default function MembersPage() { if (ok) go() return ok }, - [activeName, urlMember, isMobile, activate, setSearchParams, leaveGuided], + [activeName, activate, setSearchParams, leaveGuided], ) + /** A roster row picked in the phone drawer: close the drawer and spend its + * history entry FIRST, then open — see `consumeRosterDrawerEntry`. */ + const pickFromRosterDrawer = useCallback((m: MemberRosterRow) => { + closeRosterDrawer(() => { void openMember(m) }) + }, [closeRosterDrawer, openMember]) // The seeded first turn of a just-created crewmate's chat. The receipt is // read, not dropped — but only a REFUSED send is said and retried: the @@ -3364,12 +3722,9 @@ export default function MembersPage() { // crewmate that is gone (deleted or renamed) falls back the same way, with // a one-line notice above the chat naming the swap — the user asked for // someone specific, and a silently mounted other chat is the misroute this - // page exists to prevent. Below md the page is a two-level list->detail - // navigation: no `?member=` IS the roster, so no auto-open there (same rule - // as SidePanelLayout's remembered tab), and a gone crewmate in the URL - // returns to the roster instead of bouncing the phone user into a different - // crewmate's chat. Mate's first-visit landing is the one exception, once - // per page mount, so the phone's Back to the roster stays on the roster. + // page exists to prevent. The phone follows the same rule: its roster is a + // drawer over the open chat (the chat page's sessions drawer), so landing on + // a crewmate costs it nothing and Back is not a step back to a list. useEffect(() => { if (!loaded || loadError) return if (urlMember) { @@ -3422,27 +3777,13 @@ export default function MembersPage() { return } } - if (isMobile) { - if (urlMember) { - // No thread to fall back to below md — the roster is the answer, so - // say where the member went above the list (shown: '' marks the - // roster variant of the notice). - setGone((prev) => - prev && prev.name === urlMember && prev.shown === '' ? prev : { name: urlMember, shown: '' }, - ) - setSearchParams({}, { replace: true }) - } else if (activeName) { - activeNameRef.current = '' - setActiveName('') - } - return - } - // Desktop, URL names no crewmate (or names a gone one): restore the - // remembered crewmate if it is still on the roster, else open the one last - // chatted with, else the most recently used listed one. `undefined` here - // means nothing is listed — the chat column shows the New crewmate hero - // instead (or, with only hidden rows, stays empty until a search or a - // link names one). + // URL names no crewmate (or names a gone one): restore the remembered + // crewmate if it is still on the roster, else open the one last chatted + // with, else the most recently used listed one — at every width, the + // phone included, where the roster is a drawer over the open chat rather + // than a page of its own. `undefined` here means nothing is listed — the + // chat column shows the New crewmate hero instead (or, with only hidden + // rows, stays empty until a search or a link names one). // The fallback reads the LISTED rows, and the listing rule exempts the // default crew by name: until the default-crew read has settled (data or // a terminal error) the remembered crewmate may be that unlisted default, @@ -3468,16 +3809,16 @@ export default function MembersPage() { resolveDefaultMember(orderedMembers) if (!target) { // Named a gone crewmate on an empty roster: say where they went above - // the roster (shown: '' marks the roster variant of the notice, as - // below md) and clear the URL back to the bare list. + // the roster (shown: '' marks the roster variant of the notice) and + // clear the URL back to the bare list. if (urlMember) { setGone((prev) => prev && prev.name === urlMember && prev.shown === '' ? prev : { name: urlMember, shown: '' }, ) setSearchParams({}, { replace: true }) } - // Nothing to open means nothing may STAY open — the same clear the - // below-md branch does: a chat can still be mounted for a crewmate the + // Nothing to open means nothing may STAY open: a chat can still be + // mounted for a crewmate the // roster no longer lists (deleted while open), and returning to a bare // `/members` from there (the crew editor's exit, the rail's Crewmates // row) would otherwise leave that chat standing over a URL that names @@ -3645,7 +3986,56 @@ export default function MembersPage() { // in its transcripts draws the right-dock pane. -
+
+ {isMobile && ( + <> + + {rosterDrawerMounted && ( + { if (!rosterDrawerDragging) closeRosterDrawer() }} + /> + )} + + +
+ {mobileNavRail?.({ onActivate: () => closeRosterDrawer() })} + {/* The roster aside is portaled in here (`placeRoster`), with the + card chrome reset the way the sessions drawer resets its pane. */} +
+
+ + + )} {/* Card columns (roster + thread) keep the page's original insets. */}
{/* Member list. Below md the page is single-pane: the roster IS the @@ -3656,7 +4046,7 @@ export default function MembersPage() { own recipes (components/listShell) so the two conversation lists read as one surface — including the kiro-light shell hook that steps the card back from the white canvas. */} - + )} {/* DM thread */}
setTeamDialog({ team: activeTeam })} - onBack={closeTeamView} + onBack={rosterDrawerAvailable ? openRosterDrawer : closeTeamView} /> )} @@ -4318,12 +4719,15 @@ export default function MembersPage() { as="button" variant="chip" radius={999} - // Back to the roster. When this entry was pushed from the - // roster on this page, pop it — the browser's own Back then - // lands on whatever preceded the roster, with no duplicate - // roster entry. A deep link (no such state) has no roster - // entry behind it, so drop the param in place instead. + // Back to the roster. On a phone the roster is the drawer over + // this chat, so the control slides it in and nothing unmounts. + // Otherwise, when this entry was pushed from the roster on + // this page, pop it — the browser's own Back then lands on + // whatever preceded the roster, with no duplicate roster + // entry. A deep link (no such state) has no roster entry + // behind it, so drop the param in place instead. onClick={() => { + if (rosterDrawerAvailable) { openRosterDrawer(); return } const go = () => { if ((location.state as { fromRoster?: boolean } | null)?.fromRoster) navigate(-1) else setSearchParams({}, { replace: true }) @@ -4338,11 +4742,16 @@ export default function MembersPage() { void schedGuardRef.current().then((ok) => { if (ok) go() }) }} className="md:hidden glass-hover inline-flex items-center justify-center w-8 h-8 rounded-full text-text cursor-pointer" - aria-label={t('pages.membersPage.back_to_roster')} + aria-label={t('pages.membersPage.toggle_roster')} data-testid="member-back" + aria-expanded={rosterDrawerAvailable ? rosterDrawerOpen : undefined} {...uiLocation('members.back')} > - + {/* On a phone this opens the roster drawer, so it wears the + Sessions page's own drawer toggle, not a back arrow. */} + {rosterDrawerAvailable + ? (rosterDrawerOpen ? : ) + : }
{/* The identity pill is one centred Glass chip holding the face, @@ -5233,11 +5642,15 @@ export default function MembersPage() { // sidePanelDockMotion for why an axis left out of `animate` freezes. const outerMotion = beside ? dockMotion - : { - initial: { opacity: 0, width: 'auto', height: '100%' }, - animate: { opacity: 1, width: 'auto', height: '100%' }, - exit: { opacity: 0, width: 'auto', height: '100%' }, - } + : isMobile + // Phone: the inner slide is the whole motion and the panel fills + // the window, so the outer neither fades nor dims. + ? { initial: false as const, animate: { opacity: 1 }, exit: { opacity: 1 } } + : { + initial: { opacity: 0, width: 'auto', height: '100%' }, + animate: { opacity: 1, width: 'auto', height: '100%' }, + exit: { opacity: 0, width: 'auto', height: '100%' }, + } const innerMotion = beside ? { initial: { x: 0 }, animate: { x: 0 }, exit: { x: 0 } } : { initial: { x: '100%' }, animate: { x: 0 }, exit: { x: '100%' } } @@ -5250,7 +5663,7 @@ export default function MembersPage() { {dockedSurface} {profileDocked ? null : profileSurface} - {panelMounted && ( + {sidePanelOnScreen && ( { if (e.target === e.currentTarget) requestCloseOverlay() }} @@ -5275,11 +5690,14 @@ export default function MembersPage() { data-placement={beside ? 'docked' : 'overlay'} > {/* The open reply thread covers the panel's tabs while it is on screen and slides away on close, so the tabs the user had are @@ -5309,7 +5727,7 @@ export default function MembersPage() { ({ default: ChatPageStub, })) vi.mock('../pages/SettingsPage', () => ({ default: () =>
SettingsPage
})) +/** Records the host drawer's close, so a case can tell a close from a navigation. */ +const membersRailActivate = vi.hoisted(() => ({ calls: 0, mayLeave: true })) +function MembersPageStub() { + const rail = useMobileNavRail() + // Stands in for the page's unsaved-draft guard (a Profile schedule form). + useRegisterNavigationLeaveGuard(() => membersRailActivate.mayLeave) + const loc = useLocation() + return ( +
+ {rail ? rail({ onActivate: () => { membersRailActivate.calls += 1 } }) : } +
+ ) +} +vi.mock('../pages/members/MembersPage', () => ({ default: MembersPageStub })) vi.mock('../hooks/useWebSocket', () => ({ useWebSocket: () => ({ subscribeLogs: () => {} }) })) vi.mock('../hooks/useAgents', () => ({ useAgents: vi.fn(() => ({ agents: [{ name: 'kirocrew' }], defaultAgent: 'kirocrew' })) })) vi.mock('../providers/context', () => ({ useProvider: () => ({ id: 'acp' }) })) @@ -88,6 +104,8 @@ Object.defineProperty(window, 'matchMedia', { globalThis.ResizeObserver = class { observe() {} unobserve() {} disconnect() {} } as typeof ResizeObserver const header = () => document.querySelector('header.topbar') as HTMLElement +/** Ceiling for a wait behind App's React.lazy route boundary. */ +const LAZY_ROUTE = { timeout: 5000 } const flowChildren = (el: HTMLElement) => [...el.children].filter(c => !c.className.includes('absolute')) describe('phone chat page: one top bar', () => { @@ -210,6 +228,30 @@ describe('phone chat page: one top bar', () => { expect(screen.queryByTestId('mobile-nav-rail')).toBeNull() }) + it('hands the Crewmates page the same rail for its roster drawer; Home asks the page before leaving', async () => { + localStorage.setItem('mc-onboarded', '1') + membersRailActivate.calls = 0 + membersRailActivate.mayLeave = false + renderWithProviders(, { route: '/members?member=alpha' }) + // `/members` is a React.lazy route: the stub (and the rail it renders) only + // appears once that chunk resolves, so the wait names its own ceiling. + const rail = await screen.findByTestId('mobile-nav-rail', undefined, LAZY_ROUTE) + expect(screen.getByTestId('members-page-stub')).toContainElement(rail) + // The page draws its own title row, so the shell keeps its regular bar. + expect(header()).not.toHaveClass('topbar-single') + // Home leaves for the chat root WITHOUT closing the host drawer first: that + // close pops the drawer's duplicate entry, which would land after the + // replace and carry the user back to the crewmate. + // A draft the page's leave guard refuses to drop keeps the user on the page. + fireEvent.click(within(rail).getByTestId('mobile-nav-rail-home')) + expect(screen.getByTestId('members-page-stub')).toBeInTheDocument() + membersRailActivate.mayLeave = true + fireEvent.click(within(rail).getByTestId('mobile-nav-rail-home')) + // Leaving swaps in the lazy `/chat` route, behind the same boundary. + await waitFor(() => expect(screen.queryByTestId('members-page-stub')).toBeNull(), LAZY_ROUTE) + expect(membersRailActivate.calls).toBe(0) + }) + it('shows a reconnecting strip under the bar while the socket is down, since the phone has no capsule dot', async () => { localStorage.setItem('mc-onboarded', '1') const { store } = renderWithProviders(, { route: '/settings' }) diff --git a/website/src/test/mobilePanels.compositor.test.ts b/website/src/test/mobilePanels.compositor.test.ts index d62a96a71825..59db3b2a1984 100644 --- a/website/src/test/mobilePanels.compositor.test.ts +++ b/website/src/test/mobilePanels.compositor.test.ts @@ -28,6 +28,7 @@ import { resolve } from 'node:path' const app = readFileSync(resolve(__dirname, '../App.tsx'), 'utf8') const chat = readFileSync(resolve(__dirname, '../pages/ChatPage.tsx'), 'utf8') +const members = readFileSync(resolve(__dirname, '../pages/members/MembersPage.tsx'), 'utf8') const hook = readFileSync(resolve(__dirname, '../hooks/useDrawerSwipe.ts'), 'utf8') describe('mobile nav drawer (left) — compositor pairing', () => { @@ -287,7 +288,7 @@ describe('a panel with a gesture is bound LIVE to its offset', () => { // The d // arm on one touch. App.tsx is the shell instance itself, so it declares // nothing — everyone else must. A new page that adds a drawer gesture and // forgets the attribute trips this rather than shipping a fight. - const consumers = { 'App.tsx': app, 'ChatPage.tsx': chat } + const consumers = { 'App.tsx': app, 'ChatPage.tsx': chat, 'MembersPage.tsx': members } for (const [name, src] of Object.entries(consumers)) { if (!/useDrawerSwipe\(/.test(src)) continue const isShellInstance = /useDrawerSwipe\(shellRef, \{/.test(src) diff --git a/website/src/test/widgetSrcdocTouchRelay.test.tsx b/website/src/test/widgetSrcdocTouchRelay.test.tsx new file mode 100644 index 000000000000..72d49d728940 --- /dev/null +++ b/website/src/test/widgetSrcdocTouchRelay.test.tsx @@ -0,0 +1,97 @@ +/** Executes the REAL frame touch relay -- extracted from buildSrcdoc's own + * output, not a copy -- against a live document, and pins the contract: + * + * A frame built with `relayTouches` reports each single-finger touch to its + * parent as `{type: 'mc-frame-touch', phase, x, y}`, so a host drawer can + * follow a drag that began over the frame. It stays silent for a touch the + * frame's own content owns (a horizontal scroller, an editable) and cancels on + * a second finger. A frame built without the option carries no relay. + */ +import { describe, it, expect, beforeAll, afterEach } from 'vitest' +import { buildSrcdoc } from '../lib/widgetSrcdoc' + +const MARK = 'mc-frame-touch' + +function relayScript(out: string): string | undefined { + const doc = new DOMParser().parseFromString(out, 'text/html') + return Array.from(doc.querySelectorAll('script')) + .map((s) => s.textContent ?? '') + .find((t) => t.includes(MARK)) +} + +const posted: Array<{ type: string; phase: string; x: number; y: number }> = [] + +/** A touch event carrying the given live and changed touch points. */ +function touch(type: string, target: Element, points: Array<[number, number]>, changed = points) { + const ev = new Event(type, { bubbles: true }) + const toTouch = ([x, y]: [number, number]) => ({ clientX: x, clientY: y }) + Object.defineProperty(ev, 'touches', { value: points.map(toTouch) }) + Object.defineProperty(ev, 'changedTouches', { value: changed.map(toTouch) }) + target.dispatchEvent(ev) +} + +describe('frame touch relay', () => { + beforeAll(() => { + const script = relayScript(buildSrcdoc({ html: '

probe

', themeVars: {}, mode: 'dark', relayTouches: true })) + if (!script) throw new Error('touch relay not found in srcdoc') + // `parent` is the relay's only outward channel; stand it in with a recorder. + // Installed once: its listeners live on this test window for the whole file. + new Function('parent', script)({ postMessage: (msg: (typeof posted)[number]) => posted.push(msg) }) + }) + afterEach(() => { + posted.length = 0 + document.querySelectorAll('[data-relay-host]').forEach((n) => n.remove()) + }) + + const host = () => { + const el = document.createElement('div') + el.setAttribute('data-relay-host', '') + document.body.appendChild(el) + return el + } + + it('is injected only when the host asks for it, ahead of the page body', () => { + expect(relayScript(buildSrcdoc({ html: '

x

', themeVars: {}, mode: 'dark' }))).toBeUndefined() + const out = buildSrcdoc({ html: '

x

', themeVars: {}, mode: 'dark', relayTouches: true }) + expect(out.indexOf(MARK)).toBeGreaterThan(-1) + expect(out.indexOf(MARK)).toBeLessThan(out.indexOf('id="llm"')) + }) + + it('reports a one-finger drag as start, move and end in frame coordinates', () => { + const el = host() + touch('touchstart', el, [[40, 300]]) + touch('touchmove', el, [[200, 302]]) + touch('touchend', el, [], [[200, 302]]) + expect(posted).toEqual([ + { type: MARK, phase: 'start', x: 40, y: 300 }, + { type: MARK, phase: 'move', x: 200, y: 302 }, + { type: MARK, phase: 'end', x: 200, y: 302 }, + ]) + }) + + it('stays silent for a touch inside a horizontal scroller or an editable', () => { + const el = host() + const scroller = document.createElement('div') + scroller.style.overflowX = 'auto' + Object.defineProperty(scroller, 'scrollWidth', { value: 800 }) + Object.defineProperty(scroller, 'clientWidth', { value: 300 }) + const cell = document.createElement('span') + scroller.appendChild(cell) + const input = document.createElement('input') + el.append(scroller, input) + for (const target of [cell, input]) { + touch('touchstart', target, [[40, 300]]) + touch('touchmove', target, [[200, 300]]) + touch('touchend', target, [], [[200, 300]]) + } + expect(posted).toEqual([]) + }) + + it('cancels the drag when a second finger lands', () => { + const el = host() + touch('touchstart', el, [[40, 300]]) + touch('touchstart', el, [[40, 300], [90, 310]]) + touch('touchmove', el, [[200, 300], [250, 310]]) + expect(posted.map((m) => m.phase)).toEqual(['start', 'cancel']) + }) +}) diff --git a/website/src/uiLocations/areas/members.ts b/website/src/uiLocations/areas/members.ts index c553fcaf0e01..04af1ae53296 100644 --- a/website/src/uiLocations/areas/members.ts +++ b/website/src/uiLocations/areas/members.ts @@ -77,8 +77,9 @@ export const LOCATIONS = { ], }], }, - // The phone's way from a crewmate chat back to the roster (the header arrow, - // named after the page). It returns to the bare `/members` roster. + // The phone's way from a crewmate chat to the roster: the header's drawer + // toggle, the same control as the Sessions page's. It slides the roster + // drawer in over the open chat, and closes it again. 'members.back': { kind: 'button', label: { from: 'attr', attr: 'aria-label' }, diff --git a/website/src/uiLocations/guidePlans.gen.ts b/website/src/uiLocations/guidePlans.gen.ts index a78c37029289..35ca2c1cf62f 100644 --- a/website/src/uiLocations/guidePlans.gen.ts +++ b/website/src/uiLocations/guidePlans.gen.ts @@ -3,7 +3,7 @@ import type { UiGuidePlan } from './types' /** The `build_digest` of the packaged index this bundle was built with (see `guideBuildDigest`). */ -export const GUIDE_BUILD_DIGEST = "sha256:515ce57654d554c6a834d0265b68ac48329e0a09c23bf5ab3246cb9ad54d5daa" +export const GUIDE_BUILD_DIGEST = "sha256:8ab228754d23ceb58f5c723082e776d7f9a6fc9563ecb0373980a5d4d1096b2d" /** Curated location ids: the only ids a live observation may name. */ export const GUIDE_OBSERVABLE_IDS: readonly string[] = [ @@ -1807,7 +1807,7 @@ export const GUIDE_PLANS: Readonly> = { { "id": "mobile:members.back", "location": "members.back", - "label_key": "pages.membersPage.back_to_roster", + "label_key": "pages.membersPage.toggle_roster", "when": "crewmate_chat_open_phone", "scope": "members.roster-phone" }, @@ -1881,7 +1881,7 @@ export const GUIDE_PLANS: Readonly> = { { "id": "mobile:members.back", "location": "members.back", - "label_key": "pages.membersPage.back_to_roster", + "label_key": "pages.membersPage.toggle_roster", "when": "crewmate_chat_open_phone", "scope": "members.roster-phone" }, @@ -1961,7 +1961,7 @@ export const GUIDE_PLANS: Readonly> = { { "id": "mobile:members.back", "location": "members.back", - "label_key": "pages.membersPage.back_to_roster", + "label_key": "pages.membersPage.toggle_roster", "when": "crewmate_chat_open_phone", "scope": "members.roster-phone" }, @@ -1985,7 +1985,7 @@ export const GUIDE_PLANS: Readonly> = { }, "members.back": { "version": 2, - "label_key": "pages.membersPage.back_to_roster", + "label_key": "pages.membersPage.toggle_roster", "placements": [ { "id": "mobile", @@ -2009,7 +2009,7 @@ export const GUIDE_PLANS: Readonly> = { { "id": "mobile:members.back", "location": "members.back", - "label_key": "pages.membersPage.back_to_roster" + "label_key": "pages.membersPage.toggle_roster" } ] } diff --git a/website/src/uiLocations/members.locations.test.ts b/website/src/uiLocations/members.locations.test.ts index 21c01043ecae..50e71a400cc3 100644 --- a/website/src/uiLocations/members.locations.test.ts +++ b/website/src/uiLocations/members.locations.test.ts @@ -39,7 +39,7 @@ const EXPECTED: Record