From c0e33f8d04e85ceff4b24e28cf31f89218ea948b Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Tue, 27 Oct 2026 23:55:06 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m2/ts-scalar-ice.md Quest-Claim: 77de3a41c99e0263 From 55d5b352adddadfc63f946ae1d6d408c32b52327 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Wed, 28 Oct 2026 00:00:54 -0700 Subject: [PATCH 2/2] chore(quest): drop ts-scalar-ice, fixed within #130 #130's own a31650f6 added the ok_or_error guard and the splits.rs fixture that crashes without it, with the same backtrace as the committed report. Co-Authored-By: Claude Opus 5.5 --- quest/m2/README.md | 1 - quest/m2/ts-scalar-ice.md | 21 --------------------- 2 files changed, 22 deletions(-) delete mode 100644 quest/m2/ts-scalar-ice.md diff --git a/quest/m2/README.md b/quest/m2/README.md index 4977d9a8a..572d2f664 100644 --- a/quest/m2/README.md +++ b/quest/m2/README.md @@ -27,7 +27,6 @@ The fork's feature quests folded into the [exporter](/quest/m1/ffi-export/README ## Required - [A tuple's parts read after their variables change](/quest/m2/ts-swap-parts.md) - `(a, b) = (b, a)` swaps instead of copying one into both -- [Byte-slice locals that crash the translator](/quest/m2/ts-scalar-ice.md) - `take_apart` never reaches the arm `find_scalars` promised it wouldn't - [Fixture cases by name](/quest/m2/ts-harness-names.md) - adding a harness case never renumbers another - [Byte slices without objects](/quest/m2/ts-byte-views/README.md) - reading through a translated cursor allocates no object per read - [Drop in the TypeScript translator](/quest/m2/ts-drop.md) - every value that drops in moq-net and kio drops where Rust drops it diff --git a/quest/m2/ts-scalar-ice.md b/quest/m2/ts-scalar-ice.md deleted file mode 100644 index c45b02f31..000000000 --- a/quest/m2/ts-scalar-ice.md +++ /dev/null @@ -1,21 +0,0 @@ -# [S] Byte-slice locals that crash the translator - -## Goal - -rust2-ts never panics in `Fx::take_apart` (`ts/src/lower/mir/scalar.rs`): every value -`find_scalars` holds as parts can be taken apart, or `find_scalars` declines it, proven by a -fixture that crashed before the fix and by differential tests against native Rust. - -## Plan - -Decided with the maintainer on 2026-10-27: a rustc ICE report that -[#130](https://github.com/kixelated/rust2/pull/130) committed by accident records -`take_apart` reaching `unreachable!("checked by find_scalars")`. The input is lost, and -`main` still has the arm (`Shape::Enum`), so reproduce it first: likely an enum-shaped value -taken apart where `find_scalars` assumed none, from the codec, moq's model census, or a -fixture variant. - -- Fix it where `find_scalars` and `take_apart` disagree, and check the file's other - `checked by find_scalars` assumptions for the same gap. - -Public API: none, unless the fix changes the translator's output.