diff --git a/.claude/skills/quest-grill/SKILL.md b/.claude/skills/quest-grill/SKILL.md new file mode 100644 index 000000000..8fa25cd91 --- /dev/null +++ b/.claude/skills/quest-grill/SKILL.md @@ -0,0 +1,7 @@ +--- +name: quest-grill +description: Settle open decisions through an interactive interview with the user. Use when the user invokes /quest-grill or wants unsettled thinking challenged before action. +--- + +Run `quest skill grill` and follow its output. +If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. diff --git a/.claude/skills/quest-ready/SKILL.md b/.claude/skills/quest-ready/SKILL.md deleted file mode 100644 index 371bacff0..000000000 --- a/.claude/skills/quest-ready/SKILL.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -name: quest-ready -description: Mark a draft PR ready for review, wait for an automated review, then decide whether to merge. ---- - -Run `quest skill ready` and follow its output. -If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. diff --git a/.claude/skills/quest-review/SKILL.md b/.claude/skills/quest-review/SKILL.md new file mode 100644 index 000000000..3a9251f21 --- /dev/null +++ b/.claude/skills/quest-review/SKILL.md @@ -0,0 +1,7 @@ +--- +name: quest-review +description: Review a PR's branch locally with the other vendor's model, then mark it ready for review. +--- + +Run `quest skill review` and follow its output. +If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ca88624b9..ceebe01aa 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,14 +25,9 @@ Open a draft PR while working, run `just check` and `just test` before every pus # Reviews -AI agents review pushes on their own. Never explicitly request a review. - -For each finding: - -- If you don't agree with it, reply to the finding and move on. -- If it's a relatively easy improvement, fix it and push. - -Queue a PR only after a review from a reviewer other than Grok has no findings, or every finding is fixed or replied to. +Review each PR locally with `/quest-review`, as the quest guide describes; merging never waits on an online reviewer, and never request one. +The PR body's `## Review` record counts as the required review when it names the head being merged, and so does a recorded skip of a change too trivial to review. +Address online reviewers' findings already posted on that head before merging: fix them, or reply where you disagree. # Follow-ups diff --git a/REVIEW.md b/REVIEW.md new file mode 100644 index 000000000..b075cf0c2 --- /dev/null +++ b/REVIEW.md @@ -0,0 +1,8 @@ +# Review + +Be adversarial: assume the change is wrong until the diff and its tests show otherwise. + +- Generated output must match native Rust exactly, including integer widths and overflow, drop order, laziness, and error paths. Ask for the differential case that proves it. +- An unsupported construct must be refused with a source span, never a silent fallback or a runtime guess. +- A test must fail without the change it covers. +- Report real defects only; leave style to `just check` and AGENTS.md. diff --git a/flake.lock b/flake.lock index 07c703064..0705a939f 100644 --- a/flake.lock +++ b/flake.lock @@ -65,17 +65,17 @@ ] }, "locked": { - "lastModified": 1793122509, - "narHash": "sha256-zF1ETuYCXPrO++RnIuuFx2VgwMxEiQ38l5QsZCh01vc=", + "lastModified": 1793286109, + "narHash": "sha256-er9ekp0xFZGY2EA/D+01UsbLL3i3H2lMmEYSCUNF7OY=", "owner": "kixelated", "repo": "quest", - "rev": "943cecaf58a2722dd05f27ab468972c5fe9b714d", + "rev": "01d051cf5dca8cd29c664bf8bcbcab63cdc76445", "type": "github" }, "original": { "owner": "kixelated", "repo": "quest", - "rev": "943cecaf58a2722dd05f27ab468972c5fe9b714d", + "rev": "01d051cf5dca8cd29c664bf8bcbcab63cdc76445", "type": "github" } }, diff --git a/flake.nix b/flake.nix index ea754b0ae..c67f46bbc 100644 --- a/flake.nix +++ b/flake.nix @@ -11,7 +11,7 @@ # The quest CLI, which also serves the quest guide and skills the stubs in # .claude/skills call. Bump the rev to upgrade them. quest = { - url = "github:kixelated/quest/943cecaf58a2722dd05f27ab468972c5fe9b714d"; + url = "github:kixelated/quest/01d051cf5dca8cd29c664bf8bcbcab63cdc76445"; inputs.nixpkgs.follows = "nixpkgs"; inputs.flake-utils.follows = "flake-utils"; }; diff --git a/quest/m0/README.md b/quest/m0/README.md index a3931f22e..36220eec8 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -2,9 +2,4 @@ ## Goal -Urgent fixes to anything a consumer already depends on, and adopting local -reviews. Otherwise empty while nothing is released. - -## Required - -- [Adopt local reviews](/quest/m0/local-review.md) - PRs are reviewed locally by the other vendor's model before they are pushed, and merging never waits on an online reviewer +Urgent fixes to anything a consumer already depends on. diff --git a/quest/m0/local-review.md b/quest/m0/local-review.md deleted file mode 100644 index b48524859..000000000 --- a/quest/m0/local-review.md +++ /dev/null @@ -1,23 +0,0 @@ -# [S] Adopt local reviews - -## Goal - -PRs here are reviewed locally by the other vendor's model through -`/quest-review` before they are pushed for review, and merging never waits -on an online reviewer. Start once `quest review` is on kixelated/quest's -`main`, where it is planned as `quest/m0/local-review.md`. - -## Plan - -Decided 2026-10-28 (maintainer, /quest-plan in kixelated/quest): - -- Bump the `quest` flake input to a kixelated/quest rev with `quest review`. -- Rewrite the review policy: the PR body's `## Review` record counts as the - required review when it names the head being merged, and so does a - recorded skip of a change the author judged too trivial to review. - Online reviewers' findings already posted on the head are addressed at - merge, never waited for or requested. -- Replace "a review from a reviewer other than Grok" and "AI agents review - pushes on their own" in `CONTRIBUTING.md`. Ask the maintainer whether to - add a `REVIEW.md`, which sets the reviewer's stance (such as adversarial) - and review-only rules.