From 6fe5219b9f39efb0fe37282293eb97662c6c9bf2 Mon Sep 17 00:00:00 2001 From: kogai Date: Sun, 13 Sep 2026 07:28:03 +0000 Subject: [PATCH 1/2] Correct the stale metadata in package.json Fields that describe something that is not there: - description was the literal string "## Prior Art", a fragment of an early README - main pointed at sandbox.js, which does not exist in the repository - directories.test pointed at test/, which is the Haskell HUnit suite, not an npm one - the test script only ever ran `exit 1`; the real suites are `make test` and the bazel e2e target - repository, bugs and homepage all pointed at kogai/onix, while this repository is kogai/onix-codegen Raised in review of #57 and split out from it so the dependency bump stayed a dependency bump. Not touched, because it needs an answer rather than an edit: the declared licence disagrees in three places. LICENSE is MIT, package.yaml and onix.cabal say BSD3, package.json says ISC. Picking one is the maintainer's call, so it is described in the pull request instead. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01P8rZakwAiz1jpViUX34x1Z --- package.json | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/package.json b/package.json index a204662..a8051dd 100644 --- a/package.json +++ b/package.json @@ -1,11 +1,7 @@ { "name": "onix", "version": "1.0.0", - "description": "## Prior Art", - "main": "sandbox.js", - "directories": { - "test": "test" - }, + "description": "Auto-generated ONIX for Books client and its generator", "dependencies": {}, "devDependencies": { "@bazel/bazelisk": "1.28.1", @@ -15,18 +11,15 @@ "peerDependencies": { "fast-xml-parser": "^5.11.1" }, - "scripts": { - "test": "echo \"Error: no test specified\" && exit 1" - }, "repository": { "type": "git", - "url": "git+https://github.com/kogai/onix.git" + "url": "git+https://github.com/kogai/onix-codegen.git" }, "keywords": [], "author": "", "license": "ISC", "bugs": { - "url": "https://github.com/kogai/onix/issues" + "url": "https://github.com/kogai/onix-codegen/issues" }, - "homepage": "https://github.com/kogai/onix#readme" + "homepage": "https://github.com/kogai/onix-codegen#readme" } From 6aac73421f15bf90bc6dae03ce1faa8223e9c7f8 Mon Sep 17 00:00:00 2001 From: kogai Date: Sun, 13 Sep 2026 07:46:25 +0000 Subject: [PATCH 2/2] Mark the package private and align its licence with LICENSE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review made the case that "license": "ISC" belongs in this PR after all. The three declared licences are not three considered opinions: BSD3 sits in package.yaml next to github: "githubuser/onix", author: "Author name here" and maintainer: "example@example.com", which is an unedited `stack new` template, and ISC is what `npm init` writes by default. Only LICENSE — MIT, Copyright (c) 2020 Shinichi Kogai — shows any sign of being chosen. So ISC is the same kind of placeholder as the main and directories fields this PR already removed, and pointing it at the file that actually governs is not picking a licence. package.yaml and onix.cabal are still left alone: changing the Haskell package's declared licence is the part that needs the author, and it is described in the pull request. Also mark the package private. The npm name "onix" is already taken by another publisher, so this manifest cannot be published as it stands; it exists to feed npx bazelisk. Saying so directly settles the accuracy of version, author and keywords, and answers the peerDependencies question the pull request raised. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01P8rZakwAiz1jpViUX34x1Z --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index a8051dd..413c20e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,7 @@ { "name": "onix", "version": "1.0.0", + "private": true, "description": "Auto-generated ONIX for Books client and its generator", "dependencies": {}, "devDependencies": { @@ -17,7 +18,7 @@ }, "keywords": [], "author": "", - "license": "ISC", + "license": "MIT", "bugs": { "url": "https://github.com/kogai/onix-codegen/issues" },