From 1729189ae09c260a02431c23ea59b721e40bb5af Mon Sep 17 00:00:00 2001 From: Tyler Reddy Date: Wed, 21 Oct 2026 09:47:54 -0600 Subject: [PATCH 1/2] TST: xfail test_partial_fit() on Linux * Related to gh-117. That issue has been causing our CI to fail for almost 4 months now. While I was hoping someone would fix the matter properly, we can't continue to have CI failing all the time because we need to be able to assess the quality of other thrusts of work. * So, this branch proposes to `xfail` a subset of `test_partial_fit()` on Linux to avoid the failure. The issue will remain open--this is just to allow us to assess the correctness of incoming changes without interference from gh-117. * I confirmed that this allows the full testsuite to pass on an x86_64 Linux machine with NumPy `2.5.4` installed from PyPI. --- src/gfdl/tests/test_model.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gfdl/tests/test_model.py b/src/gfdl/tests/test_model.py index 66ce1af..81526da 100644 --- a/src/gfdl/tests/test_model.py +++ b/src/gfdl/tests/test_model.py @@ -547,7 +547,9 @@ def test_rtol_ensemble(reg_alpha, rtol, expected_acc, expected_roc): [ (GFDLClassifier, True, "coeff_"), (GFDLClassifier, False, "coeff_"), - (EnsembleGFDLClassifier, None, "coeffs_"), + pytest.param(EnsembleGFDLClassifier, None, "coeffs_", + marks=pytest.mark.xfail(condition="sys.platform == 'linux'", + reason="gh-117")), ], ) def test_partial_fit( From cbcc822825e65f3bc1bc3bdc148566fc06ae8157 Mon Sep 17 00:00:00 2001 From: Tyler Reddy Date: Wed, 21 Oct 2026 10:41:29 -0600 Subject: [PATCH 2/2] TST: PR 138 revisions * Adjust test_partial_fit() to also `xfail` on the Windows platform, because it is also affected by gh-117. --- src/gfdl/tests/test_model.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gfdl/tests/test_model.py b/src/gfdl/tests/test_model.py index 81526da..4027514 100644 --- a/src/gfdl/tests/test_model.py +++ b/src/gfdl/tests/test_model.py @@ -548,8 +548,9 @@ def test_rtol_ensemble(reg_alpha, rtol, expected_acc, expected_roc): (GFDLClassifier, True, "coeff_"), (GFDLClassifier, False, "coeff_"), pytest.param(EnsembleGFDLClassifier, None, "coeffs_", - marks=pytest.mark.xfail(condition="sys.platform == 'linux'", - reason="gh-117")), + marks=pytest.mark.xfail( + condition="sys.platform in ('linux', 'win32')", + reason="gh-117")), ], ) def test_partial_fit(