From d6e430f7e37c8063706663b9ce9b8364262460cb Mon Sep 17 00:00:00 2001 From: Tyler Reddy Date: Wed, 28 Oct 2026 08:48:10 -0600 Subject: [PATCH] CI: run full CI matrices on failures * We've have CI failures plaguing us for months now (gh-117, gh-98, and others), and for GitHub Actions matrix jobs, when one entry in the matrix fails the rest of the jobs are then cancelled. This makes it hard for the reviewer to assess if new problems have been introduced to CI jobs that are not running. * This small patch allows all CI jobs in GHA matrices to run to completion, whether other matrix members fail or not, to make it easier for reviewers to assess what is going on. * This is pretty commonly used as one can see from other well-maintained repositories. For example, `git grep -E -i "fail-fast"` in the latest `main` branch of NumPy shows many uses of `fail-fast: false`. --- .github/workflows/ci.yml | 1 + .github/workflows/wheel.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f15d456..1821340 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,6 +13,7 @@ jobs: test: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: os: [ubuntu-latest, macos-latest, windows-latest] python-version: ["3.12", "3.13", "3.14"] diff --git a/.github/workflows/wheel.yml b/.github/workflows/wheel.yml index b218907..44220e9 100644 --- a/.github/workflows/wheel.yml +++ b/.github/workflows/wheel.yml @@ -13,6 +13,7 @@ jobs: test: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: os: [ubuntu-latest, macos-latest, windows-latest] python-version: ["3.12", "3.13", "3.14"]