T-17985 Handle RuntimeError from Thread.is_alive() on Python 3.14+ (#39)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: PetrHeinz

.github/workflows/main.yml

@@ -3,13 +3,17 @@ name: tests
 on:
   - push
   - pull_request
+  - workflow_dispatch
 
 jobs:
   build:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
+      fail-fast: false
       matrix:
-        python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
+        # '3.x' always resolves to the latest stable Python 3 release, so new
+        # minor versions get exercised as soon as they ship.
+        python-version: ['3.10', '3.11', '3.12', '3.13', '3.14', '3.x']
 
     steps:
     - uses: actions/checkout@v1

example-project/README.md

@@ -39,10 +39,10 @@ In this section, we will take a look at actual logging as shown in the example p
 
 ## Setup
 
-First, we need to import the Logtail client library to our code. This can be done using the import keyword. We also need to import the default logging library.
+First, we need to import the Better Stack client library to our code. This can be done using the import keyword. We also need to import the default logging library.
 
 ```python
-# Import Logtail client library and default logging library
+# Import Better Stack client library and default logging library
 from logtail import LogtailHandler
 import logging
 ```
@@ -81,7 +81,7 @@ Code above will generate only one log because the debug level message has lowere
 
 ## Logging example
 
-The `logger` instance we created in the setup section is used to send log messages to Logtail. It provides 6 logging methods for the 6 default log levels. The log levels and their method are:
+The `logger` instance we created in the setup section is used to send log messages to Better Stack. It provides 6 logging methods for the 6 default log levels. The log levels and their method are:
 
 - **DEBUG** - Send debug messages using the `debug()` method
 - **INFO** - Send informative messages about the application progress using the `info()` method

example-project/example-project.py

@@ -1,10 +1,10 @@
-# This is an example project of Logtail python integration
-# This project showcases how to use Logtail in your python projects
+# This is an example project of Better Stack python integration
+# This project showcases how to use Better Stack in your python projects
 # For more information please visit https://github.com/logtail/logtail-python
 
 # SETUP
 
-# Import Logtail client library and default logging library
+# Import Better Stack client library and default logging library
 from logtail import LogtailHandler
 import logging
 import sys
@@ -27,10 +27,10 @@
 # Following code showcases logger usage
 
 # Send debug log using the debug() method
-logger.debug('I am using Logtail!')
+logger.debug('I am using Better Stack!')
 
 # Send info level log about interesting events using the info() method
-logger.info('I love Logtail!')
+logger.info('I love Better Stack!')
 
 # Send warning level log about worrying events using the warning() method
 # You can also add custom structured information to the log by passing it as a second argument

logtail/__init__.py

@@ -5,6 +5,6 @@
 from .helpers import LogtailContext, DEFAULT_CONTEXT
 from .formatter import LogtailFormatter
 
-__version__ = '0.3.4'
+__version__ = '0.4.0'
 
 context = DEFAULT_CONTEXT

logtail/flusher.py

@@ -26,6 +26,16 @@ def run(self):
         while self.should_run:
             self.step()
 
+    def _is_parent_alive(self):
+        try:
+            return self.parent_thread.is_alive()
+        except RuntimeError:
+            # Starting with Python 3.14, calling is_alive() on an
+            # already-terminated thread raises a RuntimeError instead of
+            # returning False (see the parent thread being torn down during
+            # interpreter shutdown). Treat that as "no longer alive".
+            return False
+
     def step(self):
         last_flush = time.time()
         time_remaining = _initial_time_remaining(self.flush_interval)
@@ -34,7 +44,7 @@ def step(self):
 
         # If the parent thread has exited but there are still outstanding
         # events, attempt to send them before exiting.
-        shutdown = not self.parent_thread.is_alive()
+        shutdown = not self._is_parent_alive()
 
         # Fill phase: take events out of the queue and group them for sending.
         # Takes up to `buffer_capacity` events out of the queue and groups them
@@ -54,11 +64,11 @@ def step(self):
             except queue.Empty:
                 if shutdown or self._flushing:
                     break
-            shutdown = not self.parent_thread.is_alive()
+            shutdown = not self._is_parent_alive()
             time_remaining = _calculate_time_remaining(last_flush, self.flush_interval)
 
         # Send phase: takes the outstanding events (up to `buffer_capacity`
-        # count) and sends them to the Logtail endpoint all at once. If the
+        # count) and sends them to the Better Stack endpoint all at once. If the
         # request fails in a way that can be retried, it is retried with an
         # exponential backoff in between attempts.
         if frame:

setup.py

@@ -3,7 +3,7 @@
 from setuptools import setup
 
 
-VERSION = '0.3.4'
+VERSION = '0.4.0'
 ROOT_DIR = os.path.dirname(__file__)
 
 REQUIREMENTS = [
@@ -20,25 +20,26 @@
     packages=['logtail'],
     include_package_data=True,
     license='ISC',
-    description='Logtail.com client library',
+    description='Better Stack client library',
     long_description=long_description,
     long_description_content_type='text/markdown',
     url='https://github.com/logtail/logtail-python',
     download_url='https://github.com/logtail/logtail-python/tarball/%s' % (VERSION),
     keywords=['api', 'logtail', 'logging', 'client'],
     install_requires=REQUIREMENTS,
+    python_requires='>=3.10',
     author='Logtail',
     author_email='hello@logtail.com',
     classifiers=[
           'Intended Audience :: Developers',
           'License :: OSI Approved :: ISC License (ISCL)',
           'Operating System :: OS Independent',
           'Programming Language :: Python :: 3',
-          'Programming Language :: Python :: 3.7',
-          'Programming Language :: Python :: 3.8',
-          'Programming Language :: Python :: 3.9',
           'Programming Language :: Python :: 3.10',
           'Programming Language :: Python :: 3.11',
+          'Programming Language :: Python :: 3.12',
+          'Programming Language :: Python :: 3.13',
+          'Programming Language :: Python :: 3.14',
           'Programming Language :: Python',
           'Topic :: Software Development :: Libraries :: Python Modules',
     ],

tests/test_flusher.py

@@ -1,7 +1,6 @@
 # coding: utf-8
 from __future__ import print_function, unicode_literals
 import mock
-import sys
 import time
 import threading
 import unittest
@@ -146,8 +145,39 @@ def uploader(frame):
         self.assertEqual(self.upload_calls, 1)
         self.assertFalse(fw.should_run)
 
-    # test relies on overriding excepthook which is available from 3.8+
-    @unittest.skipIf(sys.version_info < (3, 8), "Test skipped because overriding excepthook is only available on Python 3.8+")
+    def test_is_parent_alive_handles_runtime_error(self):
+        # Starting with Python 3.14, is_alive() raises RuntimeError when
+        # called on an already-terminated thread instead of returning False.
+        # The worker must treat that as the parent no longer being alive.
+        _, _, fw = self._setup_worker()
+        fw.parent_thread = mock.MagicMock()
+        fw.parent_thread.is_alive.side_effect = RuntimeError('cannot join current thread')
+
+        self.assertFalse(fw._is_parent_alive())
+
+    def test_shutdown_condition_when_parent_is_alive_raises(self):
+        self.buffer_capacity = 10
+        num_items = 5
+        first_frame = list(range(self.buffer_capacity))
+        self.assertLess(num_items, self.buffer_capacity)
+
+        self.upload_calls = 0
+        def uploader(frame):
+            self.upload_calls += 1
+            self.assertEqual(frame, first_frame[:num_items])
+            return mock.MagicMock(status_code=202)
+
+        pipe, _, fw = self._setup_worker(uploader)
+        fw.parent_thread = mock.MagicMock()
+        fw.parent_thread.is_alive.side_effect = RuntimeError('cannot join current thread')
+
+        for i in range(num_items):
+            pipe.put(first_frame[i], block=False)
+
+        fw.step()
+        self.assertEqual(self.upload_calls, 1)
+        self.assertFalse(fw.should_run)
+
     def test_shutdown_dont_raise_exception_in_thread(self):
         original_excepthook = threading.excepthook
         threading.excepthook = mock.Mock()

tests/test_frame.py

@@ -3,7 +3,6 @@
 from logtail.frame import create_frame
 from logtail.handler import LogtailHandler
 from logtail.helpers import LogtailContext
-from sys import version_info
 import datetime
 import unittest
 import logging
@@ -17,11 +16,8 @@ def test_create_frame_happy_path(self):
         # ISO timestamp must end with timezone info
         self.assertTrue(frame['dt'].endswith("+00:00"))
 
-        # These tests require Python >= 3.7
-        if version_info.major == 2 or version_info.minor <= 6:
-            return
         # Sent date matches log record date
-        date_ref = datetime.datetime.utcfromtimestamp(log_record.created).replace(tzinfo=datetime.timezone.utc)
+        date_ref = datetime.datetime.fromtimestamp(log_record.created, datetime.timezone.utc)
         date_sent = datetime.datetime.fromisoformat(frame['dt'])
         self.assertEqual(date_ref, date_sent)
 

tox.ini

@@ -1,13 +1,13 @@
 [tox]
-envlist = py37, py38, py39, py310, py311
+envlist = py310, py311, py312, py313, py314
 
 [gh-actions]
 python =
-    3.7: py37
-    3.8: py38
-    3.9: py39
     3.10: py310
     3.11: py311
+    3.12: py312
+    3.13: py313
+    3.14: py314
 
 [testenv]
 deps =