Release memory allocated by unit tests

Use scoped objects for temporary event and buffer allocations, and destroy the log-session provider during fixture teardown so leak reports represent SDK behavior rather than test fixture ownership.

Files changed:
tests/unittests/AnnexKTests.cpp
tests/unittests/LogSessionDataDBTests.cpp
tests/unittests/TransmissionPolicyManagerTests.cpp

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: df9f344e-e064-404e-ae6f-c0ef455d747c

Author: bmehta001

tests/unittests/AnnexKTests.cpp

@@ -8,25 +8,25 @@ TEST(AnnexKTests, memcpy_s)
 {
     volatile size_t dest_size =10;
     volatile size_t src_size = 5;
-    void    *dest =  malloc(sizeof(char) * dest_size);
-    void    *src = malloc(sizeof(char) * src_size);
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(src, 5, "TEST", 5), 0);
+    std::unique_ptr<void, decltype(&free)> dest(malloc(sizeof(char) * dest_size), &free);
+    std::unique_ptr<void, decltype(&free)> src(malloc(sizeof(char) * src_size), &free);
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(src.get(), 5, "TEST", 5), 0);
     rsize_t dest_len = dest_size;
     rsize_t src_len = src_size-1;
 
     // success tests
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest, dest_len, src, 0), 0);
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s( dest, dest_len, src, src_len + 1), 0);
-    EXPECT_EQ(strlen((char *)dest), strlen("TEST"));
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest, dest_len + 2, src, src_len + 1), 0);
-    EXPECT_EQ(strlen((char *)dest), strlen("TEST"));
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), dest_len, src.get(), 0), 0);
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), dest_len, src.get(), src_len + 1), 0);
+    EXPECT_EQ(strlen(static_cast<char *>(dest.get())), strlen("TEST"));
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), dest_len + 2, src.get(), src_len + 1), 0);
+    EXPECT_EQ(strlen(static_cast<char *>(dest.get())), strlen("TEST"));
 
     // error tests
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest, 3, src, src_len), EINVAL);
-    EXPECT_EQ(((char *)dest)[0], '\0');
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(NULL, 3, src, src_len), EINVAL);
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s( dest, dest_len, NULL, src_len), EINVAL);
-    EXPECT_EQ(((char *)dest)[0], '\0');
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s( dest, dest_len, src, dest_len + 1 ), EINVAL);
-    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s( dest, dest_len, (void *)((char *)dest + 1), src_len + 1 ), EINVAL);
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), 3, src.get(), src_len), EINVAL);
+    EXPECT_EQ(static_cast<char *>(dest.get())[0], '\0');
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(NULL, 3, src.get(), src_len), EINVAL);
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), dest_len, NULL, src_len), EINVAL);
+    EXPECT_EQ(static_cast<char *>(dest.get())[0], '\0');
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), dest_len, src.get(), dest_len + 1), EINVAL);
+    EXPECT_EQ(BoundCheckFunctions::oneds_memcpy_s(dest.get(), dest_len, static_cast<char *>(dest.get()) + 1, src_len + 1), EINVAL);
 }

tests/unittests/LogSessionDataDBTests.cpp

@@ -72,6 +72,8 @@ class LogSessionDataDBTests : public ::testing::Test
 
     virtual void TearDown() override
     {
+        delete logSessionDataProvider;
+        logSessionDataProvider = nullptr;
         std::remove(name.str().c_str());
         offlineStorage->Shutdown();
         offlineStorage.reset();
@@ -97,4 +99,3 @@ TEST_F(LogSessionDataDBTests, subTest) {
     ASSERT_EQ(1, 1);
 #endif
 }
-

tests/unittests/TransmissionPolicyManagerTests.cpp

@@ -153,8 +153,8 @@ TEST_F(TransmissionPolicyManagerTests, IncomingEventDoesNothingWhenPaused)
 {
     tpm.paused(true);
 
-    auto event = new IncomingEventContext();
-    tpm.eventArrived(event);
+    IncomingEventContext event;
+    tpm.eventArrived(&event);
 }
 
 TEST_F(TransmissionPolicyManagerTests, IncomingEventSchedulesUpload)
@@ -174,13 +174,13 @@ TEST_F(TransmissionPolicyManagerTests, IncomingEventSchedulesUpload)
     EXPECT_TRUE(TransmitProfiles::load(customProfile));
     EXPECT_TRUE(TransmitProfiles::setProfile("Fred"));
 
-    auto event = new IncomingEventContext();
-    event->record.latency = EventLatency_Normal;
+    IncomingEventContext event;
+    event.record.latency = EventLatency_Normal;
 
 
     EXPECT_CALL(tpm, scheduleUpload(std::chrono::milliseconds { 1000 }, EventLatency_Normal, true))
         .WillOnce(Return());
-    tpm.eventArrived(event);
+    tpm.eventArrived(&event);
 }
 
 TEST_F(TransmissionPolicyManagerTests, ProfileAffectsSchedule)
@@ -200,10 +200,10 @@ TEST_F(TransmissionPolicyManagerTests, ProfileAffectsSchedule)
     EXPECT_TRUE(TransmitProfiles::load(customProfile));
     EXPECT_TRUE(TransmitProfiles::setProfile("Fred"));
 
-    auto event = new IncomingEventContext();
-    event->record.latency = EventLatency_Normal;
+    IncomingEventContext event;
+    event.record.latency = EventLatency_Normal;
     EXPECT_CALL(tpm, scheduleUpload(_, _, _)).Times(0);
-    tpm.eventArrived(event);
+    tpm.eventArrived(&event);
     TransmitProfiles::reset();
 }
 
@@ -224,10 +224,10 @@ TEST_F(TransmissionPolicyManagerTests, NoUploadForNegative)
     EXPECT_TRUE(TransmitProfiles::load(customProfile));
     EXPECT_TRUE(TransmitProfiles::setProfile("Fred"));
 
-    auto event = new IncomingEventContext();
-    event->record.latency = EventLatency_Normal;
+    IncomingEventContext event;
+    event.record.latency = EventLatency_Normal;
     EXPECT_CALL(tpm, scheduleUpload(_, _, _)).Times(0);
-    tpm.eventArrived(event);
+    tpm.eventArrived(&event);
     EXPECT_CALL(tpm, uploadAsync(_)).Times(0);
     tpm.scheduleUploadParent(std::chrono::milliseconds{-1000}, EventLatency_RealTime, true);
     TransmitProfiles::reset();
@@ -237,12 +237,12 @@ TEST_F(TransmissionPolicyManagerTests, ImmediateIncomingEventStartsUploadImmedia
 {
     tpm.paused(false);
 
-    auto event = new IncomingEventContext();
-    event->record.latency = EventLatency_Max;
+    IncomingEventContext event;
+    event.record.latency = EventLatency_Max;
     EventsUploadContextPtr upload;
     EXPECT_CALL(*this, resultInitiateUpload(_))
         .WillOnce(SaveArg<0>(&upload));
-    tpm.eventArrived(event);
+    tpm.eventArrived(&event);
 
     ASSERT_THAT(upload, NotNull());
     EXPECT_THAT(upload->requestedMinLatency, EventLatency_Max);
@@ -491,11 +491,11 @@ TEST_F(TransmissionPolicyManagerTests, FredProfile)
     EXPECT_TRUE(TransmitProfiles::setProfile("Fred_Profile"));
     tpm.paused(false);
 
-    auto event = new IncomingEventContext();
-    event->record.latency = EventLatency_Normal;
+    IncomingEventContext event;
+    event.record.latency = EventLatency_Normal;
     EXPECT_CALL(tpm, scheduleUpload(_, _, _))
         .Times(0);
-    tpm.eventArrived(event);
+    tpm.eventArrived(&event);
 }
 
 TEST_F(TransmissionPolicyManagerTests, Constructor_IsPaused_True)