.before() and .after() don't work for tasks in series/parallel

[ecraig12345]

Suppose I want to use the webapp preset and add something before (or after) the ts task:

const { taskPresets, chain } = require('just-scripts');
taskPresets.webapp();
chain('some-task').before('ts');

If I run just-scripts ts, my additional task will run. But if I do just-scripts build (which contains ts), it won't run my additional task.

So...extensible task configs? :D

[kenotron]

Seems like a bug in the chain... also, I think we should NOT have 'build' do test, build, bundle and lint anymore.

[ecraig12345]

Either that or something with how task registration works internally in undertaker. Either way I think this is worth prioritizing fixing if possible, because the workaround is pretty annoying. Real example I'm about to check in to tsx-editor in OUFR:

// @ts-check

const { preset, just } = require('@uifabric/build');
const { task, series, parallel, argv, condition } = just;
const copyTypes = require('./scripts/copyTypes');

preset();

task('copy-types', copyTypes);

// These have to be manually re-defined because we need to chain copy-types after copy, and
// chain() doesn't work if the task chained against is in the middle of the series...
task('dev', series('clean', 'copy', 'copy-types', 'sass', 'webpack-dev-server'));
task(
  'build',
  series(
    'clean',
    'copy',
    'copy-types',
    parallel(
      condition('validate', () => !argv().min),
      series('ts', parallel(condition('webpack', () => !argv().min), condition('lint-imports', () => !argv().min)))
    )
  )
).cached();

[github-actions]

Issues seem to have gone stale.

[ecraig12345]

Still a valid issue...

[github-actions]

Issue seems to have gone stale.

[ecraig12345]

Continues to be valid... Ken Chau (@kenotron) can you please disable this bot or at least make it so there's a label you can put so it won't mark things as stale...