How long does it usually take to get a review for a new package?

[Kirill638849776 [EscapetheCats] (Kirill638849776)]

Hello everyone! 👋

I submitted my first package PR (#424631 - Kirill638849776.CatAI) about 4 days ago. All checks have passed, CLA is signed, and the package works correctly locally. It was assigned to Stephen Gillie (@stephengillie), but there has been no review yet.

I completely understand that maintainers are busy, and I don't want to be pushy. However, I wanted to ask:

1. What is the average review time for new packages in winget-pkgs?
2. Is there anything I can do to help speed up the process?
3. The PR has a Validation-Executable-Error label, but it seems like a warning rather than a critical issue. Should I be worried about it?

I just want to make sure I'm following the process correctly and not missing anything on my side.

Thank you for your hard work maintaining this repository! 🙏

P.S. Here's my PR for reference: #424631

[Imre Eilertsen (DandelionSprout)]

1. I'm not sure anymore, since in light of Time to address the elephant in the room: There are too few users with PR merging rights who merge PRs. #333858, I personally perceive it as having become a "Lord of the Flies" situation that even my most negative estimates seem to have it take longer than. When I last kept track, the average was 2 weeks if the PR passed without problems on the very first try, and 5½ weeks if it received a red or yellow label at any point.
2. Looking into the PR: Yes, since making the manifest more detailed is always good in general. Add tags to the locale YAML file, make the ShortDescription longer, add PackageUrl: https://github.com/Kirill638849776/catai to the locale YAML, and (since it seems to meet all of the following checkboxes) cross off all 5 checkboxes in "Manifest Checklist", are the ones that come to mind.
3. Checking the log at https://cdn.winget.microsoft.com/artifacts/WinGetSvc-Validation-424631-1-artifacts.zip:

(...)
Exception during executable launch operation System.AggregateException: One or more errors occurred. (An error occurred trying to start process 'C:\Program Files\CatAI\catai_beta.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.)
 ---> System.ComponentModel.Win32Exception (216): An error occurred trying to start process 'C:\Program Files\CatAI\catai_beta.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.
(...)

I think it's a critical issue. Change the Architecture in the installer YAML from x86 to x64 and see if that helps.

[Mark Embling (markembling)]

I don't submit many pull requests but my previous one was in the region of 2 and a half weeks and my current one is still waiting after exactly 2 weeks so far. So based on my very limited experience, I guess at least 2 to 3 weeks.

The thread which Imre Eilertsen (@DandelionSprout) linked above definitely seems to imply this is a known pain point right now.

However some things seem to get through in literally a handful of days. I'm not clear where the difference comes from - whether there's any kind of reputational system at play or whether frequent contributors get a quicker response.

[Kirill638849776 [EscapetheCats] (Kirill638849776)]

it’s been going on for 2 months already :(((((((((((((

[Jehadur Rahman (Emran) (JehadurRE)]

Review times vary, but for new packages it is typically 1-2 weeks. A few things to know:

1. The Validation-Executable-Error label is common for new packages and is usually not a blocker. It often means the automated validation sandbox could not run the installer (e.g. it needs a GUI or specific environment). As long as the manifest is correct and the installer works locally, reviewers will typically override this.

2. There is nothing you can do to speed up review beyond making sure the manifest is clean: correct PackageIdentifier, matching version, valid InstallerSha256, and a working silent/unattended install switch if applicable.

3. Reviewers work through a large queue. Stephen Gillie (@stephengillie) is one of the most active reviewers, so your PR is in good hands. If it has been more than 2 weeks with no activity, you can politely comment on the PR asking for a status update.

4. Make sure you respond promptly if a reviewer requests changes -- stalled PRs get deprioritized.

Your PR passing all checks and having CLA signed means you have done everything right on your side. Just needs patience now.

[Kirill638849776 [EscapetheCats] (Kirill638849776)]

end of discussion. nothing helps :((((

[Imre Eilertsen (DandelionSprout)]

How about you actually try to implement the review I gave at point 3 of #426452 (comment)?