diff --git a/quest/m0/README.md b/quest/m0/README.md index 0d74fd2ffa0..984213b1b5d 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -17,7 +17,6 @@ regression test per Root Cause First. - [#3087](/quest/m0/3087-relay-mtls-peers-bypass-auth-api-mode-so-proxy-grants.md) - relay: mTLS peers bypass --auth-api-mode, so proxy grants can't refuse or scope them - [#2405](/quest/m0/2405-js-net-connect-logs-on-every-connection-at-the-wrong.md) - js/net: connect() logs on every connection at the wrong level and prints the JWT in the URL -- [Route resume identity](/quest/m0/route-resume.md) - a failing route ends the subscription instead of resuming through the next one, since announcements became prefix routes - [Dart leaks](/quest/m0/dart-leak.md) - the generated Dart bindings leak native memory on every call - [#3207](/quest/m0/3207-send-valid-publish-done-statuses-for-every-supported-ietf.md) - Send valid PUBLISH_DONE statuses for every supported IETF draft - [#3076](/quest/m0/3076-moq-relay-publish-is-unimplemented-by-design-make-the.md) - moq-relay: PUBLISH is unimplemented by design - make the rejection fail fast for clients that wait diff --git a/quest/m0/route-resume.md b/quest/m0/route-resume.md deleted file mode 100644 index c08b5e5bf6c..00000000000 --- a/quest/m0/route-resume.md +++ /dev/null @@ -1,101 +0,0 @@ -# [XL] Route resume identity - -## Goal - -A subscription whose serving route goes away resumes through the next best -route without the consumer noticing, as it did before announcements became -prefix routes. A route change that preserves the origin identity re-splices at -a group boundary; one that does not ends the subscription so the consumer -starts a new one. - -This supplies the per-path identity two other questlines are built on top of. - -## Plan - -### Root cause, and the decision - -[moq#3225](https://github.com/moq-dev/moq/pull/3225) made announcements prefix -routes and moved route state out of `broadcast::Broadcast` into `origin`. A -front used to hold the routes for its path and the identity of whoever was -serving it: `FrontState.publisher` was the first hop of the best route, and -`same_identity` decided whether an arriving route joined the existing front -(splice) or started a fresh broadcast. Both are gone, and the PR specified the -loss into the draft: "A route carries no content identity", and a relay "MUST -NOT splice a live subscription across sources reached through different -routes". Failover on dev is abort and resubscribe -(`origin::Consumer::routed_broadcast` retries), and every reader sees the -subscription end. - -Decision (2026-09-01): that spec point is reversed. Routes keep carrying the -hops and cost of what they serve, and a relay resumes/stitches a broadcast -across routes when the first hop is the same. `Epoch` stays dead; it was a -per-broadcast content generation, and nothing per-broadcast survives prefix -routes. What identifies a source is the route's first hop, which is still on -the wire, still in `RouteEntry`, and still ranked on by `route_order`. What was -lost is the structure that read it, not the value. - -### What to restore - -Give the per-path serve state an identity, derived from the first hop of the -route currently serving it, and re-splice rather than abort when a route change -preserves it: - -- Equal non-zero first hops are the same origin endpoint reached another way (a - reconnect, a cheaper path, a relay restarting). Splice at a group boundary. -- Different first hops are different sources at one path. End the subscription - rather than splicing one source's subscribers onto another's frames. -- `Hop::UNKNOWN` identifies nobody and never matches itself, which is what - `same_identity` existed to encode. Two anonymous peers must not pass for one - reconnecting. - -An empty hop chain is a local publish and keeps the local-source behavior it -has now. - -This is more than restoring a field, which is why the quest is sized XL. On dev -`ServeState` is per-announcer, and `create_source` mints a broadcast that is -deliberately not inserted into the broadcast tree, so nothing per-path spans -routes. The work includes rebuilding that front: a per-path structure that -outlives any single route, holds the serving identity, and is what a -replacement route splices into. - -### Draft - -The implementing PR amends `drafts/draft-lcurley-moq-lite.md` in the same -change, per the wire-behavior rule. The "route carries no content identity" -paragraph becomes the first-hop rule: two routes covering one path with the -same non-zero first hop are the same origin reached different ways, and a -relay MAY move a live subscription between them at a group boundary; across -differing or unknown first hops a relay MUST NOT splice, and the subscription -ends with the serving session as it does today. Record the change in the -moq-lite-06 changelog. - -### Boundaries - -Identity here is a routing-layer property, not a media one. The first hop -identifies the endpoint that originated the route, which for a prefix route is -whoever serves the subtree; equal first hops mean the same endpoint, not that -two encodings are interchangeable. That media-generation question is what -`Epoch` was reaching for and what -[plan-hls-identity](/quest/m2/plan-hls-identity.md) still owns for cacheable -URLs. - -The fix lands on `dev`, where prefix routes live; `main` has no prefix routes. - -### Tests - -The pre-#3225 goaway and cluster tests are the specification: a draining -session serves through the handover window and its subscribers move to the -surviving route without the subscription ending. Add the first-hop cases the -old front covered: a reconnecting publisher splices, a different publisher at -the same path does not, two anonymous peers never pass for one, and a -metadata-only reprice changes nothing visible. - -## Related - -- [Rank](/quest/m2/pop-skipping/rank.md) - reuses this comparison rule on the - route's *last* hop, since adopting a parent is about the adjacent relay rather - than about who produced the content -- [Resolve](/quest/m2/wildcard/resolve.md) - two publishers colliding at one - literal path resolve through this identity -- [plan-hls-identity](/quest/m2/plan-hls-identity.md) - the media-generation - identity this deliberately does not supply diff --git a/quest/m2/pop-skipping/README.md b/quest/m2/pop-skipping/README.md index 3aa51953ea2..8aa0876ef70 100644 --- a/quest/m2/pop-skipping/README.md +++ b/quest/m2/pop-skipping/README.md @@ -85,9 +85,8 @@ underneath it. produced the content, which alternate routes to one publisher deliberately share. The pre-#3225 front kept both (`FrontState.publisher` for the first, `handover_allowed` and the hold for the last), with `same_identity` comparing - either and refusing `Hop::UNKNOWN` on both. [Route resume - identity](/quest/m0/route-resume.md) restores that comparison rule and the - publisher half as a failover fix; [Rank](/quest/m2/pop-skipping/rank.md) owns + either and refusing `Hop::UNKNOWN` on both. [moq#3312](https://github.com/moq-dev/moq/pull/3312) restored that comparison rule and the + publisher half as the first-hop resume; [Rank](/quest/m2/pop-skipping/rank.md) owns the carrier half rather than reusing the wrong one. - The operator hand-authors one undirected base graph. Same-PoP connectivity is unconditional, not a self-edge operators must remember. The radius-two closure @@ -154,7 +153,6 @@ wire version and the two directional costs of one bidirectional session. ## Related -- [Route resume identity](/quest/m0/route-resume.md) - supplies the identity comparison rule adoption reuses on a different hop - [drain](/quest/m2/drain/README.md) - a second relay per PoP makes the same-PoP link price and its connection cardinality operationally important - [wildcard](/quest/m2/wildcard/README.md) - it reuses this questline's route cost, and needs a cluster on Lite06 - [relay-memory](/quest/m2/relay-memory/README.md) - a denser mesh multiplies whatever a non-selected route costs diff --git a/quest/m2/pop-skipping/rank.md b/quest/m2/pop-skipping/rank.md index 2da556d86dc..1c3b36c05bc 100644 --- a/quest/m2/pop-skipping/rank.md +++ b/quest/m2/pop-skipping/rank.md @@ -49,13 +49,12 @@ leaving a drained or vanished route stays immediate. ### Two identities, not one Adoption is a statement about the adjacent relay, and that is a different -identity from the one [Route resume identity](/quest/m0/route-resume.md) -restores. The pre-#3225 front kept both, because they answer different -questions: +identity from the first-hop resume rule [moq#3312](https://github.com/moq-dev/moq/pull/3312) landed. +The pre-#3225 front kept both, because they answer different questions: - The **first** hop is who produced the content. Alternate routes to one publisher deliberately share it, which is what makes them spliceable, and it - is what route-resume keys on. + is what the resume rule keys on. - The **last** hop is the peer that advertised the route: the parent a relay would be adopting. `handover_allowed` and the hold both keyed on it, and the rank hash was taken over it (`fnv_key(name, [peer])`). @@ -65,7 +64,7 @@ of one broadcast look like the same peer, so a changed parent would go undetected and two relays could adopt each other, which is the failure the hold exists to prevent. -What this quest reuses from route-resume is the comparison rule rather than the +What this quest reuses from the resume rule is the comparison rather than the field: `Hop::UNKNOWN` identifies nobody and never matches itself, so two anonymous relays must not pass for one relay reconnecting and skip the gate. @@ -90,5 +89,3 @@ lucky hash. - [Warm advertise](/quest/m2/pop-skipping/warm-advertise.md) - there is nothing to rank until two relays can both advertise one broadcast as warm -- [Route resume identity](/quest/m0/route-resume.md) - supplies the identity - comparison rule, and the publisher half of it diff --git a/quest/m2/pop-skipping/warm-advertise.md b/quest/m2/pop-skipping/warm-advertise.md index 55cb00bb0ad..83b1e1018c6 100644 --- a/quest/m2/pop-skipping/warm-advertise.md +++ b/quest/m2/pop-skipping/warm-advertise.md @@ -50,7 +50,3 @@ draining path retracts rather than repricing, and a subscriber on it moves to the broader route; a second relay carrying the same broadcast ties on warm and is separated by cold. -## Required - -- [Route resume identity](/quest/m0/route-resume.md) - a subscriber moving - between a warm route and a broader one must resume rather than end diff --git a/quest/m2/wildcard/README.md b/quest/m2/wildcard/README.md index 9fb4fe1fb63..e947eed3e64 100644 --- a/quest/m2/wildcard/README.md +++ b/quest/m2/wildcard/README.md @@ -63,10 +63,10 @@ What is genuinely missing, beyond patterns themselves, is content identity. Announcement `Epoch` was specified into lite-06 by [#2611](https://github.com/moq-dev/moq/pull/2611), never implemented, and removed from the draft by #3225, which retired `draft-lcurley-moq-broadcast` -with it. [Route resume identity](/quest/m0/route-resume.md) restores per-path -identity from the route's first hop, reversing #3225's no-splice rule, and -this questline builds its collision handling on that rather than on a -generation field. +with it. [moq#3312](https://github.com/moq-dev/moq/pull/3312) restored per-path identity +from the route's first hop, reversing #3225's no-splice rule, and this +questline builds its collision handling on that rather than on a generation +field. ### Decisions @@ -169,8 +169,7 @@ generation field. can hash one path to different workers before either concrete announcement propagates, and both land at the SAME literal path. Whichever route wins selection serves it, and a consumer moves between them only when the winner's - identity is preserved, per [Route resume - identity](/quest/m0/route-resume.md); two distinct workers are two identities, + identity is preserved, per the first-hop resume rule ([moq#3312](https://github.com/moq-dev/moq/pull/3312)); two distinct workers are two identities, so the loser's subscribers end and resubscribe rather than being spliced onto another worker's frames mid-group. Wildcard routing invents neither a lease nor a generation. This is weaker than the retired `Epoch` design, which could @@ -262,5 +261,3 @@ than announce state. pattern, and its catalog names the generations a wildcard cannot - [pop-skipping](/quest/m2/pop-skipping/README.md) - it owns the route cost and the rank hash this reuses -- [Route resume identity](/quest/m0/route-resume.md) - the per-path identity two - colliding advertisers are settled by diff --git a/quest/m2/wildcard/resolve.md b/quest/m2/wildcard/resolve.md index e27e34b3ae4..56b02e436e7 100644 --- a/quest/m2/wildcard/resolve.md +++ b/quest/m2/wildcard/resolve.md @@ -50,7 +50,7 @@ front's ordinary route change moves consumers at a group boundary. A cache-only answer would strand every bound consumer on the wildcard subscription with nothing able to migrate or stop it. When the concrete claim is a DIFFERENT publisher, its consumers end and resubscribe rather than -splicing, per [Route resume identity](/quest/m0/route-resume.md); this quest's +splicing, per the first-hop resume rule ([moq#3312](https://github.com/moq-dev/moq/pull/3312)); this quest's obligation is the route install that makes selection between them possible. Repeat requests for one path share that one route, keyed to survive the exclusion filter rather than handing one peer's answer to another. @@ -97,5 +97,3 @@ Tests, at the process level with real sessions rather than an in-process stand-i ## Required - [Advertise](/quest/m2/wildcard/advertise.md) -- [Route resume identity](/quest/m0/route-resume.md) - a wildcard-served - subscription must resume or end correctly when a concrete claim arrives