From 5125f53196c0a4007a1f9832967f7db2ba609ffe Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Mon, 28 Sep 2026 11:32:32 -0700 Subject: [PATCH 1/2] docs: say who requests Codex on fork PRs, add IPv6 TLS name quest Co-Authored-By: Claude Opus 5.5 --- CONTRIBUTING.md | 1 + quest/m1/README.md | 1 + quest/m1/ipv6-tls-name.md | 23 +++++++++++++++++++++++ 3 files changed, 25 insertions(+) create mode 100644 quest/m1/ipv6-tls-name.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c70b6ad1cf3..ea8dd63be9d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -47,6 +47,7 @@ For each finding: Wait for Codex to review the final head before merging. Merge only on its thumbs up, or once every Codex finding on the PR is fixed or replied to. +Codex skips fork PRs; ask the maintainer to request one. # Follow-ups diff --git a/quest/m1/README.md b/quest/m1/README.md index 1798728a6da..ddab72a84e3 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -58,6 +58,7 @@ transport, benchmark tooling); worktrees isolate commits, not semantics. - [TS import shared shift](/quest/m1/ts-import-shared-shift.md) - unflagged loop wraps move audio and video by one shift, so A/V sync holds across wraps - [PipeWire duplicate cameras](/quest/m1/pipewire-dup-cameras.md) - a webcam lists once with PipeWire enabled - [Catalog wall clock](/quest/m1/catalog-wall-clock.md) - `Clock::wall_clock` keeps the catalog's full precision instead of truncating to milliseconds +- [IPv6 TLS names](/quest/m1/ipv6-tls-name.md) - dialing an IPv6 literal with no host override completes TLS on every moq-tokio transport, not just noq - [Capture control](/quest/m1/capture-control.md) - on dev, `encode::Capture` replaces `CaptureOptions`, an unsupported `cut()` errors, and dropping the last `Control` cancels in-flight opens - [Video surface](/quest/m1/video-surface.md) - on dev, moq-ffi's `native` becomes `surface`, refused on platforms with no surface - [HLS discontinuity sequence](/quest/m1/hls-discontinuity-sequence.md) - on dev, `Segment::discontinuity` is the absolute sequence, so every cursor agrees diff --git a/quest/m1/ipv6-tls-name.md b/quest/m1/ipv6-tls-name.md new file mode 100644 index 00000000000..5979e0f96ca --- /dev/null +++ b/quest/m1/ipv6-tls-name.md @@ -0,0 +1,23 @@ +# [XS] IPv6 literal TLS names on every transport + +## Goal + +Dialing an IPv6 literal (`wss://[::1]:4443`, `moqt://[::1]`) with no +`tls_host_name` override completes the TLS handshake on every moq-tokio +transport. [#4322](https://github.com/moq-dev/moq/pull/4322) fixed the noq +QUIC path, where `url::Host::to_string()` kept the URL brackets and rustls +refused `[::1]` as a server name. The WebSocket path likely has the same bug: +`websocket.rs` takes its host from `url.host_str()`, which also keeps the +brackets. + +## Plan + +- Reproduce on WebSocket with a loopback `[::1]` listener and no override, + like #4322's pinned QUIC tests, before fixing. +- Check every place moq-tokio derives a TLS server name from a URL (WebSocket, + TCP, iroh, and any other dialer) and derive it the same way everywhere. A + shared helper is reasonable if more than one site needs it. +- Keep the bracketed form wherever it is correct: the HTTP `Host` header and + URL rebuilding. + +Public API and wire: none. From f5e1b5b54f83e84c1b7624f7815ce5c627b05597 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Mon, 28 Sep 2026 11:40:41 -0700 Subject: [PATCH 2/2] docs(quest): scope IPv6 TLS name quest to noq and WebSocket tokio-tungstenite strips IPv6 brackets before building the rustls name, so the known WebSocket gap is a bare ::1 override rejected by Url::set_host. TCP is plaintext and iroh dials by endpoint id. Co-Authored-By: Claude Opus 5.5 --- quest/m1/README.md | 2 +- quest/m1/ipv6-tls-name.md | 31 ++++++++++++++++++------------- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/quest/m1/README.md b/quest/m1/README.md index ddab72a84e3..41f9daf50aa 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -58,7 +58,7 @@ transport, benchmark tooling); worktrees isolate commits, not semantics. - [TS import shared shift](/quest/m1/ts-import-shared-shift.md) - unflagged loop wraps move audio and video by one shift, so A/V sync holds across wraps - [PipeWire duplicate cameras](/quest/m1/pipewire-dup-cameras.md) - a webcam lists once with PipeWire enabled - [Catalog wall clock](/quest/m1/catalog-wall-clock.md) - `Clock::wall_clock` keeps the catalog's full precision instead of truncating to milliseconds -- [IPv6 TLS names](/quest/m1/ipv6-tls-name.md) - dialing an IPv6 literal with no host override completes TLS on every moq-tokio transport, not just noq +- [IPv6 TLS names](/quest/m1/ipv6-tls-name.md) - dialing an IPv6 literal completes TLS on WebSocket as on noq, including a bare `::1` host override - [Capture control](/quest/m1/capture-control.md) - on dev, `encode::Capture` replaces `CaptureOptions`, an unsupported `cut()` errors, and dropping the last `Control` cancels in-flight opens - [Video surface](/quest/m1/video-surface.md) - on dev, moq-ffi's `native` becomes `surface`, refused on platforms with no surface - [HLS discontinuity sequence](/quest/m1/hls-discontinuity-sequence.md) - on dev, `Segment::discontinuity` is the absolute sequence, so every cursor agrees diff --git a/quest/m1/ipv6-tls-name.md b/quest/m1/ipv6-tls-name.md index 5979e0f96ca..a150e396999 100644 --- a/quest/m1/ipv6-tls-name.md +++ b/quest/m1/ipv6-tls-name.md @@ -1,23 +1,28 @@ -# [XS] IPv6 literal TLS names on every transport +# [XS] IPv6 literal TLS names on every TLS dialer ## Goal -Dialing an IPv6 literal (`wss://[::1]:4443`, `moqt://[::1]`) with no -`tls_host_name` override completes the TLS handshake on every moq-tokio -transport. [#4322](https://github.com/moq-dev/moq/pull/4322) fixed the noq -QUIC path, where `url::Host::to_string()` kept the URL brackets and rustls -refused `[::1]` as a server name. The WebSocket path likely has the same bug: -`websocket.rs` takes its host from `url.host_str()`, which also keeps the -brackets. +Dialing an IPv6 literal (`wss://[::1]:4443`, `moqt://[::1]`) completes the TLS +handshake on both moq-tokio TLS dialers, noq and WebSocket, with or without a +pinned `Addr` and with or without a `tls_host_name` override. +[#4322](https://github.com/moq-dev/moq/pull/4322) fixes noq, where +`url::Host::to_string()` kept the URL brackets and rustls refused `[::1]` as a +server name. + +WebSocket likely already works without an override: every path, including the +pinned `connect_tls_override` one, hands tokio-tungstenite a bracketed URL, and +it strips the brackets before building the rustls name. The known gap is a bare +IPv6 override (`tls_host_name = "::1"`): `connect_tls_override` passes it to +`Url::set_host`, which rejects it, while noq accepts it. ## Plan -- Reproduce on WebSocket with a loopback `[::1]` listener and no override, - like #4322's pinned QUIC tests, before fixing. -- Check every place moq-tokio derives a TLS server name from a URL (WebSocket, - TCP, iroh, and any other dialer) and derive it the same way everywhere. A - shared helper is reasonable if more than one site needs it. +- Pin WebSocket with loopback `[::1]` tests like #4322's: unpinned and pinned + `Addr` with no override, and a bare `::1` override. Fix only what fails. +- Derive the TLS server name the same way on both dialers. A shared helper is + reasonable if both need it. - Keep the bracketed form wherever it is correct: the HTTP `Host` header and URL rebuilding. +- TCP is plaintext and iroh dials by endpoint id, so neither is in scope. Public API and wire: none.