diff --git a/quest/m1/audio-codecs/README.md b/quest/m1/audio-codecs/README.md index 3d3c619be3c..e6051c995d2 100644 --- a/quest/m1/audio-codecs/README.md +++ b/quest/m1/audio-codecs/README.md @@ -35,6 +35,12 @@ Encode mirrors decode: an `encode::backend` seam, `Codec::Aac` meaning AAC-LC at the input's layout, and platform encoders behind it. Opus encode stays mono/stereo. +The next merge from main conflicts in `rs/moq-audio/src/decode/decoder.rs`: +[#4442](https://github.com/moq-dev/moq/pull/4442) conceals one Opus frame on +loss there, while this line moved that logic into `decode/backend/libopus.rs`. +Port the fix by hand, taking the concealed duration from the multistream +packet rather than the single-stream call. + The core configuration and layout contracts land in main. These quests implement surround and backend dispatch on that contract; each platform then lands as its own decode and encode quest so verification stays per host. The diff --git a/quest/m1/cpp/README.md b/quest/m1/cpp/README.md index 75a1040092f..b20d4c9f7ea 100644 --- a/quest/m1/cpp/README.md +++ b/quest/m1/cpp/README.md @@ -68,6 +68,7 @@ Confirmed in [#4100](https://github.com/moq-dev/moq/pull/4100): - [Generator](/quest/m1/cpp/generator.md) - the uniffi 0.32 C++ generator with futures and expected-style errors, pinned and generating `cpp/ffi` in CI - [Package](/quest/m1/cpp/package.md) - the `cpp/moq` wrapper, CMake package, release tarball, interop client, and docs - [Cancel](/quest/m1/cpp/cancel.md) - a cancelled or consumed future reports `valid() == false`, like `std::future`, and a read of it aborts with a message naming the misuse +- [macOS alias check](/quest/m1/cpp/macos-alias-check.md) - `just cpp check` passes its alias step with the BSD `sed` macOS ships - [C++ standard](/quest/m1/cpp/cxx-standard.md) - a consumer that sets C++23 only on its own target links the package - [OBS migration](/quest/m1/cpp/obs.md) - the OBS plugin moves from libmoq handles and trampolines to the generated C++ diff --git a/quest/m1/cpp/macos-alias-check.md b/quest/m1/cpp/macos-alias-check.md new file mode 100644 index 00000000000..3bbca6e06ea --- /dev/null +++ b/quest/m1/cpp/macos-alias-check.md @@ -0,0 +1,17 @@ +# [XS] The alias check runs on macOS + +## Goal + +`just cpp check` passes its "every generated `moq::MoqFoo` has a `moq::Foo` +alias" step on macOS outside the dev shell, so the C++23 probe after it runs. +Today the second `sed -nE` in `cpp/justfile` matches with a backreference +(`= Moq\1;`), which BSD `sed` ignores, so the alias list comes back empty and +every type reports missing. CI runs Ubuntu with GNU `sed` and never sees it. + +## Plan + +Extract both names from each `using` line and compare them in `awk` (or +another portable tool) instead of a backreference in the pattern. Check it +with `/usr/bin/sed` first on PATH. + +Public API: none. Wire: none. diff --git a/quest/m1/ffi-shape/net.md b/quest/m1/ffi-shape/net.md index cfcf2da2e73..10212aa3013 100644 --- a/quest/m1/ffi-shape/net.md +++ b/quest/m1/ffi-shape/net.md @@ -14,6 +14,9 @@ are renamed. nested TLS, QUIC, and backoff records. Validate in `new`. Resolve defaults in Rust, since Go gets none; Option fields keep additions additive. This also retires Kotlin `Moq.connect`'s twelve named parameters. +- The client config carries the protocol versions to offer, as libmoq's + `moq_client_config.versions` already does (`rs/libmoq/src/api.rs`), so every + binding can pin or restrict versions. moq-ffi has no version setter today. - Objects that are only getters become records (`AnnounceUpdate` today). Handles with verbs (`Request`, `TrackRequest`, `GroupRequest`) stay objects. - `TrackProducer` drops `name`/`is_used`/`used`/`unused` for `demand()`. diff --git a/quest/m1/test-flakes-2.md b/quest/m1/test-flakes-2.md index 9e7520611f7..bbeeb0eec34 100644 --- a/quest/m1/test-flakes-2.md +++ b/quest/m1/test-flakes-2.md @@ -13,9 +13,12 @@ retry. `timeout_at(deadline, ...)`, so connect, TLS, announce, and subscribe share the budget with the read, and under load setup alone can spend it. - moq-cli `complete::tests::a_stage_broadcast_picks_the_catalog_to_read` - ([#4084](https://github.com/moq-dev/moq/pull/4084)) and + ([#4084](https://github.com/moq-dev/moq/pull/4084)), `the_catalog_format_on_the_line_is_honored` - ([#4089](https://github.com/moq-dev/moq/pull/4089)). + ([#4089](https://github.com/moq-dev/moq/pull/4089)), and + `a_relay_on_the_line_answers_broadcast`: both of the latter pair came back + empty after the fixed 1.5 s `CEILING` on a loaded runner + ([#4404](https://github.com/moq-dev/moq/pull/4404)). - moq-net `model::group::test::drop_unfinished_warns` counts WARNs through a global tracing capture, so another test's WARN, or a missed one, changes the count ([#4104](https://github.com/moq-dev/moq/pull/4104)). The @@ -32,6 +35,11 @@ retry. - `just test media` late join failed once after [#4181](https://github.com/moq-dev/moq/pull/4181): "joined at frame 111, 16 frames behind 127", against a budget of one GOP (15). +- moq-mux `container::ts::export_test::debounce_opens_without_a_media_clock` + died with SIGTERM once in a combined run. It is marked + `start_paused = true` but sleeps 1.2 s of real time, because the debounce + reads `crate::Clock`, which uses `std::time::Instant`, so the paused tokio + clock never reaches it. ## Plan @@ -46,6 +54,9 @@ retry. noq's timers from the test clock, whichever is smaller. Keep the one absolute 30 s deadline, matching the relay's `/fetch`; on a paused clock setup costs no time, so it can't spend the read's budget. +- moq-mux debounce: let the test drive `crate::Clock`'s time (a tokio + `Instant` under test, or an injected source) so the window passes on the + paused clock, and drop the real sleep. - WARN counting: capture per test (a scoped subscriber or a filter on the test's own span) instead of a process-global count. - The race test shares one port only so both transports sit behind one URL. diff --git a/quest/m2/README.md b/quest/m2/README.md index c52acf6f4d9..92416e8d45b 100644 --- a/quest/m2/README.md +++ b/quest/m2/README.md @@ -32,6 +32,7 @@ upstream release waits in [m4](/quest/m4/README.md). - [Audio loss recovery](/quest/m2/audio-loss-recovery.md) - prove a useful Opus recovery policy before exposing another option - [Opus implementation](/quest/m2/audio-opus-backend.md) - compare current codec quality, CPU, and optional build costs - [Latency ledger](/quest/m2/latency-ledger.md) - a session reports where its end-to-end audio delay went, stage by stage +- [JS LOC duration marker](/quest/m2/js-loc-duration-marker.md) - `@moq/loc`'s producer ends each video group with the empty duration frame, as moq-mux does - [JS discontinuity](/quest/m2/js-discontinuity.md) - on dev, JS `discontinuity()` without an end writes no cadence-estimated end, like Rust - [Synced data playback](/quest/m2/watch-data-sync.md) - js/watch releases JSON and binary payloads on the media playhead, and a slow data track holds media back - [Media Foundation decode](/quest/m2/audio-decode-mediafoundation.md) - Windows decodes HE-AAC, multichannel AAC, and what else the MFTs offer diff --git a/quest/m2/js-loc-duration-marker.md b/quest/m2/js-loc-duration-marker.md new file mode 100644 index 00000000000..f66d8a709c0 --- /dev/null +++ b/quest/m2/js-loc-duration-marker.md @@ -0,0 +1,20 @@ +# [S] JS LOC producer writes the duration marker + +## Goal + +`@moq/loc`'s `Producer` ends each video group with the empty frame that closes +its last frame's duration, as `moq-mux`'s LOC producer does after +[#4450](https://github.com/moq-dev/moq/pull/4450). Readers skip it from +`@moq/loc` 0.2.3 and `moq-mux` 0.10.0 onward (the Rust skip landed in +[#3575](https://github.com/moq-dev/moq/pull/3575)). + +## Plan + +The JS producer (`js/loc/src/index.ts`) has no frame kind, cut, or finish: it +closes a group on the next keyframe and on `close()`. Write the marker at both +points, and extend the producer tests to assert it and that the JS consumer +skips it. Low urgency: only a test and a `js/hang` re-export use the producer +today; `js/publish` does not. + +Public API: none. Wire: the same marker Rust writes. + diff --git a/quest/m2/play-drain-tail.md b/quest/m2/play-drain-tail.md index bed7d7e0ed9..905cb1b91cc 100644 --- a/quest/m2/play-drain-tail.md +++ b/quest/m2/play-drain-tail.md @@ -1,4 +1,4 @@ -# [XS] moq play plays a finished track's last samples +# [S] moq play plays a finished track's last samples ## Goal @@ -13,11 +13,13 @@ tolerates the gap. ## Plan The 10 ms stop exists because polling the last partial period costs a wakeup -per iteration and never settles. Fix it at the sink instead of the poll: let -a dropped or finished `moq_audio::playback::Sink` play out what it holds -before leaving the mix, or give it an end-of-stream that the mixer honors, so -`drain` no longer needs a threshold. If that belongs in moq-audio's playback -API, keep the change additive. +per iteration and never settles. Fix it at the sink instead of the poll +(maintainer decision, 2026-09-28): `Sink::finish` consumes the sink and +returns a `Drain` that resolves once the mixer has played everything the sink +held, then leaves the mix. `drain` awaits it and loses its threshold. Lowering +the threshold to zero is rejected: it is the wakeup spin above. The change to +moq-audio's playback API is additive; dropping a sink still leaves the mix +immediately. Tighten `an_audio_rendition_switch_leaves_no_gap` (the `play::fake::Recorder` already models the cut on drop) so the lost tail fails it, and add a finite