From aad26130391e00bedf3bf24c46d1df17b62bbe45 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 8 Oct 2026 23:34:23 -0700 Subject: [PATCH 1/2] quest: close the qos line; lag-histogram carries the port Co-Authored-By: Claude Opus 5.5 --- quest/m1/qos/lag-histogram.md | 21 +++++++++++++++++++++ quest/m1/quest-flat-lines.md | 7 ++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/quest/m1/qos/lag-histogram.md b/quest/m1/qos/lag-histogram.md index 1674ceebb4d..5b32eecc2ef 100644 --- a/quest/m1/qos/lag-histogram.md +++ b/quest/m1/qos/lag-histogram.md @@ -22,6 +22,27 @@ already lives on the line branch per-path `publisher.json` and `subscriber.json` map rows it writes today onto stats-split's totals and prefix tracks. +Decided 2026-10-09: #4133 closes without landing, since every code change it +has over `main` is this histogram; its code is kept on `wip/4133-lag-histogram` +as this quest's starting point. Porting it is not mechanical: + +- `main` moved to caller-supplied time (#4437) and removed the frozen test + clock (`model::clock::advance`). The sampler reads wall time in + `Registry::report`, when a `Frontier` opens, on `Delivery` acks, and in the + final sample in `Drop for FrontierInner`, which has no caller to supply a + time. Redesign those to take time from their callers, and give the final + sample an explicit close path. +- Untimed tracks (#4822): record `Production` only for timed frames. +- `max_age` became `max_delay` on subscriptions (#4917). + +Open review findings on #4133 to fix while porting: + +- A timestamp regression hides a stalled viewer. +- A copy served across a no-route gap stays watched. +- A partial write is charged the frame's full declared size. +- `Dropped::add` saturates instead of overflowing. +- Sweep dead frontier entries when the list fills. + Keep the histogram contract the dashboard reads: buckets keyed by upper edge (`"50ms"` to `"5s"`, then `"inf"`, empty buckets omitted), cumulative and monotonic so readers diff two samples and sum nodes bucket by bucket. Update diff --git a/quest/m1/quest-flat-lines.md b/quest/m1/quest-flat-lines.md index c29fa1443be..ccc1b33891b 100644 --- a/quest/m1/quest-flat-lines.md +++ b/quest/m1/quest-flat-lines.md @@ -69,9 +69,10 @@ Remaining: pin from `.2`, then check `OBS (macOS)`. - #4519 ffi-shape waits on [Bindings](/quest/m0/broadcast-epoch/bindings.md). - - #4133 qos: lag-splice landed on the line (#5009). Its egress `lag` - histogram splits into its own quest requiring stats-split (decided - 2026-10-08); follow the qos README for what the line lands without it. + - #4133 qos: closed without landing (2026-10-09). Every change it had over + `main` is the egress `lag` histogram, which + [Viewer lag histogram](/quest/m1/qos/lag-histogram.md) ports from the + branch once stats-split lands. Done when `flake.nix` pins the new quest, no `quest/*README` branch remains, and `quest check` passes. From 7b1d4e6ef6689ae86b6b2ecd039c1498f011b3c9 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 8 Oct 2026 23:36:24 -0700 Subject: [PATCH 2/2] quest: point lag-histogram and the qos README at the closed line Co-Authored-By: Claude Opus 5.5 --- quest/m1/qos/README.md | 13 ++++++------ quest/m1/qos/lag-histogram.md | 37 ++++++++++++++++++++--------------- 2 files changed, 28 insertions(+), 22 deletions(-) diff --git a/quest/m1/qos/README.md b/quest/m1/qos/README.md index 194378d5017..17e4a7521eb 100644 --- a/quest/m1/qos/README.md +++ b/quest/m1/qos/README.md @@ -38,15 +38,16 @@ This line only reports the counters. Decided (2026-10-06 audit): [stats totals and prefix tracks](/quest/m0/broadcast-epoch/stats-split.md) lands first, since it is m0 -and gates the release; #4133 rebases its histograms onto stats-split's totals -and prefix tracks rather than the per-path `publisher.json` and -`subscriber.json` map rows it writes today, which stats-split retires. -Rejected: #4133 first, which would make stats-split carry the lag histogram -and dropped counters across. +and gates the release; the lag histogram lands on stats-split's totals and +prefix tracks rather than the per-path `publisher.json` and +`subscriber.json` map rows, which stats-split retires. +Rejected: the histogram first, which would make stats-split carry the lag +histogram and dropped counters across. Decided (2026-10-08): the egress histogram is its own quest, [viewer lag histogram](/quest/m1/qos/lag-histogram.md), since every other -child reads it and it exists only on the line branch. +child reads it. The line's PR, #4133, closed without landing (2026-10-09); +its code is kept on `wip/4133-lag-histogram`. Decided (2026-09-28): the line's moq-stats changes break the published crate. Client stats left the line (2026-09-29) diff --git a/quest/m1/qos/lag-histogram.md b/quest/m1/qos/lag-histogram.md index 5b32eecc2ef..0d76c4f4762 100644 --- a/quest/m1/qos/lag-histogram.md +++ b/quest/m1/qos/lag-histogram.md @@ -14,17 +14,17 @@ last partial interval. ## Plan Decided 2026-10-08: split out of the QoS line so the dashboard and publisher -timeliness can require a histogram that exists on `main`. The implementation -already lives on the line branch -([#4133](https://github.com/moq-dev/moq/pull/4133)): the sampler (#4298, -`rs/moq-net/src/stats.rs`), the splice fixes (#5009), and the final sample -(#4451). This quest lands it on `main` once stats-split has, rebased from the -per-path `publisher.json` and `subscriber.json` map rows it writes today onto -stats-split's totals and prefix tracks. - -Decided 2026-10-09: #4133 closes without landing, since every code change it -has over `main` is this histogram; its code is kept on `wip/4133-lag-histogram` -as this quest's starting point. Porting it is not mechanical: +timeliness can require a histogram that exists on `main`. This quest lands it +on `main` once stats-split has, moved from the per-path `publisher.json` and +`subscriber.json` map rows it writes today onto stats-split's totals and +prefix tracks. + +Decided 2026-10-09: the QoS line +([#4133](https://github.com/moq-dev/moq/pull/4133)) closed without landing, +since every code change it had over `main` is this histogram. Its code is kept +on `wip/4133-lag-histogram` as this quest's starting point: the sampler +(#4298, `rs/moq-net/src/stats.rs`), the splice fixes (#5009), and the final +sample (#4451). Porting it is not mechanical: - `main` moved to caller-supplied time (#4437) and removed the frozen test clock (`model::clock::advance`). The sampler reads wall time in @@ -37,11 +37,16 @@ as this quest's starting point. Porting it is not mechanical: Open review findings on #4133 to fix while porting: -- A timestamp regression hides a stalled viewer. -- A copy served across a no-route gap stays watched. -- A partial write is charged the frame's full declared size. -- `Dropped::add` saturates instead of overflowing. -- Sweep dead frontier entries when the list fills. +- A timestamp regression hides a stalled viewer + ([3](https://github.com/moq-dev/moq/pull/4133#issuecomment-6053929743)). +- A copy served across a no-route gap stays watched + ([B](https://github.com/moq-dev/moq/pull/4133#issuecomment-6053929743)). +- A partial write is charged the frame's full declared size + ([P2](https://github.com/moq-dev/moq/pull/4133#pullrequestreview-5452586850)). +- `Dropped::add` should saturate instead of overflowing + ([comment](https://github.com/moq-dev/moq/pull/4133#discussion_r4215691174)). +- Bound the frontier list when `Registry::report` is not called + ([comment](https://github.com/moq-dev/moq/pull/4133#discussion_r4215691184)). Keep the histogram contract the dashboard reads: buckets keyed by upper edge (`"50ms"` to `"5s"`, then `"inf"`, empty buckets omitted), cumulative and