From d1c59423614d4b8552d2aff812b5b83eb440d79c Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 9 Oct 2026 00:23:35 -0700 Subject: [PATCH 1/4] quest: plan follow-ups from #5011 and #5070 Co-Authored-By: Claude Opus 5.5 --- quest/m1/README.md | 3 +++ quest/m1/ietf-legacy-updates.md | 7 +++---- quest/m1/request-id-order.md | 24 ++++++++++++++++++++++++ quest/m1/test-ts-check.md | 17 +++++++++++++++++ 4 files changed, 47 insertions(+), 4 deletions(-) create mode 100644 quest/m1/request-id-order.md create mode 100644 quest/m1/test-ts-check.md diff --git a/quest/m1/README.md b/quest/m1/README.md index 12192ca55f4..7cda2c14f96 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -62,6 +62,7 @@ were done or not worth their cost. - [Dogfood hosted worklets](/quest/m1/dogfood-assets.md) - moq.dev and the moq.pro dashboard host the worklets and call `assets()` after the release - [Media audio-tone check](/quest/m1/media-audio-tone.md) - the media lane's audio-tone check passes under load, fixed at its cause - [More tests under load](/quest/m1/test-flakes-2/README.md) - the second round of load-only failures, one quest per flake, fixed at the cause +- [Test TypeScript check](/quest/m1/test-ts-check.md) - `just check` type-checks the TypeScript harnesses under test/ - [moq-uring tests under load](/quest/m1/uring-tests-under-load.md) - uring tests pass while parallel checks share locked memory - [FFI runtime](/quest/m1/ffi-runtime.md) - moq-ffi drives moq on a multi-thread runtime instead of one thread - [Audio group duration](/quest/m1/audio-group-duration.md) - audio groups span at least 20 ms by default, so small frames don't mint a group each @@ -173,3 +174,5 @@ were done or not worth their cost. - [Datagram replay bound](/quest/m1/datagram-replay-bound.md) - a new Rust datagram subscriber starts within its max delay of the newest datagram, not at a minutes-old buffer - [Catalog colour](/quest/m1/color-catalog.md) - the catalog describes a rendition's colour and HDR properties, which the WebGPU HDR renderer reads - [WebGPU HDR](/quest/m1/webgpu-hdr.md) - HDR renditions play as HDR where the browser and display can show it, and tone-map to SDR elsewhere + +- [Request ID order](/quest/m1/request-id-order.md) - drafts 14 to 16 refuse a reused or lower Request ID in both languages \ No newline at end of file diff --git a/quest/m1/ietf-legacy-updates.md b/quest/m1/ietf-legacy-updates.md index 2529e0a5857..32f505589a8 100644 --- a/quest/m1/ietf-legacy-updates.md +++ b/quest/m1/ietf-legacy-updates.md @@ -14,10 +14,9 @@ it with REQUEST_OK or REQUEST_ERROR, and a refused d14 update ends the subscription with INTERNAL_ERROR. Remaining (maintainer, 2026-10-07, from #4961 and #5011): -- JS: #5011 routes updates to their target, but the d14-16 publisher never - reads the subscribe stream again, so an unread update keeps the stream from - reporting closed and a later UNSUBSCRIBE is lost. Read framed messages and - apply updates as Rust now does. Rebase #5011 onto that or fold it in. +- JS: #5011 routes updates to their target, and the d14-16 publisher reads + and discards them so a later UNSUBSCRIBE still closes the stream. Apply them + as Rust now does. - Drafts 15 and 16: an update aimed at a namespace or fetch request is skipped with no REQUEST_OK or REQUEST_ERROR; answer it. - Draft 14: every field is mandatory, so a narrowed start or end group looks diff --git a/quest/m1/request-id-order.md b/quest/m1/request-id-order.md new file mode 100644 index 00000000000..a48305dd951 --- /dev/null +++ b/quest/m1/request-id-order.md @@ -0,0 +1,24 @@ +# [S] A reused moq-transport Request ID is refused + +## Goal + +On drafts 14 to 16, `@moq/net` and `moq-net` refuse an incoming request whose +Request ID is not above every ID the peer already used, instead of accepting +any ID below the window's bound. A peer can no longer reuse an ID that named +an earlier request. + +## Plan + +Found while landing [#5011](https://github.com/moq-dev/moq/pull/5011); it +predates it and covers every request type. `js/net/src/ietf/adapter.ts` +deliberately tolerates reuse today ("A peer reusing IDs below the bound still +cannot hold more than the window open"), bounding only how many are open. + +- First confirm what drafts 14 to 16 require of an out-of-order or repeated + Request ID and which session error they name; follow that. +- Keep a high-water mark per peer and refuse anything at or below it, in both + languages, beside the existing window checks. +- Tests: a repeated ID and a lower ID are each refused with the drafts' error; + in-order IDs and the MAX_REQUEST_ID grant are unchanged. + +Public API: none. Wire: none (a stricter receiver). diff --git a/quest/m1/test-ts-check.md b/quest/m1/test-ts-check.md new file mode 100644 index 00000000000..890fef62d58 --- /dev/null +++ b/quest/m1/test-ts-check.md @@ -0,0 +1,17 @@ +# [XS] Checks type-check the TypeScript under test/ + +## Goal + +Every TypeScript harness under `test/` (such as `test/drain/drain.ts`) is +type-checked by `just check`, so a removed or renamed `@moq/*` API breaks the +PR that removes it instead of a nightly run. + +## Plan + +Found by [#5070](https://github.com/moq-dev/moq/pull/5070): `test/drain/drain.ts` +still called the deleted `writeString`, and only its review caught it. Today +`js/justfile`'s `check` runs each workspace package's `check` script, and +`test/drain` is neither a root workspace nor has one. Give each `test/` +TypeScript package a `tsc --noEmit` check that `just check` runs (as a +workspace or from the `test` justfile), and make sure the scoped `just check` +picks it up when a `js/` package it imports changes. From cbca1d845c40339e5a6599506a7520aabee36e3f Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 9 Oct 2026 09:56:28 -0700 Subject: [PATCH 2/4] quest: request-id-order notes the interop change Co-Authored-By: Claude Opus 5.5 --- quest/m1/request-id-order.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/quest/m1/request-id-order.md b/quest/m1/request-id-order.md index a48305dd951..c6e50f99c8d 100644 --- a/quest/m1/request-id-order.md +++ b/quest/m1/request-id-order.md @@ -21,4 +21,5 @@ cannot hold more than the window open"), bounding only how many are open. - Tests: a repeated ID and a lower ID are each refused with the drafts' error; in-order IDs and the MAX_REQUEST_ID grant are unchanged. -Public API: none. Wire: none (a stricter receiver). +Public API: none. Wire: no format change, but a stricter receiver closes +sessions with peers that reuse IDs today; report it as an interop change. From 675cd12575d5afdfbdaffa47b9082144cf512d8f Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 9 Oct 2026 10:08:13 -0700 Subject: [PATCH 3/4] quest: test-ts-check names the real workspace gap test/drain is a root workspace with no check script, and request-id-order says which IDs the high-water mark tracks. Co-Authored-By: Claude Opus 5.5 --- quest/m1/request-id-order.md | 4 ++-- quest/m1/test-ts-check.md | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/quest/m1/request-id-order.md b/quest/m1/request-id-order.md index c6e50f99c8d..086701934dd 100644 --- a/quest/m1/request-id-order.md +++ b/quest/m1/request-id-order.md @@ -16,8 +16,8 @@ cannot hold more than the window open"), bounding only how many are open. - First confirm what drafts 14 to 16 require of an out-of-order or repeated Request ID and which session error they name; follow that. -- Keep a high-water mark per peer and refuse anything at or below it, in both - languages, beside the existing window checks. +- Keep a high-water mark of the IDs the peer allocates and refuse anything at + or below it, in both languages, beside the existing window checks. - Tests: a repeated ID and a lower ID are each refused with the drafts' error; in-order IDs and the MAX_REQUEST_ID grant are unchanged. diff --git a/quest/m1/test-ts-check.md b/quest/m1/test-ts-check.md index 890fef62d58..8fc157fd21a 100644 --- a/quest/m1/test-ts-check.md +++ b/quest/m1/test-ts-check.md @@ -10,8 +10,9 @@ PR that removes it instead of a nightly run. Found by [#5070](https://github.com/moq-dev/moq/pull/5070): `test/drain/drain.ts` still called the deleted `writeString`, and only its review caught it. Today -`js/justfile`'s `check` runs each workspace package's `check` script, and -`test/drain` is neither a root workspace nor has one. Give each `test/` -TypeScript package a `tsc --noEmit` check that `just check` runs (as a -workspace or from the `test` justfile), and make sure the scoped `just check` -picks it up when a `js/` package it imports changes. +`js/justfile`'s `check` runs each root workspace's `check` script. +`test/drain` is a root workspace but has no `check` script or tsconfig, so it +is skipped; `test/wasm` and `test/interop/clients/js-native` also lack a +`check` script. Give each `test/` TypeScript workspace a `tsc --noEmit` check, +and make sure the scoped `just check` picks it up when a `js/` package it +imports changes. From b5cb78da9462fa9abc79311c942e72889fa776d3 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 9 Oct 2026 10:13:39 -0700 Subject: [PATCH 4/4] quest: test-ts-check covers standalone harnesses and dispatch scope Co-Authored-By: Claude Opus 5.5 --- quest/m1/test-ts-check.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/quest/m1/test-ts-check.md b/quest/m1/test-ts-check.md index 8fc157fd21a..6d60d5178a5 100644 --- a/quest/m1/test-ts-check.md +++ b/quest/m1/test-ts-check.md @@ -1,4 +1,4 @@ -# [XS] Checks type-check the TypeScript under test/ +# [S] Checks type-check the TypeScript under test/ ## Goal @@ -13,6 +13,12 @@ still called the deleted `writeString`, and only its review caught it. Today `js/justfile`'s `check` runs each root workspace's `check` script. `test/drain` is a root workspace but has no `check` script or tsconfig, so it is skipped; `test/wasm` and `test/interop/clients/js-native` also lack a -`check` script. Give each `test/` TypeScript workspace a `tsc --noEmit` check, -and make sure the scoped `just check` picks it up when a `js/` package it -imports changes. +`check` script. Standalone harnesses such as `test/max-age/client.ts` and +`test/interop/*.ts` sit outside any workspace tsconfig, and `sh/dispatch.sh`'s +`js` scope skips a change that touches only `test/drain/`. + +- Type-check every `test/` TypeScript file, workspace or standalone, with + `tsc --noEmit`. +- The scoped `just check` runs it when a harness or a `js/` package it imports + changes. +- Prove coverage once with a deliberate type error in each kind of harness.