From 14a995add156385e8946bb03a91c364d290af46e Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 15 Oct 2026 19:48:33 -0700 Subject: [PATCH 1/2] quest: claim fetch edge cases From be788af38169bbe7d6d45e4ef151262fd5c6b733 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 15 Oct 2026 19:50:15 -0700 Subject: [PATCH 2/2] quest: close the FETCH edge-case backport --- quest/m0/release-22/README.md | 4 --- quest/m1/README.md | 1 - quest/m1/fetch-edge-cases.md | 40 ---------------------------- quest/m1/subscribe-close-backport.md | 5 ++-- 4 files changed, 2 insertions(+), 48 deletions(-) delete mode 100644 quest/m1/fetch-edge-cases.md diff --git a/quest/m0/release-22/README.md b/quest/m0/release-22/README.md index 1a0f03f31ca..084122c9f55 100644 --- a/quest/m0/release-22/README.md +++ b/quest/m0/release-22/README.md @@ -53,7 +53,3 @@ track's latest group lost after rejoin. Decided 2026-10-13 (maintainer): the two draft-20 FETCH edge cases found on #5402 do not hold this cut; they land on `main` first and ship in a later 0.17 patch. - -## Related - -- [Draft-20 FETCH edge cases](/quest/m1/fetch-edge-cases.md) - the main-first fixes that follow this cut in a later 0.17 patch diff --git a/quest/m1/README.md b/quest/m1/README.md index 18f6a258a58..73d825ce70a 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -74,7 +74,6 @@ above them. - [Moxygen minimal interop](/quest/m1/smoke-moxygen.md) - announce-subscribe passes and the smoke lane stops hiding its failure - [Public relay diagnosis](/quest/m1/smoke-relays.md) - optional failed cells get attributed causes and focused first-party follow-ups - [FETCH max-delay](/quest/m1/fetch-max-delay.md) - historical readers obey publisher max-age and an optional tighter reader budget, including while holding a group -- [Draft-20 FETCH edge-case backport](/quest/m1/fetch-edge-cases.md) - backport the final-object and response-group fixes to a later 0.17 patch after main lands - [Subscribe-close backport](/quest/m1/subscribe-close-backport.md) - the same fix and the `race` loser fix on `release`, so closing a subscription during setup leaves no unhandled rejection in a later 0.17 patch - [Lite SETUP backport](/quest/m1/lite-setup-backport.md) - `release` closes a moq-lite session on a repeated SETUP parameter or a second Setup Stream, in a later 0.14.x patch (#5521) - [Claim answer epochs](/quest/m1/claim-answer-epochs.md) - a claim answers each output by publishing it at its exact path under its own epoch, so a restarted output never reaches a returning reader as the old one's cache diff --git a/quest/m1/fetch-edge-cases.md b/quest/m1/fetch-edge-cases.md deleted file mode 100644 index fd5263e4a77..00000000000 --- a/quest/m1/fetch-edge-cases.md +++ /dev/null @@ -1,40 +0,0 @@ -# [S] Backport draft-20 FETCH edge cases to 0.17 - -## Goal - -After the main fixes have merged, backport the two draft-20+ single-group -FETCH edge cases to `release` in a later 0.17 patch, preserving its published -API and carrying regression tests: - -- A range ending exactly at the final object of a finished track answers - FETCH_OK with End of Track set, so a relay handling it finishes its copy. -- A FETCH_OK whose End Location is past the requested group closes the - session with PROTOCOL_VIOLATION instead of being accepted, and never marks - that later group as the track's end. - -## Plan - -Found by Codex on the release backport -([#5402](https://github.com/moq-dev/moq/pull/5402#discussion_r4260963177) and -[#5402](https://github.com/moq-dev/moq/pull/5402#discussion_r4260963190)); the -same code is on `main`. - -The main fixes and regression tests landed in -[#5487](https://github.com/moq-dev/moq/pull/5487). Port them in a separate -backport PR targeting `release`: - -- Publisher: a bounded FETCH reaches the end only if the group is finished - and the read cursor reached or passed its final frame count. A start past - the final object must still be refused INVALID_RANGE on draft 20+. -- Subscriber: validate End Location stays within the requested group before - accepting the group or applying End of Track. - -The regression tests cover drafts 20 through 22, including a shorter-prefix -control and rejecting malformed responses both with and without End of Track. - -Decided 2026-10-13 (maintainer): this does not gate the next 0.17 cut on -[the release line](/quest/m0/release-22/README.md); the backport ships in a -later 0.17 patch. - -Public API: none. Wire: behavior only, within the existing draft-20 through -draft-22 FETCH form. diff --git a/quest/m1/subscribe-close-backport.md b/quest/m1/subscribe-close-backport.md index 96a28258f2d..798565cf988 100644 --- a/quest/m1/subscribe-close-backport.md +++ b/quest/m1/subscribe-close-backport.md @@ -20,9 +20,8 @@ Decided 2026-10-14: - the `#runResponses` fix from the main quest; - the `raceUntil` loser fix from ca8995280, its `js/signals` hunk and test only (the rest of #5232 is unrelated). -- It does not hold #5420; it ships in a later 0.17 patch, like the - [FETCH edge cases](/quest/m1/fetch-edge-cases.md). The `@moq/signals` and - `@moq/net` patch bumps happen at that cut. +- It does not hold #5420; it ships in a later 0.17 patch. The `@moq/signals` + and `@moq/net` patch bumps happen at that cut. - `#openSubscribe` keeps sending a SUBSCRIBE for a producer closed during setup. With both fixes that is a SUBSCRIBE cancelled at once, and `main` avoids it through its retire logic, so the backport stays minimal.