From 7f8752b895ce9367ebc6f94c04b267dd8c29b463 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 12:19:18 -0700 Subject: [PATCH 1/3] chore: claim release link quest Co-Authored-By: GPT-6.1 From 6f356b71db646d7caef5b684fcc80eba7e18e3ed Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 12:50:16 -0700 Subject: [PATCH 2/3] fix(nix): restore Linux release links Consume the upstream lld fix through nixpkgs and compile cargo-llvm-cov with the existing pinned Rust toolchain so its LLVM test helpers match the compiler profile format. Retire the completed release-link quest and reconcile its references. Co-Authored-By: GPT-6 --- flake.lock | 6 ++--- flake.nix | 8 +++++- quest/m0/README.md | 1 - quest/m0/audit-size.md | 8 +++--- quest/m0/ci/nightly-ffi-reuse.md | 9 ++----- quest/m0/release-link.md | 46 -------------------------------- quest/m1/README.md | 1 - quest/m1/audit-test-cost.md | 6 ++--- 8 files changed, 19 insertions(+), 66 deletions(-) delete mode 100644 quest/m0/release-link.md diff --git a/flake.lock b/flake.lock index 0f0ac9a871d..d42fd913099 100644 --- a/flake.lock +++ b/flake.lock @@ -35,11 +35,11 @@ }, "nixpkgs": { "locked": { - "lastModified": 1791487292, - "narHash": "sha256-tqM7xDEsaeK1p6VvRygeZ9LkQRpUUkbRT02BHv6hnTM=", + "lastModified": 1792488032, + "narHash": "sha256-RkAXQ3+a5rHMiP97Er7AawR1kvEXX9tK1mhiWedOPTc=", "owner": "NixOS", "repo": "nixpkgs", - "rev": "8edc0c72e3a38faf5434e40d1f19431125fe4b30", + "rev": "e513db7b0a65def6f6e17bb55195dfe510871944", "type": "github" }, "original": { diff --git a/flake.nix b/flake.nix index 7c2406df250..94a6cd3d471 100644 --- a/flake.nix +++ b/flake.nix @@ -158,7 +158,13 @@ cargo-hack cargo-nextest # Source-based test coverage (`just rs coverage`). - cargo-llvm-cov + # Its LLVM test helpers must read the compiler's profile format. + (cargo-llvm-cov.override { + rustPlatform = makeRustPlatform { + cargo = rust-toolchain; + rustc = rust-toolchain; + }; + }) # Browser/WASM bindings (rs/moq-wasm -> @moq/wasm via `just js wasm`). # Cargo.lock selects the matching schema version, independently of # nixpkgs' default wasm-bindgen-cli. diff --git a/quest/m0/README.md b/quest/m0/README.md index 3405b0db8e0..db059f5a736 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -89,7 +89,6 @@ Each lands its fixes in its own PR and plans only what needs a decision. - [CI cost and latency](/quest/m0/ci/README.md) - cloud CI runs only in the merge queue as one `just ci` pass, expensive checks run nightly and gate `release`, caches move to R2, and runners are chosen last - [Draft-22 release notices](/quest/m0/release-22/README.md) - tell testers and reporters which published releases contain their fixes -- [Release builds link](/quest/m0/release-link.md) - the Linux zigbuild release binaries and moq-gst packages link again after the 2026-10-11 nixpkgs bump, so the next release cut can publish - [web-transport releases the qmux fixes](/quest/m0/qmux-credit-upstream.md) - waiting on #412 to publish the patched 0.6.x that main adopts - [qmux credit](/quest/m0/qmux-credit.md) - main adopts qmux 0.6 credit and close fixes; the 0.5 backport is independent - [Broadcast epochs](/quest/m0/broadcast-epoch/README.md) - every first-party publisher that can restart mints a fresh route epoch, the newest wins a path, and only routes with the same epoch resume a subscription diff --git a/quest/m0/audit-size.md b/quest/m0/audit-size.md index 90867ddd98c..ffe05468205 100644 --- a/quest/m0/audit-size.md +++ b/quest/m0/audit-size.md @@ -27,10 +27,10 @@ baselines recorded here. It already attributes FFI growth with ### Checkpoint (2026-10-19, main at 2b28f5eac) -The nightly `sizes` job has never produced a report: it needs the Linux -release builds, which fail to link until -[release builds link](/quest/m0/release-link.md) lands, so it is skipped every -night. These baselines come from published release assets (x86_64 Linux, +At this checkpoint, the nightly `sizes` job had never produced a report +because the Linux release builds failed to link. The release toolchain is +now fixed; collect the next nightly report and remeasure main with +`cargo zigbuild`. These baselines come from published release assets (x86_64 Linux, stripped as shipped) and local builds of main (host linker instead of `cargo zigbuild`, so compare main to main, not to the release column). diff --git a/quest/m0/ci/nightly-ffi-reuse.md b/quest/m0/ci/nightly-ffi-reuse.md index a2c990f8427..574826b84ff 100644 --- a/quest/m0/ci/nightly-ffi-reuse.md +++ b/quest/m0/ci/nightly-ffi-reuse.md @@ -15,9 +15,8 @@ quest. ## Plan `moq-ffi-v0.4.16` (2026-10-16) was cut from a `release` without #5549, so it -ran the per-language workflows and verified nothing here. `Shipping sizes` -skips while the Linux release builds fail; see -[Release builds link again](/quest/m0/release-link.md). +ran the per-language workflows and verified nothing here. The Linux release +toolchain now links; verify `Shipping sizes` on the next scheduled Nightly. The first scheduled Nightly after the change (run 38897397428, 2026-10-16) already verified the dry-run side: the nested job names match the publisher @@ -35,7 +34,3 @@ From the first `Shipping sizes` run: - The Go static libraries keep their `release/go-lib-/` history keys, so the comparison shows no removed or added Go entries. - -## Related - -- [Release builds link again](/quest/m0/release-link.md) - unblocks `Shipping sizes` diff --git a/quest/m0/release-link.md b/quest/m0/release-link.md deleted file mode 100644 index 5778b20923a..00000000000 --- a/quest/m0/release-link.md +++ /dev/null @@ -1,46 +0,0 @@ -# [XS] Release builds link again on the current Nix toolchain - -## Goal - -The Linux release binaries (`moq-cli`, `moq-relay`) and the `moq-gst` -.deb/.rpm packages build with `cargo zigbuild` on `main`'s pinned Nix inputs, -for x86_64 and aarch64, so the next release cut from `main` can publish. - -## Plan - -Seen in the 2026-10-12 nightly (run 38276133321): `moq-cli / release / -Build`, `moq-relay / release / Build` and `moq-gst / Package .deb/.rpm` -fail on both Linux targets with `ld.lld: error: undefined symbol:` (an empty -name), referenced by `bcm.o:(aws_lc_0_45_0_OPENSSL_cpuid_setup)` in -`aws-lc-sys`. The nixpkgs bump in #5316 (d0736ec04) caused it. - -Root cause (found 2026-10-13): nixpkgs' lld 21.1.8 built with GCC 16 is -miscompiled. lld leaves `Symbol` fields uninitialized behind a memset GCC 16 -may drop, so a relocatable link (`ld.lld -r`) writes unnamed `STT_SECTION` -symbols with `SHN_UNDEF`, a different count each run. `zig cc -c` runs -`zig ld.lld -r` on every object it compiles, and zig links lld statically, -so zig's `bcm.o` carries the bad symbols. clang's own `bcm.o` is clean. -`ld.lld -r -o out.o bcm.o` on that clean object reproduces it with the -current nixpkgs lld 21 and not with the pre-bump one, lld 22, or -`staging-next`'s lld 21. Tracked upstream as NixOS/nixpkgs#571232; fixed by -NixOS/nixpkgs#568680. With `staging-next`'s (aaba2f7c9) `zig` and -`cargo-zigbuild`, `cargo zigbuild --locked --release --target -x86_64-unknown-linux-gnu.2.34 -p moq-relay` links. - -NixOS/nixpkgs#568680 is now in `nixpkgs-unstable`. Remaining work: bump -`flake.lock` (or take the weekly Dependabot nix bump), then confirm the same -command for `moq-relay`, `moq-cli` and `moq-gst` on both Linux targets. - -`release` still pins the pre-bump nixpkgs, so shipping releases are fine; -only the next `main` -> `release` merge carries the break. - -Decisions (maintainer, 2026-10-13): - -- ✅ No stopgap pin of `zig` or `cargo-zigbuild` to the pre-bump nixpkgs. - `release` is unaffected and the fix is already in `staging-next`. Revisit - only if a release from `main` must ship before the fix lands. -- ✅ No PR-time zigbuild check on `flake.lock` changes. The nightly caught - this within a day, and a full zigbuild per nix bump works against the CI - cost plan (#5426). - -Public API: none. Wire: none. diff --git a/quest/m1/README.md b/quest/m1/README.md index 0520ca02390..5abd46e28f0 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -48,7 +48,6 @@ lands before the cut. ## Required - [Epoch correctness](/quest/m0/broadcast-epoch/README.md) - publisher identity, duplicate suppression, and catalog pinning gate the breaking cut -- [Release builds](/quest/m0/release-link.md) - package artifacts can be built - [qmux credit](/quest/m0/qmux-credit.md) - dropped/stopped streams return credit and close is delivered - [moq-net follows announced instances](/quest/m1/net-announced-follow.md) - the Rust equivalent of JS `request(path, { announced: true })`, replacing the follow loops in moq-ffi and moq-c diff --git a/quest/m1/audit-test-cost.md b/quest/m1/audit-test-cost.md index 07bedab7d87..f675d1db7d8 100644 --- a/quest/m1/audit-test-cost.md +++ b/quest/m1/audit-test-cost.md @@ -52,9 +52,9 @@ What the m0 run (2026-10-19) learned; check these first: stats producer benchmark lint. - Planned by the m0 run: [redundant failover drift](/quest/m1/test-flakes-2/redundant-failover-drift.md), [macOS QUIC connects](/quest/m1/test-flakes-2/macos-quic-connect.md), and - [nightly media players](/quest/m1/media-engines-nightly.md). Owned - elsewhere: release builds by [release builds link](/quest/m0/release-link.md), - and Rust advisories by the dependency audit. The Nix wasm-bindgen CLI now + [nightly media players](/quest/m1/media-engines-nightly.md). Rust advisories + are owned by the dependency audit. The release toolchain now links, and + the Nix wasm-bindgen CLI now follows `Cargo.lock` ([#6031](https://github.com/moq-dev/moq/pull/6031)). Baselines from queue run From af620913d03afcb1f7f3793c1b5950bdc6e2e1a7 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 15:35:53 -0700 Subject: [PATCH 3/3] quest: record that the release toolchain fix landed Co-Authored-By: Claude Opus 5.5 --- quest/m0/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quest/m0/README.md b/quest/m0/README.md index 44229df93f2..65919d4ef03 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -68,7 +68,7 @@ source, and unwinding so a panic closes only its connection. Nightly on main (triaged 2026-10-13): two build breaks from 2026-10-11 get quests here. The nixpkgs bump broke the Linux zigbuild release builds (its -GCC 16 miscompiles lld 21, fixed upstream and waiting on `nixpkgs-unstable`), +GCC 16 miscompiles lld 21; fixed by bumping nixpkgs past the upstream fix), and fat LTO in the release profile broke the fuzz build. Audio quality has been red since it landed, against budgets recorded locally; re-measuring them on the runner moved here from Watch (maintainer, 2026-10-13). The other red jobs