From 77c8853fd7c3e927c2441bcd9f296e88b30fcbc1 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 17:13:53 -0700 Subject: [PATCH 1/5] quest: plan follow-ups from the 2026-10-20 handoff Add the Playwright-from-Nix quest, and fold the moq-srt wall-clock test and the msf/hangz cleanup into existing quests. Co-Authored-By: Claude Opus 5.5 --- quest/m1/README.md | 1 + quest/m1/compress/migrate.md | 5 +++++ quest/m1/playwright-nix.md | 36 ++++++++++++++++++++++++++++++++++++ quest/m1/time/crates.md | 4 ++++ 4 files changed, 46 insertions(+) create mode 100644 quest/m1/playwright-nix.md diff --git a/quest/m1/README.md b/quest/m1/README.md index da379f3f1e7..b8f160e39f7 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -125,6 +125,7 @@ lands before the cut. - [C++ and OBS package proof](/quest/m1/cpp-package-check.md) - the installed artifacts pass before their first release +- [Playwright browsers from Nix](/quest/m1/playwright-nix.md) - every Playwright check runs on Nix's Chromium locally and in CI, with npm pinned to match - [Nightly media players](/quest/m1/media-engines-nightly.md) - the Firefox and WebKit player rows pass, or an engine that cannot play leaves the nightly matrix - [Dead code and API surface audit](/quest/m1/audit-dead-code.md) - repeat the removal audit before the next major release diff --git a/quest/m1/compress/migrate.md b/quest/m1/compress/migrate.md index 7258fc9012f..259c20975f1 100644 --- a/quest/m1/compress/migrate.md +++ b/quest/m1/compress/migrate.md @@ -21,6 +21,11 @@ See the [epic](/quest/m1/compress/README.md) for the decisions. `rs/hang/src/timeline.rs` set `compress` on their one track. - Consumers: `rs/moq-mux/src/catalog/consumer.rs`, `rs/moq-cli` (`subscribe.rs`, `archive.rs`), and `js/watch` lose their hangz paths. + moq-mux's hang catalog adapter over `hang::catalog::Consumer` + ([#6114](https://github.com/moq-dev/moq/pull/6114)) drops its `format` + field and `CatalogFormat::HangZ` goes away; check whether + `catalog::msf::Consumer` can reuse hang's escaping-path check instead of + its own (decided 2026-10-20 instead of a separate quest). - moq-stats deltas: the `.z` side uses merge-patch deltas and the plain side does not. Keep deltas on the single track unless measuring stats bytes with and without them on a compressed track shows the saving is small; then diff --git a/quest/m1/playwright-nix.md b/quest/m1/playwright-nix.md new file mode 100644 index 00000000000..1608a5c77b3 --- /dev/null +++ b/quest/m1/playwright-nix.md @@ -0,0 +1,36 @@ +# [M] Playwright browsers from Nix + +## Goal + +Every Playwright check (`test/interop`, `test/video`, `test/p2p`, +`test/wasm`, `test/audio-quality`, `bench/browser`) runs in the root +devShell, locally on NixOS and in CI, against the Chromium build that Nix +provides. No check needs a hand-set `LD_LIBRARY_PATH` or a +`playwright install`. + +Out of scope: the Firefox and WebKit rows, which +[Nightly media players](/quest/m1/media-engines-nightly.md) owns, and +`test/smoke`, which keeps its own flake on purpose. + +## Plan + +Decided 2026-10-20 with the maintainer: + +- **Nix browsers, with npm pinned to match.** Today each package pins npm + `playwright ^1.64`, and the Chromium it downloads cannot load + `libglib-2.0.so.0` on NixOS (found while landing the browser rename check). + The root devShell exports `PLAYWRIGHT_BROWSERS_PATH` from + `playwright-driver.browsers` and `PLAYWRIGHT_VERSION` from + `playwright-driver.version`, as `test/smoke/flake.nix` already does. Every + package pins npm `playwright` to exactly that version, even when this + downgrades it (1.64 to nixpkgs' 1.63 today). The alternatives were rejected: + supplying host libraries to a downloaded Chromium (nix-ld or an FHS env) + depends on the host's library compatibility, and building playwright 1.64 + in the repo's overlay is maintenance for a gap nixpkgs closes on its own. +- **CI switches too.** The video, interop, wasm, and nightly workflows drop + `playwright install --with-deps` and the `just` recipes drop + `bunx playwright install chromium`, so CI and local runs share one Chromium. +- **The pin is enforced.** A check in `just check` fails when any package's + npm `playwright` differs from `PLAYWRIGHT_VERSION`, like + `test/smoke/freshness.sh`, so a nixpkgs bump cannot silently drift. +- No user-facing docs: this changes only contributor tooling. diff --git a/quest/m1/time/crates.md b/quest/m1/time/crates.md index c84e16ca454..da2c6197b07 100644 --- a/quest/m1/time/crates.md +++ b/quest/m1/time/crates.md @@ -42,6 +42,10 @@ rest of the workspace and public `SystemTime` fields still need migration. In pa SRT and WebRTC hand instants to third-party APIs on std's clock, and audio/video device threads block outside an async runtime; those boundaries still need clock support rather than a second host-clock read at each call site. +moq-srt's `a_late_payload_keeps_its_past_host_instant` compares a direct +`StdInstant::now()` with `host_instant(moq_net::time::now())`, so it can flake +under load; the SRT boundary migration rewrites it on controlled time +(decided 2026-10-20 instead of a separate flake quest). Public API: breaking wherever a crate exposes an instant or a time source. Wire: none. From e95c1d32574f1488fb19368d869f43e77ef1194b Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 20:20:59 -0700 Subject: [PATCH 2/5] quest: net-erase-transport also measures compile time Co-Authored-By: Claude Opus 5.5 --- quest/m1/net-erase-transport.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/quest/m1/net-erase-transport.md b/quest/m1/net-erase-transport.md index c66f52879df..7b54d7e5b55 100644 --- a/quest/m1/net-erase-transport.md +++ b/quest/m1/net-erase-transport.md @@ -4,8 +4,9 @@ `moq-net`'s session drivers compile once per binary, not once per transport session type and per crate that drives them. The relay, `libmoq_ffi.so`, -`libmoq`, the CLI and `@moq/wasm` shrink by the duplicated copies, and the -relay fan-out benchmark shows no regression beyond its noise. +`libmoq`, the CLI and `@moq/wasm` shrink by the duplicated copies, they +compile faster for the same reason, and the relay fan-out benchmark shows no +regression beyond its noise. ## Plan @@ -34,3 +35,10 @@ session benchmark, before and after. The async bodies must end up non-generic inside `moq-net`, or each awaiting crate still instantiates them. Re-measure with the audit's method: `nm` symbol attribution by crate path and by instantiating crate on an unstripped `profiling` build. + +Compile time (2026-10-20 compile-time audit, +[#6106](https://github.com/moq-dev/moq/pull/6106)): moq-tokio's dev build is +1,661,503 lines of LLVM IR, 43.2% of it moq-net session code instantiated per +transport and again under `ControlStreamAdapter`. The PR reports +`cargo llvm-lines` for moq-tokio and moq-relay before and after; line counts are +deterministic, so they stand in for build time on a shared host. From 2409bf64f575392757dc490301eabb100b5472fb Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 22:05:27 -0700 Subject: [PATCH 3/5] quest: list every Playwright install site, including portrait and the READMEs Co-Authored-By: Claude Opus 5.5 --- quest/m1/playwright-nix.md | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/quest/m1/playwright-nix.md b/quest/m1/playwright-nix.md index 1608a5c77b3..1a1655c0e4b 100644 --- a/quest/m1/playwright-nix.md +++ b/quest/m1/playwright-nix.md @@ -2,15 +2,28 @@ ## Goal -Every Playwright check (`test/interop`, `test/video`, `test/p2p`, -`test/wasm`, `test/audio-quality`, `bench/browser`) runs in the root -devShell, locally on NixOS and in CI, against the Chromium build that Nix -provides. No check needs a hand-set `LD_LIBRARY_PATH` or a -`playwright install`. +Every Playwright check runs in the root devShell, locally on NixOS and in CI, +against the Chromium build that Nix provides. No check needs a hand-set +`LD_LIBRARY_PATH` or a `playwright install`, and no contributor doc tells +anyone to run one. + +Inventory on `main` (2026-10-21); recheck with +`git grep -n "playwright install"` and every `package.json` that depends on +`playwright`: + +- Packages: `test/interop/clients/js`, `test/video`, `test/p2p`, `test/wasm`, + `test/audio-quality/clients/js`, `bench/browser`. +- Scripts: `test/interop/interop.sh`, `test/portrait/run.sh` (run in CI as + `just test portrait`), `test/audio-quality/{run,record}.sh`, + `bench/browser/run.sh`, and the `test/justfile` recipes. +- Workflows: `interop.yml`, `video.yml`, `wasm.yml`, `nightly.yml`. +- Docs: `test/interop/README.md` (says the devShell lacks Chromium) and + `test/wasm/README.md` (says to run `bunx playwright install chromium`). Out of scope: the Firefox and WebKit rows, which -[Nightly media players](/quest/m1/media-engines-nightly.md) owns, and -`test/smoke`, which keeps its own flake on purpose. +[Nightly media players](/quest/m1/media-engines-nightly.md) owns (its +`nightly.yml` step keeps installing those engines), and `test/smoke`, which +keeps its own flake on purpose. ## Plan @@ -27,10 +40,10 @@ Decided 2026-10-20 with the maintainer: supplying host libraries to a downloaded Chromium (nix-ld or an FHS env) depends on the host's library compatibility, and building playwright 1.64 in the repo's overlay is maintenance for a gap nixpkgs closes on its own. -- **CI switches too.** The video, interop, wasm, and nightly workflows drop - `playwright install --with-deps` and the `just` recipes drop - `bunx playwright install chromium`, so CI and local runs share one Chromium. +- **CI switches too.** Every workflow, script, and recipe in the inventory + drops its Chromium install, so CI and local runs share one Chromium. - **The pin is enforced.** A check in `just check` fails when any package's npm `playwright` differs from `PLAYWRIGHT_VERSION`, like `test/smoke/freshness.sh`, so a nixpkgs bump cannot silently drift. -- No user-facing docs: this changes only contributor tooling. +- The READMEs in the inventory say the devShell provides Chromium. No new + user-facing docs: this changes only contributor tooling. From 1efd7e020ddef2ef376fe8d371c856f472bb4496 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 23:06:19 -0700 Subject: [PATCH 4/5] quest: add the WASM runner and stale Chromium comments to the Playwright inventory Co-Authored-By: Claude Opus 5.5 --- quest/m1/playwright-nix.md | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/quest/m1/playwright-nix.md b/quest/m1/playwright-nix.md index 1a1655c0e4b..4a6098b7bae 100644 --- a/quest/m1/playwright-nix.md +++ b/quest/m1/playwright-nix.md @@ -7,18 +7,25 @@ against the Chromium build that Nix provides. No check needs a hand-set `LD_LIBRARY_PATH` or a `playwright install`, and no contributor doc tells anyone to run one. -Inventory on `main` (2026-10-21); recheck with -`git grep -n "playwright install"` and every `package.json` that depends on -`playwright`: +Inventory on `main` (2026-10-21). Recheck with `git grep -n -i chromium` +outside `quest/` and `test/smoke/`, keeping the hits that install, download, or +say where Chromium comes from (comments included), and with every +`package.json` that depends on `playwright`: - Packages: `test/interop/clients/js`, `test/video`, `test/p2p`, `test/wasm`, `test/audio-quality/clients/js`, `bench/browser`. - Scripts: `test/interop/interop.sh`, `test/portrait/run.sh` (run in CI as - `just test portrait`), `test/audio-quality/{run,record}.sh`, - `bench/browser/run.sh`, and the `test/justfile` recipes. -- Workflows: `interop.yml`, `video.yml`, `wasm.yml`, `nightly.yml`. -- Docs: `test/interop/README.md` (says the devShell lacks Chromium) and - `test/wasm/README.md` (says to run `bunx playwright install chromium`). + `just test portrait`), `test/wasm/run.sh`, + `test/audio-quality/{run,record}.sh`, `bench/browser/run.sh`, and the + `test/justfile` recipes. +- Workflows: `interop.yml`, `video.yml`, `wasm.yml`, `nightly.yml`, including + their comments that the devShell lacks Chromium. +- Docs and comments: `test/interop/README.md` (says the devShell lacks + Chromium), `test/wasm/README.md` (says to run + `bunx playwright install chromium`), `rs/justfile`'s browser clock recipe + (says `wasm.yml` installs it), `js/justfile`'s fairness sweep ("requires + installed Chromium"), and `test/video/renderer.browser.ts` (says + `just test video` installs it). Out of scope: the Firefox and WebKit rows, which [Nightly media players](/quest/m1/media-engines-nightly.md) owns (its @@ -45,5 +52,5 @@ Decided 2026-10-20 with the maintainer: - **The pin is enforced.** A check in `just check` fails when any package's npm `playwright` differs from `PLAYWRIGHT_VERSION`, like `test/smoke/freshness.sh`, so a nixpkgs bump cannot silently drift. -- The READMEs in the inventory say the devShell provides Chromium. No new - user-facing docs: this changes only contributor tooling. +- The docs and comments in the inventory say the devShell provides Chromium. + No new user-facing docs: this changes only contributor tooling. From 1bde809adf4b5c769338451f4e9af60699414232 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Tue, 20 Oct 2026 23:13:00 -0700 Subject: [PATCH 5/5] quest: carry Playwright's host-check override, and time the erase-transport build Co-Authored-By: Claude Opus 5.5 --- quest/m1/net-erase-transport.md | 6 ++++-- quest/m1/playwright-nix.md | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/quest/m1/net-erase-transport.md b/quest/m1/net-erase-transport.md index 7b54d7e5b55..cdc800d255b 100644 --- a/quest/m1/net-erase-transport.md +++ b/quest/m1/net-erase-transport.md @@ -40,5 +40,7 @@ Compile time (2026-10-20 compile-time audit, [#6106](https://github.com/moq-dev/moq/pull/6106)): moq-tokio's dev build is 1,661,503 lines of LLVM IR, 43.2% of it moq-net session code instantiated per transport and again under `ControlStreamAdapter`. The PR reports -`cargo llvm-lines` for moq-tokio and moq-relay before and after; line counts are -deterministic, so they stand in for build time on a shared host. +`cargo llvm-lines` for moq-tokio and moq-relay before and after, which is +deterministic, and a clean build of both crates before and after, run back to +back and reported as a ratio with the load average. Fewer IR lines alone do not +prove a faster build if the work moves to another compiler phase. diff --git a/quest/m1/playwright-nix.md b/quest/m1/playwright-nix.md index 4a6098b7bae..c9a2c2c25ac 100644 --- a/quest/m1/playwright-nix.md +++ b/quest/m1/playwright-nix.md @@ -40,8 +40,10 @@ Decided 2026-10-20 with the maintainer: `playwright ^1.64`, and the Chromium it downloads cannot load `libglib-2.0.so.0` on NixOS (found while landing the browser rename check). The root devShell exports `PLAYWRIGHT_BROWSERS_PATH` from - `playwright-driver.browsers` and `PLAYWRIGHT_VERSION` from - `playwright-driver.version`, as `test/smoke/flake.nix` already does. Every + `playwright-driver.browsers`, `PLAYWRIGHT_VERSION` from + `playwright-driver.version`, and `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS`, + as `test/smoke/flake.nix` already does; without the last, Playwright's host + check rejects the Nix browser on NixOS. Every package pins npm `playwright` to exactly that version, even when this downgrades it (1.64 to nixpkgs' 1.63 today). The alternatives were rejected: supplying host libraries to a downloaded Chromium (nix-ld or an FHS env)