From 7ea66dbd7915c9d22b9a8033cb3ed684a46bed07 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 21 Oct 2026 22:27:01 -0700 Subject: [PATCH 1/3] test(ci): permit build timings after the Check step Co-Authored-By: GPT-6 (cherry picked from commit 5f81edbc4c48f384428b0bdde453dfb6f2d78f40) --- sh/gh/setup.test.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sh/gh/setup.test.ts b/sh/gh/setup.test.ts index 90baf6a781a..a82bd325de7 100644 --- a/sh/gh/setup.test.ts +++ b/sh/gh/setup.test.ts @@ -31,8 +31,14 @@ for (const name of ["check"]) { const setup = job.steps.slice(scopeIndex + 1); expect(setup.some((step) => step.uses === "./.github/actions/nix")).toBe(true); expect(setup.some((step) => step.uses === "./.github/actions/rust-cache")).toBe(true); - expect(setup.at(-1)?.name).toBe(job.name); + expect(setup.filter((step) => step.run).at(-1)?.name).toBe(job.name); for (const step of setup) { + if (step.uses?.startsWith("actions/upload-artifact@")) { + expect(step.if?.replace(/^\$\{\{\s*|\s*\}\}$/g, "")).toBe( + "!cancelled() && steps.scope.outputs.rust == 'true'", + ); + continue; + } const output = step.uses === "./.github/actions/rust-cache" ? "rust" : "needed"; const hosted = step.uses === "./.github/actions/nix" ? " && runner.environment != 'self-hosted'" : ""; expect(step.if).toBe(`steps.scope.outputs.${output} == 'true'${hosted}`); From 82538f4c15bc5591b43cfbc99db46a08ec8a7843 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Wed, 21 Oct 2026 22:27:41 -0700 Subject: [PATCH 2/3] test(ci): count the bare QUIC driver feature lint Co-Authored-By: GPT-6 (cherry picked from commit 44e8b9c7fd4b5a7eff63233fb41b7b1cfb521a3c) --- sh/rs/select.test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sh/rs/select.test.py b/sh/rs/select.test.py index 7d7f9bee0cf..a38bf0cef3c 100644 --- a/sh/rs/select.test.py +++ b/sh/rs/select.test.py @@ -114,8 +114,8 @@ def trace(self, owner, *args): def test_tokio_keeps_extremes_and_crypto_contracts(self): boundary = self.trace("tokio") exhaustive = self.trace("tokio", "--all") - self.assertEqual(sum(call.startswith("clippy ") for call in boundary), 2) - self.assertEqual(sum(call.startswith("clippy ") for call in exhaustive), 10) + self.assertEqual(sum(call.startswith("clippy ") for call in boundary), 3) + self.assertEqual(sum(call.startswith("clippy ") for call in exhaustive), 12) self.assertEqual([call for call in boundary if not call.startswith("clippy ")], [call for call in exhaustive if not call.startswith("clippy ")]) From edd4dee775a4045816829f744f2102e9fb5644ad Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 22 Oct 2026 09:35:03 -0700 Subject: [PATCH 3/3] test(ci): keep timing uploads after the check Co-Authored-By: GPT-6 --- sh/gh/setup.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sh/gh/setup.test.ts b/sh/gh/setup.test.ts index a82bd325de7..4da7cd62312 100644 --- a/sh/gh/setup.test.ts +++ b/sh/gh/setup.test.ts @@ -32,8 +32,10 @@ for (const name of ["check"]) { expect(setup.some((step) => step.uses === "./.github/actions/nix")).toBe(true); expect(setup.some((step) => step.uses === "./.github/actions/rust-cache")).toBe(true); expect(setup.filter((step) => step.run).at(-1)?.name).toBe(job.name); - for (const step of setup) { + const checkIndex = setup.findIndex((step) => step.name === job.name); + for (const [index, step] of setup.entries()) { if (step.uses?.startsWith("actions/upload-artifact@")) { + expect(index).toBeGreaterThan(checkIndex); expect(step.if?.replace(/^\$\{\{\s*|\s*\}\}$/g, "")).toBe( "!cancelled() && steps.scope.outputs.rust == 'true'", );