diff --git a/quest/m1/README.md b/quest/m1/README.md index 5688f5a2000..3e454e61210 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -107,6 +107,8 @@ lite-07 stream type here. - [Interop finish](/quest/m1/interop-finish.md) - the interop matrix proves a clean broadcast finish across implementations - [Exporters follow a rendition to a new track](/quest/m1/export-rendition-rebind.md) - the fMP4, TS, MKV and FLV exporters rebuild a rendition whose resolved `track` or `broadcast` changes under the same ID - [Track live signal](/quest/m1/track-live.md) - a reader can wait for its track's feed to be live, so a player skips old cached groups while a fresh upstream subscription starts +- [Producers drop the phantom catalog type](/quest/m1/catalog-phantom.md) - moq-video, moq-audio and moq-mux producers lose an `E: CatalogExt` parameter that only `PhantomData` holds +- [JSON encoder options without a downcast](/quest/m1/json-encoder-options.md) - moq-mux's `json_snapshot` takes its `deltas` switch through a typed path any custom catalog entry can use, not an `Any` downcast - [moq-net compiles once](/quest/m1/net-erase-transport.md) - the session drivers stop monomorphizing per transport and per crate, saving several MiB of the relay, FFI library, `libmoq` and CLI - [Audio devices on ARM](/quest/m1/audio-devices-arm.md) - `just rs audio-devices` passes on the hosted ARM runner - [NixOS leaf dials its root](/quest/m1/nix-cluster-connect.md) - the NixOS relay module sets the cluster variable the relay reads, so a leaf joins its root instead of running standalone @@ -119,6 +121,9 @@ lite-07 stream type here. - [Subscribe update churn](/quest/m1/subscribe-update-churn.md) - a viewer sends SUBSCRIBE_UPDATE only on a meaningful change, measured after the publisher stall fix - [Interop coverage](/quest/m1/interop-coverage/README.md) - the riskiest moq-transport features moq-net exposes get cross-implementation tests over the even drafts 14 to 22 - [Runner nightly](/quest/m1/interop-runner-nightly.md) - a nightly job runs the upstream interop runner against our relay and clients, so newly registered implementations with a published image are tested without a change here +- [One Annex-B exporter](/quest/m1/annexb-export.md) - H.264 and H.265 Annex-B export share one private lifecycle, which also follows a rebound rendition +- [One CLI duration type](/quest/m1/cli-duration.md) - moq-cli, moq-bench and moq-relay reuse moq-tokio's public `cli::Duration` instead of their own copies +- [Shared watch and publish UI](/quest/m1/js-ui.md) - a new `@moq/ui` package holds the graph, buttons, and support banner that watch and publish duplicate - [CI workflow audit](/quest/m1/audit-ci.md) - every workflow and job gives a signal someone sees, at a cost that signal justifies, or is fixed, moved, or deleted - [Simplification audit](/quest/m1/audit-simplify.md) - repeat the simplification audit, starting with the m0 leftovers, before the next major release - [Artifact size audit](/quest/m1/audit-size.md) - binary, FFI, WASM, and bundle growth since the m0 run is explained, fixed, or planned diff --git a/quest/m1/annexb-export.md b/quest/m1/annexb-export.md new file mode 100644 index 00000000000..fbea6c71221 --- /dev/null +++ b/quest/m1/annexb-export.md @@ -0,0 +1,32 @@ +# [M] One Annex-B exporter for H.264 and H.265 + +## Goal + +moq-mux's H.264 and H.265 Annex-B exporters share one private lifecycle: +catalog updates, track selection, playhead tracking, keyframe joining, +parameter-set injection, payload conversion and completion. Only codec +configuration parsing and parameter sets stay per codec, and the public +codec wrappers keep their API. The shared lifecycle follows a rendition +whose resolved track or broadcast changes under the same ID. + +## Plan + +Found by the 2026-10-22 refactor audit (main at d44813cb7): +`rs/moq-mux/src/codec/h264/export.rs` and `h265/export.rs` are 433 and 432 +lines, their `poll_next` is identical, and only 171 diff lines differ once +the codec names are normalized. + +Decided 2026-10-22 (maintainer): land after the rendition rebind work, +which reworks the `ExportSource` these exporters use. Then make the shared +lifecycle follow a rebound rendition too, as that quest does for fMP4, TS, +MKV and FLV: reproduce the gap first with a test, and fix it once in the +shared code. Do not build a framework covering every container and codec. + +Tests cover configuration changes, rendition switching, parameter-set +injection, keyframe joining, completion, and the rebind. + +Public API: none. Wire: none. + +## Required + +- [Exporters follow a rendition to a new track](/quest/m1/export-rendition-rebind.md) - reworks `ExportSource` and sets the rebind pattern this follows diff --git a/quest/m1/catalog-phantom.md b/quest/m1/catalog-phantom.md new file mode 100644 index 00000000000..ae2bfe3e653 --- /dev/null +++ b/quest/m1/catalog-phantom.md @@ -0,0 +1,29 @@ +# [M] Producers drop the phantom catalog type + +## Goal + +Media and data producers that only reference the catalog through an erased +handle stop carrying its extension type. moq-video's and moq-audio's +`encode::Producer`, and moq-mux's `json::Snapshot`, `json::Stream`, +`binary::Snapshot` and `binary::Stream`, lose their `E: CatalogExt` +parameter, so callers with a custom catalog no longer thread a generic that +holds no data. Constructors stay generic over `E` where they take a typed +`Reserved` or catalog `Producer`. + +## Plan + +Found by the 2026-10-22 refactor audit (main at d44813cb7). `E` lives on +those types only as `PhantomData E>`: mux's `Listing` already erases +the entry type, and the encoders hold no catalog after construction. + +Decided 2026-10-22 (maintainer): drop `E` only where it is phantom. It stays +on `Reserved`, `Timebase`, the catalog `Producer` and capture +drivers that own a typed catalog, because those store it. JSON's `T` stays. +No dynamic dispatch is added. + +Update every consumer in the same PR: moq-ffi (`video.rs`, `audio.rs`, +`json.rs`, `flate.rs`), moq-c, and any example or test naming the parameter. +Add `MIGRATE.md` entries under `## Unreleased` for moq-video, moq-audio and +moq-mux. Do not claim a binary size change without measuring it. + +Public API: breaking Rust (type parameter removed). Wire: none. diff --git a/quest/m1/cli-duration.md b/quest/m1/cli-duration.md new file mode 100644 index 00000000000..305d83eb329 --- /dev/null +++ b/quest/m1/cli-duration.md @@ -0,0 +1,23 @@ +# [S] One CLI duration type + +## Goal + +moq-cli, moq-bench and moq-relay parse and serialize human-readable +durations through moq-tokio's `cli::Duration`, made public, instead of their +own copies. moq-relay's hand-written serde modules for `std::time::Duration` +fields use the existing `humantime-serde` dependency. + +## Plan + +Found by the 2026-10-22 refactor audit (main at d44813cb7): moq-cli's and +moq-bench's `duration.rs` are byte-identical, moq-relay's adds serde +adapters, and moq-tokio's `cli::Duration` is `pub(crate)` but already +implements `FromStr`, `Display` and serde. All three crates depend on +moq-tokio. + +Decided 2026-10-22 (maintainer): export moq-tokio's type over keeping +private per-crate wrappers. Preserve accepted units, zero handling, +formatting, and config file round-trips; check the CLI help and config docs +still match. + +Public API: adds `moq_tokio::cli::Duration`. Wire: none. diff --git a/quest/m1/js-ui.md b/quest/m1/js-ui.md new file mode 100644 index 00000000000..64ff05a8c04 --- /dev/null +++ b/quest/m1/js-ui.md @@ -0,0 +1,27 @@ +# [M] Shared watch and publish UI + +## Goal + +`@moq/watch` and `@moq/publish` import their identical presentation code +from a new `@moq/ui` package instead of each carrying a copy: the stats +graph, the button and settings button components, and the support element's +banner and details rendering. Capability detection stays in each product. + +## Plan + +Found by the 2026-10-22 refactor audit (main at d44813cb7): `ui/graph.ts` +(152 lines), `ui/components/button.ts` and `ui/components/settings-button.ts` +are byte-identical across `js/watch` and `js/publish`, and +`support/element.ts` differs in about 74 of its roughly 300 lines. + +Decided 2026-10-22 (maintainer): a narrow published `@moq/ui` package over +an `@moq/signals` subpath (media widgets would blur a generic library) or +publish depending on watch (wrong relationship). It holds presentation only. +Move other shared helpers only when identical and used by both. + +Validate both packages' independent published builds, DOM cleanup, and the +demo. The package gets a README; add it wherever the JS packages are listed +for publishing and docs. + +Public API: new `@moq/ui` package; `@moq/watch` and `@moq/publish` exports +unchanged. Wire: none. diff --git a/quest/m1/json-encoder-options.md b/quest/m1/json-encoder-options.md new file mode 100644 index 00000000000..93c93a99bd8 --- /dev/null +++ b/quest/m1/json-encoder-options.md @@ -0,0 +1,34 @@ +# [S] JSON encoder options without a downcast + +## Goal + +moq-mux's `json_snapshot` gets its encoder options (after refresh, the +`deltas` switch) without downcasting the config through `Any`. A custom +catalog entry that implements `IntoRendition` can set the same options as +`json::Config`, and the `'static` bound that only served the downcast goes +away. + +## Plan + +Found by the 2026-10-22 refactor audit (main at d44813cb7): +`delta_ratio_of` in `rs/moq-mux/src/json.rs` recovers the encoder ratio by +downcasting the generic config, and +[moq-dev/moq#6054](https://github.com/moq-dev/moq/pull/6054) renames it to +`deltas_of` but keeps the downcast. `IntoRendition` describes the catalog +entry, so encoder settings that are not catalog fields have no typed path. + +Decided 2026-10-22 (maintainer): the PR proposes the API shape once refresh +lands, rather than settling it now. Candidates considered: a separate +options argument (`json_snapshot(track, entry, json::Options)`, recommended +in the interview), or a builder on the returned handle before the first +update. Whichever lands, `json::Config` becomes a catalog entry builder +only, and moq-c's `json_snapshot`, the one in-repo caller that sets +`deltas`, follows. Add `MIGRATE.md` entries for moq-mux (and moq-c if its +API changes). + +Public API: breaking Rust (moq-mux `json_snapshot` signature, `json::Config` +fields). Wire: none. + +## Required + +- [Producers drop the phantom catalog type](/quest/m1/catalog-phantom.md) - edits the same `json::Snapshot` signature