From c6a15862fc4c0219e70a4c744662d2b8e367b569 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 22 Oct 2026 09:27:15 -0700 Subject: [PATCH 1/4] chore(quest): claim quest/m0/release-backports/parsing.md Quest-Claim: e1a4265cd26a7f68 From 5f9887698df9e64f761d0bde76db599e73ac07d5 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 22 Oct 2026 09:41:30 -0700 Subject: [PATCH 2/4] quest: track landing of the bounded parsing backport Co-Authored-By: GPT-6 --- quest/m0/release-backports/parsing.md | 37 +++++++++++++++------------ 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/quest/m0/release-backports/parsing.md b/quest/m0/release-backports/parsing.md index 4cfec01cd35..ecb56c87dad 100644 --- a/quest/m0/release-backports/parsing.md +++ b/quest/m0/release-backports/parsing.md @@ -1,4 +1,4 @@ -# [S] Backport bounded JS certificate and path parsing +# [XS] Land the bounded JS parsing backport ## Goal @@ -8,20 +8,25 @@ Valid inputs retain the published behavior and API. ## Plan -Decided 2026-10-22 (maintainer): port the JS input-hardening portion of -[moq-dev/moq#6084](https://github.com/moq-dev/moq/pull/6084) as a focused -backport. Its publishing changes already protect workflow-run events from -main and need no release backport. +The implementation is ready in +[moq-dev/moq#6349](https://github.com/moq-dev/moq/pull/6349), targeting `release`. +Review and land that PR, then remove this quest and its links once the release +branch contains the fix. Publication and version bumps remain with the release +owners. -Release 36f392f492 still uses a lazy certificate-armor regex and calls -parts(path).length before rejecting excess path components. Repeated BEGIN -markers without an END cause repeated scans, while slash-heavy paths create -an unnecessary allocation for every part. +The backport ports the JS input-hardening portion of +[moq-dev/moq#6084](https://github.com/moq-dev/moq/pull/6084). Its publishing +changes already protect workflow-run events from main and need no release +backport. Public API and wire formats are unchanged. The consumers are +certificate-hash connection setup and outgoing path encoding in `@moq/net`. -Reproduce both costs on release, then port the linear delimiter search and -early separator count with their edge-case coverage. Keep the existing path -limit and PEM acceptance contract. Measure increasing malformed input sizes -with the repository's benchmark conventions so parsing growth remains -visible; unit tests should assert behavior, not elapsed time. The consumers -are certificate-hash connection setup and outgoing path encoding in -@moq/net. Public API and wire formats are unchanged. +Release-side reproduction on Bun 1.4.2 measured repeated BEGIN markers from +7,168 to 458,752 bytes at 0.51 ms to 3.81 s before, versus 0.014 ms to 0.45 ms +after. Path rejection from 512 to 32,768 bytes fell from 19 to 295 microseconds +to roughly 2 to 3 microseconds. These are best-of-five samples on a shared +host; the benchmark reports growth without a timing gate. + +`just ci check`, `just ci test`, 50 focused certificate/path tests, and the +malformed-input benchmark passed in the active Nix development shell. The PR +adds behavioral edge cases and wires `just js bench parsing` into its nightly +workflow. Release CI and review still gate landing. From 8bdf377b1724355a81496b882175c8c2340df80d Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 22 Oct 2026 11:41:48 -0700 Subject: [PATCH 3/4] chore(quest): finish the JS input parsing release backport quest moq-dev/moq#6349 merged into release, so the quest is complete. Co-Authored-By: Claude Opus 5.5 --- quest/m0/release-backports/README.md | 1 - quest/m0/release-backports/parsing.md | 32 --------------------------- 2 files changed, 33 deletions(-) delete mode 100644 quest/m0/release-backports/parsing.md diff --git a/quest/m0/release-backports/README.md b/quest/m0/release-backports/README.md index d2f54d4c891..ed711e3357c 100644 --- a/quest/m0/release-backports/README.md +++ b/quest/m0/release-backports/README.md @@ -48,7 +48,6 @@ findings; expanding this shortlist needs a separate scope decision. ## Required - [TLS dependencies](/quest/m0/release-backports/tls.md) - release takes the targeted WebPKI fixes already on main -- [JS input parsing](/quest/m0/release-backports/parsing.md) - malformed certificates and paths cannot trigger disproportionate parsing work - [FFI cancellation](/quest/m0/release-backports/ffi-cancellation.md) - cancelled reads and accepts leave the next event for the next caller ## Related diff --git a/quest/m0/release-backports/parsing.md b/quest/m0/release-backports/parsing.md deleted file mode 100644 index ecb56c87dad..00000000000 --- a/quest/m0/release-backports/parsing.md +++ /dev/null @@ -1,32 +0,0 @@ -# [XS] Land the bounded JS parsing backport - -## Goal - -Release's JS connection code rejects malformed certificates and paths without -quadratic PEM scanning or allocating one string for every path separator. -Valid inputs retain the published behavior and API. - -## Plan - -The implementation is ready in -[moq-dev/moq#6349](https://github.com/moq-dev/moq/pull/6349), targeting `release`. -Review and land that PR, then remove this quest and its links once the release -branch contains the fix. Publication and version bumps remain with the release -owners. - -The backport ports the JS input-hardening portion of -[moq-dev/moq#6084](https://github.com/moq-dev/moq/pull/6084). Its publishing -changes already protect workflow-run events from main and need no release -backport. Public API and wire formats are unchanged. The consumers are -certificate-hash connection setup and outgoing path encoding in `@moq/net`. - -Release-side reproduction on Bun 1.4.2 measured repeated BEGIN markers from -7,168 to 458,752 bytes at 0.51 ms to 3.81 s before, versus 0.014 ms to 0.45 ms -after. Path rejection from 512 to 32,768 bytes fell from 19 to 295 microseconds -to roughly 2 to 3 microseconds. These are best-of-five samples on a shared -host; the benchmark reports growth without a timing gate. - -`just ci check`, `just ci test`, 50 focused certificate/path tests, and the -malformed-input benchmark passed in the active Nix development shell. The PR -adds behavioral edge cases and wires `just js bench parsing` into its nightly -workflow. Release CI and review still gate landing. From 29a07c1dfdc0691f0a765336efffd885bccf8e02 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 22 Oct 2026 13:46:55 -0700 Subject: [PATCH 4/4] chore(quest): finish the focused release backports epic All three children landed on release (moq-dev/moq#6347, #6349, #6355) with green release CI, and the release-plz PR carries them, so the epic's reconciliation work is done. Co-Authored-By: Claude Opus 5.5 --- quest/m0/README.md | 1 - quest/m0/release-backports/README.md | 54 ---------------------------- quest/m0/release-fixed-delay.md | 3 +- 3 files changed, 1 insertion(+), 57 deletions(-) delete mode 100644 quest/m0/release-backports/README.md diff --git a/quest/m0/README.md b/quest/m0/README.md index 5c2df85f437..6c9774abb5b 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -41,7 +41,6 @@ Each lands its fixes in its own PR and plans only what needs a decision. ## Required - [Broadcast epochs](/quest/m0/broadcast-epoch/README.md) - every first-party publisher that can restart mints a fresh route epoch, the newest wins a path, and only routes with the same epoch resume a subscription -- [Focused release backports](/quest/m0/release-backports/README.md) - TLS, parser, and FFI cancellation fixes preserve the current release API; the fixed-delay backport has merged - [web-transport-proto 0.6.3](/quest/m0/web-transport-proto-0.6.3.md) - `main` and `release` lock the upstream release that bounds decoded CONNECT headers, so a peer can't make a relay hold megabytes per session before auth - [qmux 0.5.3](/quest/m0/qmux-0.5.3.md) - crates.io publishes qmux 0.5.3 with the builder session config the release backport of #5609 needs - [Release shutdown backport](/quest/m0/ffi-shutdown-backport.md) - `release` publishes a non-breaking moq-ffi with an async `drain()` and qmux sessions on the QUIC stream limit diff --git a/quest/m0/release-backports/README.md b/quest/m0/release-backports/README.md deleted file mode 100644 index a33b778944b..00000000000 --- a/quest/m0/release-backports/README.md +++ /dev/null @@ -1,54 +0,0 @@ -# Backport focused fixes to the current release - -## Goal - -The current release line carries the selected security, cancellation, and -playback fixes from main while preserving its published APIs and wire -compatibility. These patch backports can ship before the next breaking cut. - -## Plan - -Decided 2026-10-22 (maintainer): focused backports, rather than a broader -stabilization audit. The three children are independently landable. -The existing fixed-delay quest retains ownership of its release deploy. - -The comparison used main -[d44813cb70](https://github.com/moq-dev/moq/commit/d44813cb703bf0d5366266ae8206f794856c69f8) -and release -[36f392f492](https://github.com/moq-dev/moq/commit/36f392f492f571454e5abc0e441ddc0168f16477). -The findings are source comparisons, not release-side reproductions or a -release-clear verdict. Each implementation reproduces its behavior and ports -only the fix, with release-compatible tests and the relevant release checks. -New defects go to main first. Do not import main's transport or API rewrites. - -The fixed-delay backport -[moq-dev/moq#6217](https://github.com/moq-dev/moq/pull/6217) merged into release -as [fd26b8ffec](https://github.com/moq-dev/moq/commit/fd26b8ffec) during planning; -it needs no additional implementation quest. - -The publishing-workflow changes in -[moq-dev/moq#6084](https://github.com/moq-dev/moq/pull/6084) need no backport: -GitHub runs workflow_run from the default branch, where the fix already -landed. Release-branch push/dispatch paths use their own github.sha, so -changing the release copy adds no protection for a workflow-run checkout. - -This epic's remaining work is to reconcile the landed backports on the -release candidate, confirm their checks, and hand the commit inventory to -the release process. Publication and version bumps stay with the existing -release owners. This does not add dependencies to the breaking-cut quest. - -Reuse the existing QPACK and draining-shutdown quests below. Their upstream -publication conditions remain their own blockers; they do not block these -independent fixes. The resubscribe investigation in -[moq-dev/moq#6285](https://github.com/moq-dev/moq/pull/6285) reports a benchmark -artifact, so it adds no production backport here. The broader release audit -in [moq-dev/moq#6311](https://github.com/moq-dev/moq/pull/6311) keeps its own -findings; expanding this shortlist needs a separate scope decision. - -## Related - -- [Fixed playback delay](/quest/m0/release-fixed-delay.md) - the merged behavior-only backport reaches moq.dev with its release deploy -- [QPACK bound](/quest/m0/web-transport-proto-0.6.3.md) - existing upstream dependency fix for decoded CONNECT headers -- [Draining shutdown](/quest/m0/ffi-shutdown-backport.md) - existing additive drain API and qmux stream-limit backport -- [Resubscribe investigation](/quest/m0/release-resubscribe-hang.md) - benchmark correction and investigation retirement retain their existing owner -- [Release execution](/quest/m2/release/README.md) - reconcile release-only fixes through the documented merge sequence at the breaking cut diff --git a/quest/m0/release-fixed-delay.md b/quest/m0/release-fixed-delay.md index 2998ad08224..ea16a67b508 100644 --- a/quest/m0/release-fixed-delay.md +++ b/quest/m0/release-fixed-delay.md @@ -12,8 +12,7 @@ contains the fix and numeric selections no longer include those estimates. The implementation merged into release in [moq-dev/moq#6217](https://github.com/moq-dev/moq/pull/6217). Verify its release deploy reaches moq.dev, then retire this quest; no duplicate backport is -needed. The [focused backports](/quest/m0/release-backports/README.md) track -the other selected fixes. +needed. The backport preserves the behavior from [moq-dev/moq#4162](https://github.com/moq-dev/moq/pull/4162) without its