diff --git a/quest/m1/test-flakes-2/README.md b/quest/m1/test-flakes-2/README.md index a47faa80a19..451e07f078d 100644 --- a/quest/m1/test-flakes-2/README.md +++ b/quest/m1/test-flakes-2/README.md @@ -41,7 +41,7 @@ Public API: none. Wire: none. - [Union renewal](/quest/m1/test-flakes-2/auth-union-renewal.md) - the JS subscriber never leaves a torn REQUEST_UPDATE on the stream - [Media resource instrumentation](/quest/m1/test-flakes-2/resource-instrumentation.md) - the media test stops seeing a playing player report nothing to release -- [Interop cpp to js budget](/quest/m1/test-flakes-2/interop-cpp-js.md) - the cpp -> js cell finishes inside its 30 s budget, fixed at its cause +- [Tone check grace](/quest/m1/test-flakes-2/tone-grace.md) - the interop tone check charges its grace only for audible playback, so a refilling ring under CPU starvation is not a failure - [Relay tests in one process](/quest/m1/test-flakes-2/relay-one-process.md) - moq-relay's integration binary passes under plain `cargo test`, not only nextest ## Related diff --git a/quest/m1/test-flakes-2/interop-cpp-js.md b/quest/m1/test-flakes-2/interop-cpp-js.md deleted file mode 100644 index d1fb9ccd257..00000000000 --- a/quest/m1/test-flakes-2/interop-cpp-js.md +++ /dev/null @@ -1,15 +0,0 @@ -# [S] The interop matrix's cpp to js cell stays inside its budget - -## Goal - -The `cpp -> js` cell of `just test interop --all` finishes inside its 30 s -budget on CI, fixed at its cause rather than by raising the budget. - -## Plan - -It took 38 s once in a CI Interop dispatch while working -[moq-dev/moq#6302](https://github.com/moq-dev/moq/pull/6302) (run 39734065658). -Find which phase overran (C++ publisher start, the browser's first frame, or -teardown) from that run's log first, then reproduce under load. - -Public API: none expected. Wire: none. diff --git a/quest/m1/test-flakes-2/tone-grace.md b/quest/m1/test-flakes-2/tone-grace.md new file mode 100644 index 00000000000..509bf93c4e2 --- /dev/null +++ b/quest/m1/test-flakes-2/tone-grace.md @@ -0,0 +1,23 @@ +# [S] The interop tone check charges its grace only for audible playback + +## Goal + +The JS interop driver's tone check fails only when audio that played was +silent or wrong, never because the player was still refilling its ring. Under +CPU starvation a browser cell waits out the re-stall instead of failing fast +with silence or a false "wrong tone". + +## Plan + +Found while closing the cpp to js budget flake +([moq-dev/moq#6442](https://github.com/moq-dev/moq/pull/6442)), never seen in +CI. With 8 browsers on 2 CPUs, 7 of 500+ main browser cells failed in under +12 s: the auto playout delay rose to 1 to 5 s, the ring re-stalled to refill, +and the 3 s `TONE_GRACE_MS` in `test/interop/clients/js/driver.ts` expired on +silence. Once it read stuttered audio as a wrong tone. + +Reproduce it under the same starvation, then measure the grace from audible +playback (the player's own stalled/playing state) rather than wall time since +the check began, keeping the overall cell budget unchanged. + +Public API: none. Wire: none.