From cf56ea53d687f0f34ed73d6cd61b3f22a0818024 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 22 Oct 2026 19:01:03 -0700 Subject: [PATCH 1/3] chore(quest): claim quest/m1/test-flakes-2/interop-cpp-js.md Quest-Claim: 1f719bcfbd274311 From 8b3211f6605a2771a8cf86c8e77295ff77229116 Mon Sep 17 00:00:00 2001 From: Luke Curley <432854+kixelated@users.noreply.github.com> Date: Thu, 22 Oct 2026 20:27:38 -0700 Subject: [PATCH 2/3] quest: close the cpp -> js interop budget flake, fixed by #6231 The 38 s cell in run 39734065658 was a stalled player, not a slow one: the browser decoded 3 video frames and no audio for 30 s. Under load the C++ publisher fell back to WebSocket, and crates.io qmux 0.6 never returned connection credit for bytes a stopped or dropped stream left unread. Every subscription the relay cancelled as the fast subscribers left leaked its window, until the publisher could not send. The in-tree qmux on the QUIC stream state machine (#6231) returns that credit, and `credit_returns_for_unread_and_stopped_streams` covers it. Reproduced with a WebSocket publisher, eight short-lived subscribers, and one browser on two CPUs: 3/12 browser cells stall at #6231's parent and at the failing commit, 0/20 at #6231, 0/28 on main. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01EeyiEy5FWz3z44DYZVo7vU --- quest/m1/test-flakes-2/README.md | 1 - quest/m1/test-flakes-2/interop-cpp-js.md | 15 --------------- 2 files changed, 16 deletions(-) delete mode 100644 quest/m1/test-flakes-2/interop-cpp-js.md diff --git a/quest/m1/test-flakes-2/README.md b/quest/m1/test-flakes-2/README.md index ca2565fd675..99f73847f85 100644 --- a/quest/m1/test-flakes-2/README.md +++ b/quest/m1/test-flakes-2/README.md @@ -42,7 +42,6 @@ Public API: none. Wire: none. - [Union renewal](/quest/m1/test-flakes-2/auth-union-renewal.md) - the JS subscriber never leaves a torn REQUEST_UPDATE on the stream - [One process](/quest/m1/test-flakes-2/one-process.md) - no test writes process-wide env or unwraps the crypto provider install - [Media resource instrumentation](/quest/m1/test-flakes-2/resource-instrumentation.md) - the media test stops seeing a playing player report nothing to release -- [Interop cpp to js budget](/quest/m1/test-flakes-2/interop-cpp-js.md) - the cpp -> js cell finishes inside its 30 s budget, fixed at its cause ## Related diff --git a/quest/m1/test-flakes-2/interop-cpp-js.md b/quest/m1/test-flakes-2/interop-cpp-js.md deleted file mode 100644 index d1fb9ccd257..00000000000 --- a/quest/m1/test-flakes-2/interop-cpp-js.md +++ /dev/null @@ -1,15 +0,0 @@ -# [S] The interop matrix's cpp to js cell stays inside its budget - -## Goal - -The `cpp -> js` cell of `just test interop --all` finishes inside its 30 s -budget on CI, fixed at its cause rather than by raising the budget. - -## Plan - -It took 38 s once in a CI Interop dispatch while working -[moq-dev/moq#6302](https://github.com/moq-dev/moq/pull/6302) (run 39734065658). -Find which phase overran (C++ publisher start, the browser's first frame, or -teardown) from that run's log first, then reproduce under load. - -Public API: none expected. Wire: none. From c61cff50b8c602c03ef25e08d2d77d4a0fe1b6ec Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 23 Oct 2026 11:31:10 -0700 Subject: [PATCH 3/3] quest: record the tone-check grace flake Co-Authored-By: Claude Opus 5.5 --- quest/m1/test-flakes-2/README.md | 1 + quest/m1/test-flakes-2/tone-grace.md | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 quest/m1/test-flakes-2/tone-grace.md diff --git a/quest/m1/test-flakes-2/README.md b/quest/m1/test-flakes-2/README.md index 0a2ba4ba21d..451e07f078d 100644 --- a/quest/m1/test-flakes-2/README.md +++ b/quest/m1/test-flakes-2/README.md @@ -41,6 +41,7 @@ Public API: none. Wire: none. - [Union renewal](/quest/m1/test-flakes-2/auth-union-renewal.md) - the JS subscriber never leaves a torn REQUEST_UPDATE on the stream - [Media resource instrumentation](/quest/m1/test-flakes-2/resource-instrumentation.md) - the media test stops seeing a playing player report nothing to release +- [Tone check grace](/quest/m1/test-flakes-2/tone-grace.md) - the interop tone check charges its grace only for audible playback, so a refilling ring under CPU starvation is not a failure - [Relay tests in one process](/quest/m1/test-flakes-2/relay-one-process.md) - moq-relay's integration binary passes under plain `cargo test`, not only nextest ## Related diff --git a/quest/m1/test-flakes-2/tone-grace.md b/quest/m1/test-flakes-2/tone-grace.md new file mode 100644 index 00000000000..509bf93c4e2 --- /dev/null +++ b/quest/m1/test-flakes-2/tone-grace.md @@ -0,0 +1,23 @@ +# [S] The interop tone check charges its grace only for audible playback + +## Goal + +The JS interop driver's tone check fails only when audio that played was +silent or wrong, never because the player was still refilling its ring. Under +CPU starvation a browser cell waits out the re-stall instead of failing fast +with silence or a false "wrong tone". + +## Plan + +Found while closing the cpp to js budget flake +([moq-dev/moq#6442](https://github.com/moq-dev/moq/pull/6442)), never seen in +CI. With 8 browsers on 2 CPUs, 7 of 500+ main browser cells failed in under +12 s: the auto playout delay rose to 1 to 5 s, the ring re-stalled to refill, +and the 3 s `TONE_GRACE_MS` in `test/interop/clients/js/driver.ts` expired on +silence. Once it read stuttered audio as a wrong tone. + +Reproduce it under the same starvation, then measure the grace from audible +playback (the player's own stalled/playing state) rather than wall time since +the check began, keeping the overall cell budget unchanged. + +Public API: none. Wire: none.