From 473d1a603b255e87711af976b58cc92deb92f646 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 22 Oct 2026 20:56:12 -0700 Subject: [PATCH 1/2] chore(quest): claim quest/m1/obs-test-nightly.md Quest-Claim: a3dd68e709c2511e From cd28bff5b6f120674792c887713f3c3750a7eb95 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 22 Oct 2026 21:05:28 -0700 Subject: [PATCH 2/2] ci(obs): run the OBS ThreadSanitizer suite nightly Nothing ran `just obs test`, so it failed on main unnoticed until #6277. A Nightly lane now runs it in the plain dev shell: the tests stub libobs, so the `.#obs` shell's obs-studio is not needed. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/nightly.yml | 5 +++++ cpp/obs/justfile | 4 ++-- quest/m1/README.md | 1 - quest/m1/obs-test-nightly.md | 17 ----------------- sh/obs/compile.sh | 2 +- sh/obs/test.sh | 6 +++--- 6 files changed, 11 insertions(+), 24 deletions(-) delete mode 100644 quest/m1/obs-test-nightly.md diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index edca5a31179..fb36ef7fd09 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -176,6 +176,11 @@ jobs: - name: OBS recipe: obs ci shell: .#obs + # The OBS unit tests under ThreadSanitizer, against stubbed libobs, so + # the plain shell suffices. A loaded run of moq-output-test can take + # 60 to 90 s instead of about 8; the suite took 2 to 4.5 min locally. + - name: OBS TSan + recipe: obs test - name: moq-c C fixtures recipe: rs c-tests diff --git a/cpp/obs/justfile b/cpp/obs/justfile index 199067ec1c5..beabc534c6b 100644 --- a/cpp/obs/justfile +++ b/cpp/obs/justfile @@ -47,8 +47,8 @@ ci preset="": ../../sh/obs/unit.sh # Unit-test the plugin sources against stubbed libobs and ffmpeg and the real -# moq-ffi, under ThreadSanitizer. Manual; `just obs ci` runs them without the -# sanitizer. +# moq-ffi, under ThreadSanitizer. Nightly runs it; `just obs ci` runs them +# without the sanitizer. test: ../../sh/obs/test.sh diff --git a/quest/m1/README.md b/quest/m1/README.md index afb1c5d6779..a17c7df9d19 100644 --- a/quest/m1/README.md +++ b/quest/m1/README.md @@ -139,7 +139,6 @@ tracks, so per-group stats stop costing cluster announces. - [NixOS leaf dials its root](/quest/m1/nix-cluster-connect.md) - the NixOS relay module sets the cluster variable the relay reads, so a leaf joins its root instead of running standalone - [Wayland display id](/quest/m1/wayland-display-id.md) - a requested display id off X11 is refused or honored, never silently replaced by a portal pick shared across publications - [CI housekeeping](/quest/m1/ci-housekeeping.md) - validate queue nextest at 24 threads and remove the actionlint queue ignore after its release -- [Nightly OBS TSan suite](/quest/m1/obs-test-nightly.md) - Nightly runs `just obs test` so a broken suite is seen - [libav polyfill fork fix](/quest/m1/libav-polyfill-fork.md) - our polyfill fork copies planar audio correctly and `@moq/hang` drops its patch - [Wire-compat audio](/quest/m1/wire-compat-audio.md) - the wire-compat media lanes decode and check the interop tone across releases - [Interop AAC](/quest/m1/interop-aac.md) - the Rust interop publisher adds an AAC tone and every subscriber checks it beside Opus diff --git a/quest/m1/obs-test-nightly.md b/quest/m1/obs-test-nightly.md deleted file mode 100644 index 5fb18ee3ae7..00000000000 --- a/quest/m1/obs-test-nightly.md +++ /dev/null @@ -1,17 +0,0 @@ -# [XS] Nightly runs the OBS TSan suite - -## Goal - -A Nightly job runs `just obs test` (the OBS plugin's ThreadSanitizer suite) -and its failure is visible like any other Nightly lane. - -## Plan - -Nothing ran it, so it failed every time on `main` unnoticed until -[moq-dev/moq#6277](https://github.com/moq-dev/moq/pull/6277) fixed its -suppression rule. Add it to the Nightly recipe matrix in -`.github/workflows/nightly.yml` with the `.#obs` shell it needs, and record its -runtime; a loaded TSan run of `moq-output-test` can take 60 to 90 s instead of -about 8. - -Public API: none. Wire: none. diff --git a/sh/obs/compile.sh b/sh/obs/compile.sh index 09aeaf5595e..577c49414b2 100755 --- a/sh/obs/compile.sh +++ b/sh/obs/compile.sh @@ -15,7 +15,7 @@ # # test/ is in scope because the tests drive the plugin through the same # generated moq headers, so an API that drifts under them fails here rather than -# only where obs.yml's path filter reaches; `just obs test` is manual. +# only where obs.yml's path filter reaches; `just obs test` runs nightly. set -euo pipefail here=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) diff --git a/sh/obs/test.sh b/sh/obs/test.sh index 90460c66bf5..40b3d72f2be 100755 --- a/sh/obs/test.sh +++ b/sh/obs/test.sh @@ -2,9 +2,9 @@ # Unit-test the plugin sources against stubbed libobs and ffmpeg and the real # moq-ffi, under ThreadSanitizer. # -# Manual because ThreadSanitizer needs its own build. `just obs ci` runs the -# same tests without it, so a regression these assertions catch still turns PR -# CI red; the sanitizer is what adds the races on top. Run this whenever you +# Nightly only, because ThreadSanitizer needs its own build. `just obs ci` runs +# the same tests without it, so a regression these assertions catch still turns +# PR CI red; the sanitizer is what adds the races on top. Run this whenever you # touch src/, especially the continuation plumbing, whose orderings the build # can't check. set -euo pipefail